From 0347549074e3fa715ad2582a2d9b513836dafdaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Ondra=C4=8Dka?= Date: Sun, 29 Mar 2026 15:31:25 +0200 Subject: [PATCH] st/bitmap: release the temporary bitmap sampler view st_cb_bitmap appends a temporary bitmap sampler view to the sampler view array passed to set_sampler_views(). 1a5c660ef5b8 changed this path to only release the extra YUV views returned by st_get_sampler_views(), but the temporary bitmap view is created locally and is not part of extra_sampler_views. It therefore stopped being released so release the temporary bitmap sampler view explicitly after drawing the bitmap quad. Fixes: 1a5c660ef5b8 ("st/bitmap: only release YUV samplerviews") (cherry picked from commit 33864e569e3d8d977524d002b4453e1cb749007c) Part-of: --- .pick_status.json | 2 +- src/mesa/state_tracker/st_cb_bitmap.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.pick_status.json b/.pick_status.json index f93ecd49ad6..cecf0c62bb2 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4974,7 +4974,7 @@ "description": "st/bitmap: release the temporary bitmap sampler view", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "1a5c660ef5b881d4193566a777b150ef912a4f9a", "notes": null diff --git a/src/mesa/state_tracker/st_cb_bitmap.c b/src/mesa/state_tracker/st_cb_bitmap.c index a05dc6369cf..02fffa735ae 100644 --- a/src/mesa/state_tracker/st_cb_bitmap.c +++ b/src/mesa/state_tracker/st_cb_bitmap.c @@ -468,6 +468,7 @@ st_flush_bitmap_cache(struct st_context *st) cache->fp, cache->scissor_enabled, cache->clamp_frag_color); + pipe->sampler_view_release(pipe, sv); } /* release/free the texture */