fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-09 02:28:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

iris: Require a 4K alignment for extra clear color BOs.

Browse source 
Apparently, we've been requiring a 4K alignment for internally allocated
clear color addresses to work around some unknown issues.  There's a
comment to that effect in iris_resource_create_with_modifiers().

When importing a dmabuf and tacking on an additional clear color BO, we
only required an alignment of 1.  This wasn't a problem for a long time
because all BO allocations were naturally aligned to the 4K page size.

However, once we enabled suballocation, we were able to allocate "BOs"
at 256B granularity, making this no longer 4K aligned.  Increase the
alignment requirement to 4K to match the behavior of our normal
allocations and also our previous behavior.

Fixes Piglit's ext_image_dma_buf_import-intel-modifiers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5482
Fixes: ce2e2296ab ("iris: Suballocate BO using the Gallium pb_slab mechanism")
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13326>
This commit is contained in:
Kenneth Graunke 2021-10-12 18:09:04 -07:00 • committed by Marge Bot
parent 94e07058ee
commit 02435f1294
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/gallium/drivers/iris/iris_resource.c
View file

@ -941,11 +941,16 @@ iris_resource_finish_aux_import(struct pipe_screen *pscreen,
import_aux_info(r[0], r[1]);
map_aux_addresses(screen, r[0], format, 0);
/* Add on a clear color BO. */
/* Add on a clear color BO.
*
* Also add some padding to make sure the fast clear color state buffer
* starts at a 4K alignment to avoid some unknown issues. See the
* matching comment in iris_resource_create_with_modifiers().
*/
if (iris_get_aux_clear_color_state_size(screen) > 0) {
res->aux.clear_color_bo =
iris_bo_alloc(screen->bufmgr, "clear color_buffer",
iris_get_aux_clear_color_state_size(screen), 1,
iris_get_aux_clear_color_state_size(screen), 4096,
IRIS_MEMZONE_OTHER, BO_ALLOC_ZEROED);
}
break;