fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 22:38:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk/blend: Stop setting color_mask = 0

Browse source 
These are all initialized to zero by the pan_blend_state initializer at
the top of the function.

Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/39274>
This commit is contained in:
Faith Ekstrand 2026-01-02 14:20:01 -05:00 • committed by Marge Bot
parent a4670a67e0
commit 020b1005c8
1 changed files with 5 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/panfrost/vulkan/panvk_vX_blend.c
View file

@ -319,35 +319,25 @@ panvk_per_arch(blend_emit_descs)(struct panvk_cmd_buffer *cmdbuf,
for (uint8_t i = 0; i < cb->attachment_count; i++) {
struct pan_blend_rt_state *rt = &bs.rts[i];
if (cal->color_map[i] == MESA_VK_ATTACHMENT_UNUSED) {
rt->equation.color_mask = 0;
if (cal->color_map[i] == MESA_VK_ATTACHMENT_UNUSED)
continue;
}
if (!(cb->color_write_enables & BITFIELD_BIT(i))) {
rt->equation.color_mask = 0;
if (!(cb->color_write_enables & BITFIELD_BIT(i)))
continue;
}
if (color_attachment_formats[i] == VK_FORMAT_UNDEFINED) {
rt->equation.color_mask = 0;
if (color_attachment_formats[i] == VK_FORMAT_UNDEFINED)
continue;
}
if (!cb->attachments[i].write_mask) {
rt->equation.color_mask = 0;
if (!cb->attachments[i].write_mask)
continue;
}
rt->format = vk_format_to_pipe_format(color_attachment_formats[i]);
/* Disable blending for LOGICOP_NOOP unless the format is float/srgb */
bool is_float = util_format_is_float(rt->format);
if (bs.logicop_enable && bs.logicop_func == PIPE_LOGICOP_NOOP &&
!(is_float || util_format_is_srgb(rt->format))) {
rt->equation.color_mask = 0;
!(is_float || util_format_is_srgb(rt->format)))
continue;
}
rt->nr_samples = color_attachment_samples[i];
rt->equation.blend_enable = cb->attachments[i].blend_enable;