fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-04-24 11:30:44 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/decode: Don't try to dereference heap mapping

Browse source 
It might not be mapped from our perspective, we shouldn't crash on that
just for a validation that isn't actually correct.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6373>
This commit is contained in:
Alyssa Rosenzweig 2020-08-17 13:48:26 -04:00 • committed by Tomeu Vizoso
parent b41692caf4
commit 01d12c353e
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/panfrost/lib/decode.c
View file

@ -393,9 +393,6 @@ pandecode_midgard_tiler_descriptor(
MEMORY_PROP(t, heap_start);
assert(t->heap_end >= t->heap_start);
struct pandecode_mapped_memory *heap =
pandecode_find_mapped_gpu_mem_containing(t->heap_start);
unsigned heap_size = t->heap_end - t->heap_start;
/* Tiling is enabled with a special flag */
@ -405,13 +402,6 @@ pandecode_midgard_tiler_descriptor(
bool tiling_enabled = hierarchy_mask;
if (tiling_enabled) {
/* When tiling is enabled, the heap should be a tight fit */
unsigned heap_offset = t->heap_start - heap->gpu_va;
if ((heap_offset + heap_size) != heap->length) {
pandecode_msg("XXX: heap size %u (expected %zu)\n",
heap_size, heap->length - heap_offset);
}
/* We should also have no other flags */
if (tiler_flags)
pandecode_msg("XXX: unexpected tiler %X\n", tiler_flags);