fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-07 23:50:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

iris: Update comment about 3-component formats and buffer textures

Browse source 
You can't render to PIPE_BUFFER so there's no reason to prefer RGBX.
PBO upload would like to use proper RGB textures as source data.
This commit is contained in:
Kenneth Graunke 2019-10-07 16:03:14 -07:00
parent 64207ebe66
commit 016c19bc89
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/gallium/drivers/iris/iris_formats.c
View file

@ -479,12 +479,14 @@ iris_is_format_supported(struct pipe_screen *pscreen,
if (!is_integer)
supported &= isl_format_supports_filtering(devinfo, format);
/* Don't advertise 3-component RGB formats. This ensures that they
* are renderable from an API perspective since the state tracker will
* fall back to RGBA or RGBX, which are renderable. We want to render
* internally for copies and blits, even if the application doesn't.
/* Don't advertise 3-component RGB formats for non-buffer textures.
* This ensures that they are renderable from an API perspective since
* the state tracker will fall back to RGBA or RGBX, which are
* renderable. We want to render internally for copies and blits,
* even if the application doesn't.
*
* We do need to advertise 32-bit RGB for texture buffers though.
* Buffer textures don't need to be renderable, so we support real RGB.
* This is useful for PBO upload, and 32-bit RGB support is mandatory.
*/
if (target != PIPE_BUFFER)
supported &= fmtl->bpb != 24 && fmtl->bpb != 48 && fmtl->bpb != 96;