fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

iris: fix indirect draw refcnt imbalance

Browse source 
Indeed, the object ring_bo was not freed.

For instance, this issue is triggered with:
"piglit/bin/arb_shader_image_load_store-host-mem-barrier -auto -fbo"
while setting GALLIUM_REFCNT_LOG=refcnt.log.

Fixes: 5438b19104 ("iris: enable generated indirect draws")
Signed-off-by: Patrick Lerda <patrick9876@free.fr>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30975>
(cherry picked from commit 6ac3beeb85)
This commit is contained in:
Patrick Lerda 2024-08-28 15:35:04 +02:00 • committed by Dylan Baker
parent 9ad801d902
commit 00cfae94c0
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -854,7 +854,7 @@
"description": "iris: fix indirect draw refcnt imbalance",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "5438b1910464e4b17fe0248a96a6ed98f0280a20",
"notes": null

1
src/gallium/drivers/iris/iris_context.c
View file

@ -248,6 +248,7 @@ iris_destroy_context(struct pipe_context *ctx)
iris_destroy_batches(ice);
iris_destroy_binder(&ice->state.binder);
iris_bo_unreference(ice->draw.generation.ring_bo);
iris_utrace_fini(ice);