From 000f14f7fdb5099f9c2651a6be2be88628d71293 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Mon, 10 Feb 2025 18:09:16 +0100 Subject: [PATCH] nir/opt_algebraic: optimize ineg(a) == #b MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit No Foz-DB changes. v2 (idr): Remove some patterns that are now redundant. These were originally removed in a commit later in the MR. Reviewed-by: Ian Romanick Reviewed-by: Alyssa Rosenzweig Reviewed-by: Timur Kristóf Part-of: --- src/compiler/nir/nir_opt_algebraic.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index a2d50e16ae9..4c4b4d6e37a 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++ b/src/compiler/nir/nir_opt_algebraic.py @@ -691,8 +691,8 @@ optimizations.extend([ (('fneu', a, '#b(is_negative_zero)'), ('fneu', 0.0, a)), (('feq', '#b(is_negative_zero)', a), ('feq', a, 0.0)), - (('ieq', ('ineg', a), 0), ('ieq', a, 0)), - (('ine', ('ineg', a), 0), ('ine', a, 0)), + (('ieq', ('ineg', 'a(is_not_const)'), '#b'), ('ieq', a, ('ineg', b))), + (('ine', ('ineg', 'a(is_not_const)'), '#b'), ('ine', a, ('ineg', b))), (('ieq', ('iabs', a), 0), ('ieq', a, 0)), (('ine', ('iabs', a), 0), ('ine', a, 0)), @@ -1454,8 +1454,6 @@ for s in [8, 16, 32, 64]: ]) optimizations.extend([ - (('ieq', ('ineg', ('b2i', 'a@1')), -1), a), - (('ine', ('ineg', ('b2i', 'a@1')), -1), ('inot', a)), (('ige', ('ineg', ('b2i', 'a@1')), 0), ('inot', a)), (('ilt', ('ineg', ('b2i', 'a@1')), 0), a), (('ult', 0, ('ineg', ('b2i', 'a@1'))), a),