2015-05-08 22:32:37 -07:00
|
|
|
/*
|
|
|
|
|
* Copyright © 2015 Intel Corporation
|
|
|
|
|
*
|
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
|
*
|
|
|
|
|
* The above copyright notice and this permission notice (including the next
|
|
|
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
|
|
|
* Software.
|
|
|
|
|
*
|
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
|
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
|
|
|
* IN THE SOFTWARE.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <stdarg.h>
|
|
|
|
|
#include <stdio.h>
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
#include <string.h>
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <assert.h>
|
|
|
|
|
|
2015-07-17 15:04:27 -07:00
|
|
|
#include "anv_private.h"
|
2017-02-15 15:41:50 -08:00
|
|
|
#include "vk_enum_to_str.h"
|
2015-05-08 22:32:37 -07:00
|
|
|
|
2015-05-28 08:07:54 -07:00
|
|
|
/** Log an error message. */
|
|
|
|
|
void anv_printflike(1, 2)
|
|
|
|
|
anv_loge(const char *format, ...)
|
|
|
|
|
{
|
|
|
|
|
va_list va;
|
|
|
|
|
|
|
|
|
|
va_start(va, format);
|
|
|
|
|
anv_loge_v(format, va);
|
|
|
|
|
va_end(va);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/** \see anv_loge() */
|
|
|
|
|
void
|
|
|
|
|
anv_loge_v(const char *format, va_list va)
|
|
|
|
|
{
|
mesa: Promote Intel's simple logging façade for Android to util/
I'm bringing up freedreno Vulkan on an Android phone, and my pains are
exactly what Chad said when working on Intel's vulkan for Android in
aa716db0f64d ("intel: Add simple logging façade for Android (v2)"):
On Android, stdio goes to /dev/null. On Android, remote gdb is even
more painful than the usual remote gdb. On Android, nothing works like
you expect and debugging is hell. I need logging.
This patch introduces a small, simple logging API that can easily wrap
Android's API. On non-Android platforms, this logger does nothing
fancy. It follows the time-honored Unix tradition of spewing
everything to stderr with minimal fuss.
My goal here is not perfection. My goal is to make a minimal, clean API,
that people hate merely a little instead of a lot, and that's good
enough to let me bring up Android Vulkan. And it needs to be fast,
which means it must be small. No one wants to their game to miss frames
while aiming a flaming bow into the jaws of an angry robot t-rex, and
thus become t-rex breakfast, because some fool had too much fun desiging
a bloated, ideal logging API.
Compared to trusty fprintf, _mesa_log[ewi]() is actually usable on
Android. Compared to os_log_message(), this has different error levels
and supports format arguments.
The only code change in the move is wrapping flockfile/funlockfile in
!DETECT_OS_WINDOWS, since mingw32 doesn't have it. Windows likely wants
different logging code, anyway.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6806>
2020-09-21 12:53:14 -07:00
|
|
|
mesa_loge_v(format, va);
|
2015-05-12 13:43:36 -07:00
|
|
|
}
|
|
|
|
|
|
2021-01-28 17:17:59 -06:00
|
|
|
void
|
|
|
|
|
__anv_perf_warn(struct anv_device *device,
|
|
|
|
|
const struct vk_object_base *object,
|
2017-08-25 09:50:11 +03:00
|
|
|
const char *file, int line, const char *format, ...)
|
2017-03-07 09:13:15 -08:00
|
|
|
{
|
|
|
|
|
va_list ap;
|
|
|
|
|
char buffer[256];
|
anv: give more room to debug report
The error buffer is limited to 256, but the report contains the
filename and possibly other data. So give it more space.
Avoids the warnings
../../src/intel/vulkan/anv_util.c: In function ‘__anv_perf_warn’:
../../src/intel/vulkan/anv_util.c:66:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 254 [-Wformat-truncation=]
snprintf(report, sizeof(report), "%s: %s", file, buffer);
^~ ~~~~~~
../../src/intel/vulkan/anv_util.c:66:4: note: ‘snprintf’ output 3 or more bytes (assuming 258) into a destination of size 256
snprintf(report, sizeof(report), "%s: %s", file, buffer);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/intel/vulkan/anv_util.c: In function ‘__vk_errorf’:
../../src/intel/vulkan/anv_util.c:96:48: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 252 [-Wformat-truncation=]
snprintf(report, sizeof(report), "%s:%d: %s (%s)", file, line, buffer,
^~ ~~~~~~
../../src/intel/vulkan/anv_util.c:96:7: note: ‘snprintf’ output 8 or more bytes (assuming 263) into a destination of size 256
snprintf(report, sizeof(report), "%s:%d: %s (%s)", file, line, buffer,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error_str);
~~~~~~~~~~
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
2018-07-16 13:56:23 -07:00
|
|
|
char report[512];
|
2017-03-07 09:13:15 -08:00
|
|
|
|
|
|
|
|
va_start(ap, format);
|
|
|
|
|
vsnprintf(buffer, sizeof(buffer), format, ap);
|
|
|
|
|
va_end(ap);
|
|
|
|
|
|
2017-08-25 09:50:11 +03:00
|
|
|
snprintf(report, sizeof(report), "%s: %s", file, buffer);
|
|
|
|
|
|
2021-01-28 17:43:58 -06:00
|
|
|
vk_debug_report(&device->physical->instance->vk,
|
2018-01-09 03:22:56 +01:00
|
|
|
VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT,
|
2021-01-28 17:20:24 -06:00
|
|
|
object, line, 0, "anv", report);
|
2017-08-25 09:50:11 +03:00
|
|
|
|
mesa: Promote Intel's simple logging façade for Android to util/
I'm bringing up freedreno Vulkan on an Android phone, and my pains are
exactly what Chad said when working on Intel's vulkan for Android in
aa716db0f64d ("intel: Add simple logging façade for Android (v2)"):
On Android, stdio goes to /dev/null. On Android, remote gdb is even
more painful than the usual remote gdb. On Android, nothing works like
you expect and debugging is hell. I need logging.
This patch introduces a small, simple logging API that can easily wrap
Android's API. On non-Android platforms, this logger does nothing
fancy. It follows the time-honored Unix tradition of spewing
everything to stderr with minimal fuss.
My goal here is not perfection. My goal is to make a minimal, clean API,
that people hate merely a little instead of a lot, and that's good
enough to let me bring up Android Vulkan. And it needs to be fast,
which means it must be small. No one wants to their game to miss frames
while aiming a flaming bow into the jaws of an angry robot t-rex, and
thus become t-rex breakfast, because some fool had too much fun desiging
a bloated, ideal logging API.
Compared to trusty fprintf, _mesa_log[ewi]() is actually usable on
Android. Compared to os_log_message(), this has different error levels
and supports format arguments.
The only code change in the move is wrapping flockfile/funlockfile in
!DETECT_OS_WINDOWS, since mingw32 doesn't have it. Windows likely wants
different logging code, anyway.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6806>
2020-09-21 12:53:14 -07:00
|
|
|
mesa_logw("%s:%d: PERF: %s", file, line, buffer);
|
2017-03-07 09:13:15 -08:00
|
|
|
}
|
|
|
|
|
|
2015-08-26 03:41:37 -07:00
|
|
|
VkResult
|
2021-01-28 17:17:59 -06:00
|
|
|
__vk_errorv(struct anv_instance *instance,
|
|
|
|
|
const struct vk_object_base *object, VkResult error,
|
2018-10-26 08:24:49 -05:00
|
|
|
const char *file, int line, const char *format, va_list ap)
|
2015-08-26 03:41:37 -07:00
|
|
|
{
|
2015-08-26 04:03:38 -07:00
|
|
|
char buffer[256];
|
anv: give more room to debug report
The error buffer is limited to 256, but the report contains the
filename and possibly other data. So give it more space.
Avoids the warnings
../../src/intel/vulkan/anv_util.c: In function ‘__anv_perf_warn’:
../../src/intel/vulkan/anv_util.c:66:42: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 254 [-Wformat-truncation=]
snprintf(report, sizeof(report), "%s: %s", file, buffer);
^~ ~~~~~~
../../src/intel/vulkan/anv_util.c:66:4: note: ‘snprintf’ output 3 or more bytes (assuming 258) into a destination of size 256
snprintf(report, sizeof(report), "%s: %s", file, buffer);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/intel/vulkan/anv_util.c: In function ‘__vk_errorf’:
../../src/intel/vulkan/anv_util.c:96:48: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 252 [-Wformat-truncation=]
snprintf(report, sizeof(report), "%s:%d: %s (%s)", file, line, buffer,
^~ ~~~~~~
../../src/intel/vulkan/anv_util.c:96:7: note: ‘snprintf’ output 8 or more bytes (assuming 263) into a destination of size 256
snprintf(report, sizeof(report), "%s:%d: %s (%s)", file, line, buffer,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error_str);
~~~~~~~~~~
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
2018-07-16 13:56:23 -07:00
|
|
|
char report[512];
|
2015-08-26 04:03:38 -07:00
|
|
|
|
2017-02-15 15:41:50 -08:00
|
|
|
const char *error_str = vk_Result_to_str(error);
|
2015-08-26 04:03:38 -07:00
|
|
|
|
|
|
|
|
if (format) {
|
|
|
|
|
vsnprintf(buffer, sizeof(buffer), format, ap);
|
|
|
|
|
|
2017-08-25 09:55:39 +03:00
|
|
|
snprintf(report, sizeof(report), "%s:%d: %s (%s)", file, line, buffer,
|
|
|
|
|
error_str);
|
2015-08-26 04:03:38 -07:00
|
|
|
} else {
|
2017-08-25 09:55:39 +03:00
|
|
|
snprintf(report, sizeof(report), "%s:%d: %s", file, line, error_str);
|
2015-08-26 04:03:38 -07:00
|
|
|
}
|
2015-08-26 03:41:37 -07:00
|
|
|
|
2018-01-19 08:45:10 +01:00
|
|
|
if (instance) {
|
2021-01-28 17:43:58 -06:00
|
|
|
vk_debug_report(&instance->vk, VK_DEBUG_REPORT_ERROR_BIT_EXT,
|
2021-01-28 17:20:24 -06:00
|
|
|
object, line, 0, "anv", report);
|
2018-01-19 08:45:10 +01:00
|
|
|
}
|
2017-08-25 09:55:39 +03:00
|
|
|
|
mesa: Promote Intel's simple logging façade for Android to util/
I'm bringing up freedreno Vulkan on an Android phone, and my pains are
exactly what Chad said when working on Intel's vulkan for Android in
aa716db0f64d ("intel: Add simple logging façade for Android (v2)"):
On Android, stdio goes to /dev/null. On Android, remote gdb is even
more painful than the usual remote gdb. On Android, nothing works like
you expect and debugging is hell. I need logging.
This patch introduces a small, simple logging API that can easily wrap
Android's API. On non-Android platforms, this logger does nothing
fancy. It follows the time-honored Unix tradition of spewing
everything to stderr with minimal fuss.
My goal here is not perfection. My goal is to make a minimal, clean API,
that people hate merely a little instead of a lot, and that's good
enough to let me bring up Android Vulkan. And it needs to be fast,
which means it must be small. No one wants to their game to miss frames
while aiming a flaming bow into the jaws of an angry robot t-rex, and
thus become t-rex breakfast, because some fool had too much fun desiging
a bloated, ideal logging API.
Compared to trusty fprintf, _mesa_log[ewi]() is actually usable on
Android. Compared to os_log_message(), this has different error levels
and supports format arguments.
The only code change in the move is wrapping flockfile/funlockfile in
!DETECT_OS_WINDOWS, since mingw32 doesn't have it. Windows likely wants
different logging code, anyway.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6806>
2020-09-21 12:53:14 -07:00
|
|
|
mesa_loge("%s", report);
|
2017-08-25 09:55:39 +03:00
|
|
|
|
2015-08-26 03:41:37 -07:00
|
|
|
return error;
|
|
|
|
|
}
|
2018-10-26 08:24:49 -05:00
|
|
|
|
|
|
|
|
VkResult
|
2021-01-28 17:17:59 -06:00
|
|
|
__vk_errorf(struct anv_instance *instance,
|
|
|
|
|
const struct vk_object_base *object, VkResult error,
|
2018-10-26 08:24:49 -05:00
|
|
|
const char *file, int line, const char *format, ...)
|
|
|
|
|
{
|
|
|
|
|
va_list ap;
|
|
|
|
|
|
|
|
|
|
va_start(ap, format);
|
2021-01-28 17:17:59 -06:00
|
|
|
__vk_errorv(instance, object, error, file, line, format, ap);
|
2018-10-26 08:24:49 -05:00
|
|
|
va_end(ap);
|
|
|
|
|
|
|
|
|
|
return error;
|
|
|
|
|
}
|
2021-03-11 08:40:56 -08:00
|
|
|
|
|
|
|
|
void
|
|
|
|
|
anv_dump_pipe_bits(enum anv_pipe_bits bits)
|
|
|
|
|
{
|
|
|
|
|
if (bits & ANV_PIPE_DEPTH_CACHE_FLUSH_BIT)
|
|
|
|
|
fputs("+depth_flush ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_DATA_CACHE_FLUSH_BIT)
|
|
|
|
|
fputs("+dc_flush ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_RENDER_TARGET_CACHE_FLUSH_BIT)
|
|
|
|
|
fputs("+rt_flush ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_TILE_CACHE_FLUSH_BIT)
|
|
|
|
|
fputs("+tile_flush ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_STATE_CACHE_INVALIDATE_BIT)
|
|
|
|
|
fputs("+state_inval ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_CONSTANT_CACHE_INVALIDATE_BIT)
|
|
|
|
|
fputs("+const_inval ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_VF_CACHE_INVALIDATE_BIT)
|
|
|
|
|
fputs("+vf_inval ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_TEXTURE_CACHE_INVALIDATE_BIT)
|
|
|
|
|
fputs("+tex_inval ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_INSTRUCTION_CACHE_INVALIDATE_BIT)
|
|
|
|
|
fputs("+ic_inval ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_STALL_AT_SCOREBOARD_BIT)
|
|
|
|
|
fputs("+pb_stall ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_DEPTH_STALL_BIT)
|
|
|
|
|
fputs("+depth_stall ", stderr);
|
|
|
|
|
if (bits & ANV_PIPE_CS_STALL_BIT)
|
|
|
|
|
fputs("+cs_stall ", stderr);
|
|
|
|
|
}
|