From fe07584e050db55d0e41ed52c0c42f5e8ae84315 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Wed, 1 Jun 2016 14:35:06 -0400 Subject: [PATCH] freedreno: fix potential fd leak in error path Signed-off-by: Rob Clark --- freedreno/freedreno_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/freedreno/freedreno_device.c b/freedreno/freedreno_device.c index 027414ec..3da5c7c1 100644 --- a/freedreno/freedreno_device.c +++ b/freedreno/freedreno_device.c @@ -95,9 +95,12 @@ out: */ struct fd_device * fd_device_new_dup(int fd) { - struct fd_device *dev = fd_device_new(dup(fd)); + int dup_fd = dup(fd); + struct fd_device *dev = fd_device_new(dup_fd); if (dev) dev->closefd = 1; + else + close(dup_fd); return dev; }