libinput/src/util-bits.h
Peter Hutterer aa9d5bf630 util: silence two clang-tidy false positives
Both about the same complaint, somehow it is of the impression that
masks->mask can be an uninitialized value. The only place where we
allocate those is in _infmask_ensure_size() and they're set to zero
there.

libinput/src/util-bits.h:166:22: warning: The left operand of '&' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
  166 |         return !!(mask.mask & bit(bit));
      |                             ^
libinput/src/util-bits.h:444:2: note: Calling 'infmask_set_bit'
  444 |         infmask_set_bit(&m, mask);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
libinput/src/util-bits.h:394:15: note: Calling 'infmask_bit_is_set'
  394 |         bool isset = infmask_bit_is_set(mask, bit);
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libinput/src/util-bits.h:382:13: note: Field 'mask' is non-null
  382 |         if (!mask->mask || bit / bitmask_size() >= mask->nmasks)
      |                    ^
libinput/src/util-bits.h:382:6: note: Left side of '||' is false
  382 |         if (!mask->mask || bit / bitmask_size() >= mask->nmasks)
      |             ^
libinput/src/util-bits.h:382:2: note: Taking false branch
  382 |         if (!mask->mask || bit / bitmask_size() >= mask->nmasks)
      |         ^
libinput/src/util-bits.h:385:9: note: Uninitialized value stored to 'mask.mask'
  385 |         return bitmask_bit_is_set(mask->mask[bit / bitmask_size()], // NOLINT(core.UndefinedBinaryOperatorResult)
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  386 |                                   bit % bitmask_size());
      |                                   ~~~~~~~~~~~~~~~~~~~~~
libinput/src/util-bits.h:385:9: note: Calling 'bitmask_bit_is_set'
  385 |         return bitmask_bit_is_set(mask->mask[bit / bitmask_size()], // NOLINT(core.UndefinedBinaryOperatorResult)
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  386 |                                   bit % bitmask_size());
      |                                   ~~~~~~~~~~~~~~~~~~~~~
libinput/src/util-bits.h:166:22: note: The left operand of '&' is a garbage value
  166 |         return !!(mask.mask & bit(bit));
      |                   ~~~~~~~~~ ^

Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1292>
2025-08-06 07:34:55 +00:00

435 lines
9.5 KiB
C

/*
* Copyright © 2008-2011 Kristian Høgsberg
* Copyright © 2011 Intel Corporation
* Copyright © 2013-2015 Red Hat, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#pragma once
#include "config.h"
#include <assert.h>
#include <limits.h>
#include <stdarg.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#include <stdlib.h>
#include "util-macros.h"
#define bit(x_) (1UL << (x_))
#define NBITS(b) (b * 8)
#define LONG_BITS (sizeof(long) * 8)
#define NLONGS(x) (((x) + LONG_BITS - 1) / LONG_BITS)
#define NCHARS(x) ((size_t)(((x) + 7) / 8))
/* This bitfield helper implementation is taken from from libevdev-util.h,
* except that it has been modified to work with arrays of unsigned chars
*/
static inline bool
bit_is_set(const unsigned char *array, int bit)
{
return !!(array[bit / 8] & (1 << (bit % 8)));
}
static inline void
set_bit(unsigned char *array, int bit)
{
array[bit / 8] |= (1 << (bit % 8));
}
static inline void
clear_bit(unsigned char *array, int bit)
{
array[bit / 8] &= ~(1 << (bit % 8));
}
static inline bool
long_bit_is_set(const unsigned long *array, int bit)
{
return !!(array[bit / LONG_BITS] & (1ULL << (bit % LONG_BITS)));
}
static inline void
long_set_bit(unsigned long *array, int bit)
{
array[bit / LONG_BITS] |= (1ULL << (bit % LONG_BITS));
}
static inline void
long_clear_bit(unsigned long *array, int bit)
{
array[bit / LONG_BITS] &= ~(1ULL << (bit % LONG_BITS));
}
static inline void
long_set_bit_state(unsigned long *array, int bit, int state)
{
if (state)
long_set_bit(array, bit);
else
long_clear_bit(array, bit);
}
static inline bool
long_any_bit_set(unsigned long *array, size_t size)
{
unsigned long i;
assert(size > 0);
for (i = 0; i < size; i++)
if (array[i] != 0)
return true;
return false;
}
/* A wrapper around a bit mask to avoid type confusion */
typedef struct {
uint32_t mask;
} bitmask_t;
static inline size_t
bitmask_size(void)
{
return 32;
}
static inline uint32_t
bitmask_as_u32(bitmask_t mask)
{
return mask.mask;
}
static inline bool
bitmask_is_empty(bitmask_t mask)
{
return mask.mask == 0;
}
static inline bool
bitmask_any(bitmask_t mask, bitmask_t bits)
{
return !!(mask.mask & bits.mask);
}
static inline bool
bitmask_all(bitmask_t mask, bitmask_t bits)
{
return bits.mask != 0 && (mask.mask & bits.mask) == bits.mask;
}
_nonnull_(1) static inline bool bitmask_merge(bitmask_t *mask, bitmask_t bits)
{
bool all = bitmask_all(*mask, bits);
mask->mask |= bits.mask;
return all;
}
_nonnull_(1) static inline bool bitmask_clear(bitmask_t *mask, bitmask_t bits)
{
bool all = bitmask_all(*mask, bits);
mask->mask &= ~bits.mask;
return all;
}
static inline bool
bitmask_bit_is_set(bitmask_t mask, unsigned int bit)
{
return !!(mask.mask & bit(bit)); // NOLINT: core.UndefinedBinaryOperatorResult
}
_nonnull_(1) static inline bool bitmask_set_bit(bitmask_t *mask, unsigned int bit)
{
bool isset = bitmask_bit_is_set(*mask, bit);
mask->mask |= bit(bit);
return isset;
}
_nonnull_(1) static inline bool bitmask_clear_bit(bitmask_t *mask, unsigned int bit)
{
bool isset = bitmask_bit_is_set(*mask, bit);
mask->mask &= ~bit(bit);
return isset;
}
static inline bitmask_t
bitmask_new(void)
{
bitmask_t m = { 0 };
return m;
}
static inline bitmask_t
bitmask_from_bit(unsigned int bit)
{
bitmask_t m = { .mask = bit(bit) };
return m;
}
static inline bitmask_t
bitmask_from_u32(uint32_t mask)
{
bitmask_t m = { .mask = mask };
return m;
}
static inline bitmask_t
_bitmask_from_masks(uint32_t mask1, ...)
{
uint32_t mask = mask1;
va_list args;
va_start(args, mask1);
uint32_t v = va_arg(args, unsigned int);
while (v != 0) {
mask |= v;
v = va_arg(args, unsigned int);
}
va_end(args);
return bitmask_from_u32(mask);
}
#define bitmask_from_masks(...) \
_bitmask_from_masks(__VA_ARGS__, 0)
static inline bitmask_t
_bitmask_from_bits(unsigned int bit1, ...)
{
uint32_t mask = bit(bit1);
va_list args;
va_start(args, bit1);
uint32_t v = va_arg(args, unsigned int);
while (v < 32) {
mask |= bit(v);
v = va_arg(args, unsigned int);
}
va_end(args);
return bitmask_from_u32(mask);
}
#define bitmask_from_bits(...) \
_bitmask_from_bits(__VA_ARGS__, 32)
/* An infinite bitmask that grows as needed.
*
* Note that unlike the bitmask_t this struct contains
* pointers and some care must be taken when using assign-by-value.
*/
typedef struct {
bitmask_t *mask;
size_t nmasks;
} infmask_t;
static inline size_t
_infmask_size_for_bit(unsigned int bit)
{
return (bit / bitmask_size()) + 1;
}
_nonnull_(1) static inline void _infmask_ensure_size(infmask_t *mask, unsigned int bit)
{
size_t required = _infmask_size_for_bit(bit);
if (required > mask->nmasks) {
mask->mask = realloc(mask->mask, required * sizeof(bitmask_t));
/* Zero out the new memory */
for (size_t i = mask->nmasks; i < required; i++)
mask->mask[i] = bitmask_new();
mask->nmasks = required;
}
/* for clang-tidy, poor thing gets confused otherwise */
assert(mask->mask);
assert(mask->nmasks >= 1);
}
static inline infmask_t
infmask_new(void)
{
infmask_t m = { .mask = NULL, .nmasks = 0 };
return m;
}
_nonnull_(1) static inline void infmask_reset(infmask_t *mask)
{
free(mask->mask);
mask->mask = NULL;
mask->nmasks = 0;
}
_nonnull_(1) static inline void infmask_destroy(infmask_t *mask)
{
infmask_reset(mask);
free(mask);
}
_nonnull_(1) static inline bool infmask_is_empty(const infmask_t *mask)
{
if (!mask->mask)
return true;
for (size_t i = 0; i < mask->nmasks; i++)
if (!bitmask_is_empty(mask->mask[i]))
return false;
return true;
}
_nonnull_(1) static inline bool infmask_any(const infmask_t *mask,
const infmask_t *bits)
{
if (!mask->mask || !bits->mask)
return false;
size_t min_size = min(mask->nmasks, bits->nmasks);
for (size_t i = 0; i < min_size; i++)
if (bitmask_any(mask->mask[i], bits->mask[i]))
return true;
return false;
}
_nonnull_(1) static inline bool infmask_all(const infmask_t *mask,
const infmask_t *bits)
{
if (!bits->mask)
return true;
if (!mask->mask)
return false;
size_t min_size = min(mask->nmasks, bits->nmasks);
for (size_t i = 0; i < min_size; i++)
if (!bitmask_all(mask->mask[i], bits->mask[i]))
return false;
/* Check if bits has any bits set beyond min_size */
for (size_t i = min_size; i < bits->nmasks; i++)
if (!bitmask_is_empty(bits->mask[i]))
return false;
return true;
}
_nonnull_(1) static inline bool infmask_merge(infmask_t *mask, const infmask_t *bits)
{
if (!bits->mask)
return true;
_infmask_ensure_size(mask, bits->nmasks * bitmask_size() - 1);
bool all = true;
for (size_t i = 0; i < bits->nmasks; i++) {
all = all && bitmask_all(mask->mask[i], bits->mask[i]);
bitmask_merge(&mask->mask[i], bits->mask[i]);
}
return all;
}
_nonnull_(1) static inline bool infmask_clear(infmask_t *mask, const infmask_t *bits)
{
if (!mask->mask || !bits->mask)
return false;
bool all = infmask_all(mask, bits);
size_t min_size = min(mask->nmasks, bits->nmasks);
for (size_t i = 0; i < min_size; i++)
bitmask_clear(&mask->mask[i], bits->mask[i]);
return all;
}
_nonnull_(1) static inline bool infmask_bit_is_set(const infmask_t *mask,
unsigned int bit)
{
if (!mask->mask || bit / bitmask_size() >= mask->nmasks)
return false;
return bitmask_bit_is_set(
mask->mask[bit / bitmask_size()], // NOLINT:
// core.UndefinedBinaryOperatorResult
bit % bitmask_size());
}
_nonnull_(1) static inline bool infmask_set_bit(infmask_t *mask, unsigned int bit)
{
_infmask_ensure_size(mask, bit);
bool isset = infmask_bit_is_set(mask, bit);
bitmask_set_bit(&mask->mask[bit / bitmask_size()], bit % bitmask_size());
return isset;
}
_nonnull_(1) static inline bool infmask_clear_bit(infmask_t *mask, unsigned int bit)
{
if (!mask->mask || bit / bitmask_size() >= mask->nmasks)
return false;
bool isset = infmask_bit_is_set(mask, bit);
bitmask_clear_bit(&mask->mask[bit / bitmask_size()], bit % bitmask_size());
return isset;
}
static inline infmask_t
infmask_from_bit(unsigned int bit)
{
infmask_t m = infmask_new();
infmask_set_bit(&m, bit);
return m;
}
static inline infmask_t
_infmask_from_bits(unsigned int bit1, ...)
{
infmask_t m = infmask_new();
infmask_set_bit(&m, bit1);
va_list args;
va_start(args, bit1);
unsigned int v = va_arg(args, unsigned int);
while (v < UINT_MAX) {
infmask_set_bit(&m, v);
v = va_arg(args, unsigned int);
}
va_end(args);
return m;
}
#define infmask_from_bits(...) \
_infmask_from_bits(__VA_ARGS__, UINT_MAX)
static inline infmask_t
infmask_from_u32(uint32_t mask)
{
infmask_t m = infmask_new();
infmask_set_bit(&m, mask);
return m;
}