From f86d5ab2ab49178c96b582c628700ab411e81fc8 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Wed, 11 Mar 2026 20:54:43 +1000 Subject: [PATCH] test: add missing button state assertion for eraser button release The second 'Expect button event' block in tablet_eraser_button_different_buttons is missing the button state assertion that the first block has. This event should be a BUTTON_STATE_RELEASED (the eraser left proximity), but without the check the test passes even if the state is wrong. Co-Authored-by: Claude Code Part-of: --- test/test-tablet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test-tablet.c b/test/test-tablet.c index a6584b5e..3afeb9d0 100644 --- a/test/test-tablet.c +++ b/test/test-tablet.c @@ -8024,6 +8024,8 @@ START_TEST(tablet_eraser_button_different_buttons) _destroy_(libinput_event) *ev = libinput_get_event(li); auto tev = litest_is_tablet_event(ev, LIBINPUT_EVENT_TABLET_TOOL_BUTTON); + litest_assert_enum_eq(libinput_event_tablet_tool_get_button_state(tev), + LIBINPUT_BUTTON_STATE_RELEASED); litest_assert_int_eq(libinput_event_tablet_tool_get_button(tev), eraser_button_mapping); litest_assert_ptr_eq(libinput_event_tablet_tool_get_tool(tev), pen);