fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-20 08:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

touchpad: post a SYN_REPORT after a faked trackpoint button

Browse source 
This has no real effect at the moment because the fallback interface doesn't
care much about SYN_REPORT, it processes events as they come in. But it's a
bug nonetheless, the process() callback expects correct event frames.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer 2017-11-13 13:29:00 +10:00
parent 5561108ac4
commit dc7fb65db5
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/evdev-mt-touchpad-buttons.c
View file

@ -1055,15 +1055,21 @@ tp_notify_clickpadbutton(struct tp_dispatch *tp,
if (is_topbutton && tp->buttons.trackpoint) { if (is_topbutton && tp->buttons.trackpoint) {
struct evdev_dispatch *dispatch = tp->buttons.trackpoint->dispatch; struct evdev_dispatch *dispatch = tp->buttons.trackpoint->dispatch;
struct input_event event; struct input_event event;
struct input_event syn_report = {{ 0, 0 }, EV_SYN, SYN_REPORT, 0 };
event.time = us2tv(time); event.time = us2tv(time);
event.type = EV_KEY; event.type = EV_KEY;
event.code = button; event.code = button;
event.value = (state == LIBINPUT_BUTTON_STATE_PRESSED) ? 1 : 0; event.value = (state == LIBINPUT_BUTTON_STATE_PRESSED) ? 1 : 0;
syn_report.time = event.time;
dispatch->interface->process(dispatch, dispatch->interface->process(dispatch,
tp->buttons.trackpoint, tp->buttons.trackpoint,
&event, &event,
time); time);
dispatch->interface->process(dispatch,
tp->buttons.trackpoint,
&syn_report,
time);
return 1; return 1;
} }

5
src/evdev-mt-touchpad.c
View file

@ -521,6 +521,7 @@ tp_process_trackpoint_button(struct tp_dispatch *tp,
{ {
struct evdev_dispatch *dispatch; struct evdev_dispatch *dispatch;
struct input_event event; struct input_event event;
struct input_event syn_report = {{ 0, 0 }, EV_SYN, SYN_REPORT, 0 };
if (!tp->buttons.trackpoint) if (!tp->buttons.trackpoint)
return; return;
@ -528,6 +529,7 @@ tp_process_trackpoint_button(struct tp_dispatch *tp,
dispatch = tp->buttons.trackpoint->dispatch; dispatch = tp->buttons.trackpoint->dispatch;
event = *e; event = *e;
syn_report.time = e->time;
switch (event.code) { switch (event.code) {
case BTN_0: case BTN_0:
@ -546,6 +548,9 @@ tp_process_trackpoint_button(struct tp_dispatch *tp,
dispatch->interface->process(dispatch, dispatch->interface->process(dispatch,
tp->buttons.trackpoint, tp->buttons.trackpoint,
&event, time); &event, time);
dispatch->interface->process(dispatch,
tp->buttons.trackpoint,
&syn_report, time);
} }
static void static void