fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2026-01-03 06:50:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: fix --filter-params handling

Browse source 
The previous implementation skipped parameters that were filtered, so
our test cases got called with parameters missing. Fix this by filtering
any test case that has a negative fnmatch on any parameter.

Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1120>
This commit is contained in:
Peter Hutterer 2025-01-08 14:29:07 +10:00 • committed by Marge Bot
parent 11dec0bd9b
commit d9de017d6c
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
test/litest.c
View file

@ -770,10 +770,9 @@ permutation_func(struct litest_parameters_permutation *permutation, void *userda
struct litest_test_parameters *params = litest_test_parameters_new();
struct litest_parameters_permutation_value *pmv;
bool all_filtered = true;
bool filtered = false;
list_for_each(pmv, &permutation->values, link) {
const struct param_filter *f = data->param_filters;
bool filtered = false;
while (!filtered && strlen(f->name)) {
if (streq(pmv->name, f->name)) {
char *s = multivalue_as_str(&pmv->value);
@ -783,18 +782,20 @@ permutation_func(struct litest_parameters_permutation *permutation, void *userda
}
f++;
}
if (!filtered) {
struct litest_test_param *tp = zalloc(sizeof *tp);
snprintf(tp->name, sizeof(tp->name), "%s", pmv->name);
tp->value = multivalue_copy(&pmv->value);
list_append(&params->test_params, &tp->link);
all_filtered = false;
}
if (filtered)
break;
struct litest_test_param *tp = zalloc(sizeof *tp);
snprintf(tp->name, sizeof(tp->name), "%s", pmv->name);
tp->value = multivalue_copy(&pmv->value);
list_append(&params->test_params, &tp->link);
}
if (all_filtered)
if (filtered) {
litest_test_parameters_unref(params);
return 0;
}
struct test *t;