fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-25 19:50:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

touchpad: reduce the initial timeout for tapping after touch

Browse source 
This is the timeout before we decide "this is just a finger down, not a tap".
Until this timeout is hit a finger's movement is filtered. To allow for a more
responsive touchpad, we want that timeout as short as possible.

Event analysis from several users showed that 95% of the touches are less than
100ms long. Reducing the threshold should have almost no impact on most
tapping users but improves the reaction time of the pointer for normal
movements.

For a more details see:
http://who-t.blogspot.com/2016/12/libinput-touchpad-tap-analysis.html

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Peter Hutterer 2016-12-02 11:35:51 +10:00
parent acbbe882a2
commit d0ba1e2b38
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/evdev-mt-touchpad-tap.c
View file

@ -33,6 +33,7 @@
#include "evdev-mt-touchpad.h"
#define DEFAULT_TAP_INITIAL_TIMEOUT_PERIOD ms2us(100)
#define DEFAULT_TAP_TIMEOUT_PERIOD ms2us(180)
#define DEFAULT_DRAG_TIMEOUT_PERIOD ms2us(300)
#define DEFAULT_TAP_MOVE_THRESHOLD TP_MM_TO_DPI_NORMALIZED(3)
@ -126,6 +127,13 @@ tp_tap_notify(struct tp_dispatch *tp,
state);
}
static void
tp_tap_set_initial_timer(struct tp_dispatch *tp, uint64_t time)
{
libinput_timer_set(&tp->tap.timer,
time + DEFAULT_TAP_INITIAL_TIMEOUT_PERIOD);
}
static void
tp_tap_set_timer(struct tp_dispatch *tp, uint64_t time)
{
@ -155,7 +163,7 @@ tp_tap_idle_handle_event(struct tp_dispatch *tp,
case TAP_EVENT_TOUCH:
tp->tap.state = TAP_STATE_TOUCH;
tp->tap.first_press_time = time;
tp_tap_set_timer(tp, time);
tp_tap_set_initial_timer(tp, time);
break;
case TAP_EVENT_RELEASE:
break;