fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2026-02-03 18:10:28 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

quirks: Remove Lenovo Trackpoint Keyboard II quirk

Browse source 
The device sends its own scroll events when its trackpoint is moved
while the middle button is pressed.

Because scroll events are not going to be inhibited after a certain
amount of scroll is detected in a follow up commit, remove the quirk.

This reverts 53bd70f4c7 ("quirks: Lenovo Trackpoint Keyboard II")

Signed-off-by: José Expósito <jose.exposito89@gmail.com>
This commit is contained in:
José Expósito 2021-12-29 18:11:55 +01:00
parent e4548f5805
commit cddf956990
4 changed files with 0 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
quirks/50-system-lenovo.quirks
View file

@ -260,19 +260,6 @@ MatchName=AT Raw Set 2 keyboard
MatchDMIModalias=dmi:*svnLENOVO:*pvrYogaDuet713IML05:*
ModelTabletModeNoSuspend=1
# https://gitlab.freedesktop.org/libinput/libinput/-/issues/651
[Lenovo TrackPoint Keyboard II USB]
MatchBus=usb
MatchVendor=0x17EF
MatchProduct=0x60EE
ModelLenovoTrackpointKeyboard2=1
[Lenovo TrackPoint Keyboard II Bluetooth]
MatchBus=bluetooth
MatchVendor=0x17EF
MatchProduct=0x60E1
ModelLenovoTrackpointKeyboard2=1
# Modifies pressure range to avoid random jumps.
# https://gitlab.freedesktop.org/libinput/libinput/-/issues/407
[Lenovo Yoga 2 Pro touchpad]

9
src/evdev-wheel.c
View file

@ -410,15 +410,6 @@ fallback_wheel_notify_physical_button(struct fallback_dispatch *dispatch,
int button,
enum libinput_button_state state)
{
/* Lenovo TrackPoint Keyboard II sends its own scroll events when its
* trackpoint is moved while the middle button is pressed.
* Do not inhibit the scroll events.
* https://gitlab.freedesktop.org/libinput/libinput/-/issues/651
*/
if (evdev_device_has_model_quirk(device,
QUIRK_MODEL_LENOVO_TRACKPOINT_KEYBOARD_2))
return;
if (button == BTN_MIDDLE) {
if (state == LIBINPUT_BUTTON_STATE_PRESSED)
wheel_handle_event(dispatch, WHEEL_EVENT_PRESS, time);

1
src/quirks.c
View file

@ -254,7 +254,6 @@ quirk_get_name(enum quirk q)
case QUIRK_MODEL_INVERT_HORIZONTAL_SCROLLING: return "ModelInvertHorizontalScrolling";
case QUIRK_MODEL_LENOVO_SCROLLPOINT: return "ModelLenovoScrollPoint";
case QUIRK_MODEL_LENOVO_T450_TOUCHPAD: return "ModelLenovoT450Touchpad";
case QUIRK_MODEL_LENOVO_TRACKPOINT_KEYBOARD_2: return "ModelLenovoTrackpointKeyboard2";
case QUIRK_MODEL_LENOVO_X1GEN6_TOUCHPAD: return "ModelLenovoX1Gen6Touchpad";
case QUIRK_MODEL_LENOVO_X230: return "ModelLenovoX230";
case QUIRK_MODEL_SYNAPTICS_SERIAL_TOUCHPAD: return "ModelSynapticsSerialTouchpad";

1
src/quirks.h
View file

@ -74,7 +74,6 @@ enum quirk {
QUIRK_MODEL_INVERT_HORIZONTAL_SCROLLING,
QUIRK_MODEL_LENOVO_SCROLLPOINT,
QUIRK_MODEL_LENOVO_T450_TOUCHPAD,
QUIRK_MODEL_LENOVO_TRACKPOINT_KEYBOARD_2,
QUIRK_MODEL_LENOVO_X1GEN6_TOUCHPAD,
QUIRK_MODEL_LENOVO_X230,
QUIRK_MODEL_SYNAPTICS_SERIAL_TOUCHPAD,