fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-25 04:40:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

touchpad: add a note to the synaptics touch restore feature

Browse source 
We have code in place to handle the quirky transition from two to three
fingers (where one slot ends and another one starts). We do not handle the
same issue when transitioning from three to two fingers.

This is a note only because it hasn't mattered so far, at least until
eb6ef9fe70 from #408. And it doesn't matter anymore now either
because that code is now only called for ALPS devices.

https://gitlab.freedesktop.org/libinput/libinput/issues/434#note_419912

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer 2020-02-27 14:46:10 +10:00
parent 7b94955634
commit cd574ed5ef
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/evdev-mt-touchpad.c
View file

@ -609,11 +609,14 @@ tp_restore_synaptics_touches(struct tp_dispatch *tp,
(tp->nfingers_down == tp->num_slots && nfake_touches == tp->num_slots))
return;
/* Synaptics devices may end touch 2 on BTN_TOOL_TRIPLETAP
* and start it again on the next frame with different coordinates
* (#91352). We search the touches we have, if there is one that has
* just ended despite us being on tripletap, we move it back to
* update.
/* Synaptics devices may end touch 2 on transition to/fro
* BTN_TOOL_TRIPLETAP and start it again on the next frame with
* different coordinates (bz#91352, gitlab#434). We search the
* touches we have, if there is one that has just ended despite us
* being on tripletap, we move it back to update.
*
* Note: we only handle the transition from 2 to 3 touches, not the
* other way round (see gitlab#434)
*/
for (i = 0; i < tp->num_slots; i++) {
struct tp_touch *t = tp_get_touch(tp, i);