From bfccf5c4053d1d027c875aed3602f5e45a7fe802 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 12 May 2020 13:46:04 +1000 Subject: [PATCH] touchpad: correct a comment regarding the touchpad integration The previous text wasn't accurate enough, USB used to be considered external but we've since started deferring to the hwdb for those (except Apple). Fixes #483 Signed-off-by: Peter Hutterer --- src/evdev-mt-touchpad.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index 38745cdf..42e8dec6 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -2681,10 +2681,15 @@ evdev_tag_touchpad(struct evdev_device *device, } } - /* simple approach: touchpads on USB or Bluetooth are considered - * external, anything else is internal. Exception is Apple - - * internal touchpads are connected over USB and it doesn't have - * external USB touchpads anyway. + /* The hwdb is the authority on integration, these heuristics are + * the fallback only (they precede the hwdb too). + * + * Simple approach: USB is unknown, with the exception + * of Apple where internal touchpads are connected over USB and it + * doesn't have external USB touchpads anyway. + * + * Bluetooth touchpads are considered external, anything else is + * internal. */ bustype = libevdev_get_id_bustype(device->evdev); vendor = libevdev_get_id_vendor(device->evdev);