From bf59231f234bf516d4606795d7b66f0fa370ded4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Exp=C3=B3sito?= Date: Fri, 1 Sep 2023 09:49:31 +0200 Subject: [PATCH] evdev: Fix uninitialized variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Due to a patch pushed accidentally to main, the `key_count` variable is uninitialized in the `evdev_log_bug_libinput` code path: ../src/evdev.c:148:12: error: ‘key_count’ may be used uninitialized [-Werror=maybe-uninitialized] 148 | if (key_count > 32) { | ^ ../src/evdev.c: In function ‘evdev_pointer_post_button’: ../src/evdev.c:132:13: note: ‘key_count’ was declared here 132 | int key_count; | ^~~~~~~~~ Fixes commit bb1e4a493f69 ("evdev: Log bug when releasing key with count 0") Signed-off-by: José Expósito --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index cb49edad..99595967 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -129,7 +129,7 @@ evdev_update_key_down_count(struct evdev_device *device, int code, int pressed) { - int key_count; + int key_count = 0; assert(code >= 0 && code < KEY_CNT); if (pressed) {