From b344e3e56646ecea29f3930d88b57babea358db2 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Fri, 26 Jun 2015 16:18:29 +1000 Subject: [PATCH] touchpad: disable tap drag lock by default Similar to tapping, it's a feature that is useful but confusing if a user doesn't know it exists. It makes the touchpad appear laggy and slow to react in the best case, or appear like a stuck button in the worst case. Signed-off-by: Peter Hutterer Reviewed-by: Hans de Goede --- src/evdev-mt-touchpad-tap.c | 2 +- test/touchpad-tap.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/evdev-mt-touchpad-tap.c b/src/evdev-mt-touchpad-tap.c index 40d431aa..7f241de5 100644 --- a/src/evdev-mt-touchpad-tap.c +++ b/src/evdev-mt-touchpad-tap.c @@ -880,7 +880,7 @@ tp_tap_config_get_draglock_enabled(struct libinput_device *device) static inline enum libinput_config_drag_lock_state tp_drag_lock_default(struct evdev_device *device) { - return LIBINPUT_CONFIG_DRAG_LOCK_ENABLED; + return LIBINPUT_CONFIG_DRAG_LOCK_DISABLED; } static enum libinput_config_drag_lock_state diff --git a/test/touchpad-tap.c b/test/touchpad-tap.c index d04feb45..c021f1dc 100644 --- a/test/touchpad-tap.c +++ b/test/touchpad-tap.c @@ -1699,16 +1699,16 @@ START_TEST(touchpad_tap_invalid) } END_TEST -START_TEST(touchpad_drag_lock_default_enabled) +START_TEST(touchpad_drag_lock_default_disabled) { struct litest_device *dev = litest_current_device(); struct libinput_device *device = dev->libinput_device; enum libinput_config_status status; ck_assert_int_eq(libinput_device_config_tap_get_drag_lock_enabled(device), - LIBINPUT_CONFIG_DRAG_LOCK_ENABLED); + LIBINPUT_CONFIG_DRAG_LOCK_DISABLED); ck_assert_int_eq(libinput_device_config_tap_get_default_drag_lock_enabled(device), - LIBINPUT_CONFIG_DRAG_LOCK_ENABLED); + LIBINPUT_CONFIG_DRAG_LOCK_DISABLED); status = libinput_device_config_tap_set_drag_lock_enabled(device, LIBINPUT_CONFIG_DRAG_LOCK_ENABLED); @@ -1728,7 +1728,7 @@ START_TEST(touchpad_drag_lock_default_enabled) } END_TEST -START_TEST(touchpad_drag_lock_default_disabled) +START_TEST(touchpad_drag_lock_default_unavailable) { struct litest_device *dev = litest_current_device(); struct libinput_device *device = dev->libinput_device; @@ -1809,7 +1809,7 @@ litest_setup_tests(void) litest_add("touchpad:tap", clickpad_1fg_tap_click, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:tap", clickpad_2fg_tap_click, LITEST_CLICKPAD, LITEST_SINGLE_TOUCH|LITEST_APPLE_CLICKPAD); - litest_add("touchpad:tap", touchpad_drag_lock_default_enabled, LITEST_TOUCHPAD, LITEST_ANY); - litest_add("touchpad:tap", touchpad_drag_lock_default_disabled, LITEST_ANY, LITEST_TOUCHPAD); + litest_add("touchpad:tap", touchpad_drag_lock_default_disabled, LITEST_TOUCHPAD, LITEST_ANY); + litest_add("touchpad:tap", touchpad_drag_lock_default_unavailable, LITEST_ANY, LITEST_TOUCHPAD); }