fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-25 10:30:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

quirks: use basename in a POSIX compliant way

Browse source 
The POSIX version of basename modifies the string (and therefore crashes
on static strings), so use safe_strdup before calling it.

glibc provides a POSIX version when libgen.h is included.
FreeBSD 12 provides a POSIX version when nothing is included, which was
causing a segfault.

Using the POSIX version correctly is the right way to avoid any such issues.
This commit is contained in:
Greg V 2018-10-14 15:15:15 +03:00
parent 430ede8266
commit b0cd07bf75
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/quirks.c
View file

@ -34,6 +34,7 @@
#include <libudev.h>
#include <dirent.h>
#include <fnmatch.h>
#include <libgen.h>
#include "libinput-versionsort.h"
#include "libinput-util.h"
@ -413,7 +414,9 @@ section_new(const char *path, const char *name)
{
struct section *s = zalloc(sizeof(*s));
xasprintf(&s->name, "%s (%s)", name, basename(path));
char *path_dup = safe_strdup(path);
xasprintf(&s->name, "%s (%s)", name, basename(path_dup));
free(path_dup);
list_init(&s->link);
list_init(&s->properties);