From a31e4b818c6845b559f01b11e5f3f5ef38b823b3 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Wed, 5 Jul 2017 16:00:57 +1000 Subject: [PATCH] test: remove failing thumb edge scroll test Broken since the merge of palm pressure detection in 25d54b90d, not sure why the test suite succeeded on that one nonetheless. I'm not 100% sure why the test does what it does but it seems to be testing that a wide touch on the side still striggers edge scrolling and not the thumb detection on the bottom of the touchpad. That is obsolete now, it's hard to generically figure out the small gap between thumb and palm pressure, so this test almost always triggers palm detection. It's obsolete. Signed-off-by: Peter Hutterer --- test/test-touchpad.c | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/test/test-touchpad.c b/test/test-touchpad.c index 57f0d60a..1a5b52ac 100644 --- a/test/test-touchpad.c +++ b/test/test-touchpad.c @@ -4220,37 +4220,6 @@ START_TEST(touchpad_thumb_btnarea) } END_TEST -START_TEST(touchpad_thumb_edgescroll) -{ - struct litest_device *dev = litest_current_device(); - struct libinput *li = dev->libinput; - struct axis_replacement axes[] = { - { ABS_MT_PRESSURE, 75 }, - { -1, 0 } - }; - - if (!has_thumb_detect(dev)) - return; - - litest_enable_edge_scroll(dev); - litest_disable_tap(dev->libinput_device); - - litest_drain_events(li); - - litest_touch_down(dev, 0, 99, 30); - litest_touch_move_to(dev, 0, 99, 30, 99, 50, 10, 0); - litest_drain_events(li); - - litest_touch_move_extended(dev, 0, 99, 55, axes); - libinput_dispatch(li); - litest_assert_only_typed_events(li, LIBINPUT_EVENT_POINTER_AXIS); - - litest_touch_move_to(dev, 0, 99, 55, 99, 70, 10, 0); - - litest_assert_only_typed_events(li, LIBINPUT_EVENT_POINTER_AXIS); -} -END_TEST - START_TEST(touchpad_thumb_tap_begin) { struct litest_device *dev = litest_current_device(); @@ -5238,7 +5207,6 @@ litest_setup_tests_touchpad(void) litest_add("touchpad:thumb", touchpad_thumb_moving, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:thumb", touchpad_thumb_clickfinger, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:thumb", touchpad_thumb_btnarea, LITEST_CLICKPAD, LITEST_ANY); - litest_add("touchpad:thumb", touchpad_thumb_edgescroll, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:thumb", touchpad_thumb_tap_begin, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:thumb", touchpad_thumb_tap_touch, LITEST_CLICKPAD, LITEST_ANY); litest_add("touchpad:thumb", touchpad_thumb_tap_hold, LITEST_CLICKPAD, LITEST_ANY);