From a06256d1c3c81a1314516f29d9f732ec4eae195f Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 17 Oct 2017 16:55:27 +1000 Subject: [PATCH] test: unref the litest device *after* removing it from the path interface MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Our own reference may be the last one that's still alive if the context is currently suspended (litest_suspend()). If we unref before removing it from the path interface, we access already freed memory. Signed-off-by: Peter Hutterer Reviewed-by: Jonas Ådahl --- test/litest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/litest.c b/test/litest.c index 4f26771f..d34bd3c5 100644 --- a/test/litest.c +++ b/test/litest.c @@ -1341,8 +1341,8 @@ litest_delete_device(struct litest_device *d) litest_assert_int_eq(d->skip_ev_syn, 0); if (d->libinput_device) { - libinput_device_unref(d->libinput_device); libinput_path_remove_device(d->libinput_device); + libinput_device_unref(d->libinput_device); } if (d->owns_context) libinput_unref(d->libinput);