From 9422d72f97cef778ce464f957c8edd3d53d93d72 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Wed, 22 Mar 2023 16:15:23 +1000 Subject: [PATCH] test: comment two tap tests This is confusing without any explanation - the first set of touches is within the edge zone, the second set of touches is explicitly within the software button area but not inside the edge zone. Let's add comments so the intention is clear. Same-ish for the clickfinger test. Signed-off-by: Peter Hutterer --- test/test-touchpad.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/test-touchpad.c b/test/test-touchpad.c index 7c0587f0..c02cb01c 100644 --- a/test/test-touchpad.c +++ b/test/test-touchpad.c @@ -1602,6 +1602,8 @@ START_TEST(touchpad_palm_detect_tap_softbuttons) litest_disable_hold_gestures(dev->libinput_device); litest_drain_events(li); + /* Two touches in the software button area, but inside + * the palm detection edge zone -> expect palm detection */ litest_touch_down(dev, 0, 99, 99); litest_touch_up(dev, 0); libinput_dispatch(li); @@ -1616,6 +1618,8 @@ START_TEST(touchpad_palm_detect_tap_softbuttons) litest_timeout_tap(); litest_assert_empty_queue(li); + /* Two touches in the software button area, but + * not in the palm detection edge zone -> expect taps */ litest_touch_down(dev, 0, 10, 99); litest_touch_up(dev, 0); libinput_dispatch(li); @@ -1657,6 +1661,8 @@ START_TEST(touchpad_palm_detect_tap_clickfinger) litest_disable_hold_gestures(dev->libinput_device); litest_drain_events(li); + /* Taps in each of the 4 corners of the touchpad, all + * inside the palm detection edge zone*/ litest_touch_down(dev, 0, 95, 5); litest_touch_up(dev, 0); libinput_dispatch(li);