From 8db9d2b927b730b26599b7d42beb854fb77fab32 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Thu, 1 Sep 2016 09:55:32 +1000 Subject: [PATCH] evdev: fix handling of click wheel on parsing errors Introduced in b02acd346b, we need to check the angle returned by the parsing function, not the variable passed in. Found by Coverity Signed-off-by: Peter Hutterer --- src/evdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/evdev.c b/src/evdev.c index 4ec74a54..bc858568 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1831,7 +1831,7 @@ evdev_read_wheel_click_prop(struct evdev_device *device, return false; val = parse_mouse_wheel_click_angle_property(prop); - if (angle) { + if (val) { *angle = val; return true; }