fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2026-01-05 04:20:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

touchpad: increase top software button area to 15%

Browse source 
We had reports that the top software button area is hard to hit for those
using the trackpoint and clicking the buttons with their thumb.

Analysis of event recordings (3 different people) for left, right and middle
clicks shows that there is a significant amount of events up to about 10mm
(with outliers up to 12mm) from the top of the touchpad. That maps to 15%.

Interestingly, the middle button is not affected by this, presumably the
haptic feedback of the little dots sticking out from the surface make hitting
the button easier.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Acked-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Peter Hutterer 2014-08-06 12:22:38 +10:00
parent d1cc84265b
commit 6595036d62
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/evdev-mt-touchpad-buttons.c
View file

@ -542,12 +542,13 @@ tp_init_buttons(struct tp_dispatch *tp,
if (tp->buttons.has_topbuttons) {
/* T440s has the top button line 5mm from the top,
make the buttons 6mm high */
event analysis has shown events to start down to ~10mm
from the top - which maps to 15% */
if (yres > 1) {
tp->buttons.top_area.bottom_edge =
yoffset + 6 * yres;
yoffset + 10 * yres;
} else {
tp->buttons.top_area.bottom_edge = height * .08 + yoffset;
tp->buttons.top_area.bottom_edge = height * .15 + yoffset;
}
tp->buttons.top_area.rightbutton_left_edge = width * .58 + xoffset;
tp->buttons.top_area.leftbutton_right_edge = width * .42 + xoffset;