Fix a few coverity complaints

All minor:
- execdir does not need initialization, it's not used until written to
- 'newest' could be NULL
- zalloc(-1) confuses coverity
- 't' is never used in that test

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit cfd8e6c76c)
This commit is contained in:
Peter Hutterer 2020-11-10 13:09:00 +10:00
parent dc1edd140f
commit 602820f820
3 changed files with 5 additions and 4 deletions

View file

@ -35,7 +35,7 @@
static inline char * static inline char *
builddir_lookup(void) builddir_lookup(void)
{ {
char execdir[PATH_MAX] = {0}; char execdir[PATH_MAX];
char *pathsep; char *pathsep;
ssize_t nread; ssize_t nread;

View file

@ -358,8 +358,9 @@ tp_thumb_update_multifinger(struct tp_dispatch *tp)
* the behavior of the other touches.) * the behavior of the other touches.)
*/ */
if ((newest->initial_time - oldest->initial_time) < THUMB_TIMEOUT && if (newest &&
first->point.y < tp->thumb.lower_thumb_line) { (newest->initial_time - oldest->initial_time) < THUMB_TIMEOUT &&
first->point.y < tp->thumb.lower_thumb_line) {
tp_thumb_lift(tp); tp_thumb_lift(tp);
return; return;
} }

View file

@ -350,7 +350,7 @@ END_TEST
START_TEST(zalloc_overflow) START_TEST(zalloc_overflow)
{ {
zalloc(-1); zalloc((size_t)-1);
} }
END_TEST END_TEST