From 58f4058cf7ff7c226422e5324cf4dd372871aa36 Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Wed, 18 May 2016 12:19:30 +1000 Subject: [PATCH] touchpad: disable cursor jump detection for Wacom tablets We haven't seen jumps on Wacom tablets yet and they cause error messages in most of the tests. litest uses a scaling approach for most events, so a finger move that moves from 30% to 80% of the touchpad with can easily trigger a jump on a Wacom tablet due to its physical size. Rather than having to fix up all tests for the larger size (and potentially cover some other bugs) simply disable this test for Wacom tablets. Signed-off-by: Peter Hutterer Reviewed-by: Hans de Goede --- src/evdev-mt-touchpad.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c index c8540439..b582f651 100644 --- a/src/evdev-mt-touchpad.c +++ b/src/evdev-mt-touchpad.c @@ -913,6 +913,12 @@ tp_detect_jumps(const struct tp_dispatch *tp, struct tp_touch *t) double dx, dy; const int JUMP_THRESHOLD_MM = 20; + /* We haven't seen pointer jumps on Wacom tablets yet, so exclude + * those. + */ + if (tp->device->model_flags & EVDEV_MODEL_WACOM_TOUCHPAD) + return false; + if (t->history.count == 0) return false;