fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-30 15:20:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

lua: add missing lua_pop for the evdev frame

Browse source 
Where a plugin returns a table to be processed we never popped that
table from the stack. Eventually this would lead to the plugin failing
as the stack size is exceeded.

Fixes #1195

Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1323>
This commit is contained in:
Peter Hutterer 2025-10-09 15:11:19 +10:00 • committed by Marge Bot
parent aa7d58005e
commit 3250686e70
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/libinput-plugin-lua.c
View file

@ -226,15 +226,14 @@ lua_pop_evdev_frame(struct libinput_lua_plugin *plugin, struct evdev_frame *fram
lua_State *L = plugin->L; lua_State *L = plugin->L;
if (lua_isnil(L, -1)) { if (lua_isnil(L, -1)) {
lua_pop(L, 1); goto out;
return;
} }
if (!lua_istable(L, -1)) { if (!lua_istable(L, -1)) {
plugin_log_bug(plugin->parent, plugin_log_bug(plugin->parent,
"expected table like `{ events = { ... } }`, got %s", "expected table like `{ events = { ... } }`, got %s",
lua_typename(L, lua_type(L, -1))); lua_typename(L, lua_type(L, -1)));
return; goto out;
} }
struct evdev_event events[64] = { 0 }; struct evdev_event events[64] = { 0 };
@ -249,8 +248,7 @@ lua_pop_evdev_frame(struct libinput_lua_plugin *plugin, struct evdev_frame *fram
plugin->parent, plugin->parent,
"expected table like `{ type = ..., code = ...}`, got %s", "expected table like `{ type = ..., code = ...}`, got %s",
lua_typename(L, lua_type(L, -1))); lua_typename(L, lua_type(L, -1)));
lua_pop(L, 1); goto out;
return;
} }
lua_getfield(L, -1, "usage"); lua_getfield(L, -1, "usage");
@ -282,6 +280,9 @@ lua_pop_evdev_frame(struct libinput_lua_plugin *plugin, struct evdev_frame *fram
if (evdev_frame_set(frame_out, events, nevents) == -ENOMEM) { if (evdev_frame_set(frame_out, events, nevents) == -ENOMEM) {
plugin_log_bug(plugin->parent, "too many events in frame"); plugin_log_bug(plugin->parent, "too many events in frame");
} }
out:
lua_pop(L, 1);
} }
static bool static bool