fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-20 06:50:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: properly batch litest events

Browse source 
If we push/pop event frames and combine various functions we might end
up sending the same value in the same frame multiple times. This
*should* be fine with libinput but is different to what the kernel does
in that case and harder to debug.

Let's batch any litest_event() until an EV_SYN arrives, then write them
all to libinput in one go.

Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1187>
This commit is contained in:
Peter Hutterer 2025-04-09 17:50:42 +10:00 • committed by Marge Bot
parent c96ed7f6b8
commit 265cacb246
2 changed files with 40 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
test/litest.c
View file

@ -2350,16 +2350,45 @@ void
litest_event(struct litest_device *d, unsigned int type,
unsigned int code, int value)
{
int ret;
if (!libevdev_has_event_code(d->evdev, type, code))
return;
if (d->skip_ev_syn && type == EV_SYN && code == SYN_REPORT)
return;
if (type == EV_SYN && code == SYN_REPORT) {
if (d->skip_ev_syn)
return;
ret = libevdev_uinput_write_event(d->uinput, type, code, value);
litest_assert_neg_errno_success(ret);
for (size_t i = 0; i < d->frame.nevents; i++) {
struct input_event *e = &d->frame.events[i];
int ret = libevdev_uinput_write_event(d->uinput, e->type, e->code, e->value);
litest_assert_neg_errno_success(ret);
}
int ret = libevdev_uinput_write_event(d->uinput, EV_SYN, SYN_REPORT, value);
litest_assert_neg_errno_success(ret);
d->frame.nevents = 0;
} else {
size_t i;
if (type == EV_SYN ||
(type == EV_ABS && code >= ABS_MT_SLOT)) {
i = d->frame.nevents;
} else {
for (i = 0; i < d->frame.nevents; i++) {
if (d->frame.events[i].type == type &&
d->frame.events[i].code == code)
break;
}
}
litest_assert_int_lt(i, ARRAY_LENGTH(d->frame.events));
d->frame.events[i] = (struct input_event) {
.type = type,
.code = code,
.value = value,
};
if (i >= d->frame.nevents)
d->frame.nevents++;
}
}
static bool

5
test/litest.h
View file

@ -550,6 +550,11 @@ struct litest_device {
struct libinput_device *libinput_device;
struct litest_device_interface *interface;
struct {
struct input_event events[64];
size_t nevents;
} frame;
int ntouches_down;
int skip_ev_syn;
struct litest_semi_mt semi_mt; /** only used for semi-mt device */