fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2025-12-21 08:30:05 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: fix some tablet tests' unreached code

Browse source 
These conditions were never triggered by our test suite, so let's tighten up
the tests to match what we expect.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer 2017-01-06 12:46:53 +10:00
parent 4d20130e05
commit 1dccc4fdff
1 changed files with 7 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
test/test-tablet.c
View file

@ -700,16 +700,7 @@ START_TEST(proximity_in_out)
ck_assert(have_proximity_out); ck_assert(have_proximity_out);
/* Proximity out must not emit axis events */ /* Proximity out must not emit axis events */
litest_tablet_proximity_out(dev); litest_assert_empty_queue(li);
libinput_dispatch(li);
while ((event = libinput_get_event(li))) {
enum libinput_event_type type = libinput_event_get_type(event);
ck_assert(type != LIBINPUT_EVENT_TABLET_TOOL_AXIS);
libinput_event_destroy(event);
}
} }
END_TEST END_TEST
@ -1601,16 +1592,8 @@ START_TEST(motion_event_state)
libinput_dispatch(li); libinput_dispatch(li);
while ((event = libinput_get_event(li))) { event = libinput_get_event(li);
if (libinput_event_get_type(event) == LIBINPUT_EVENT_TABLET_TOOL_AXIS) tablet_event = litest_is_tablet_event(event, LIBINPUT_EVENT_TABLET_TOOL_AXIS);
break;
libinput_event_destroy(event);
}
/* pop the first event off */
ck_assert_notnull(event);
tablet_event = libinput_event_get_tablet_tool_event(event);
ck_assert_notnull(tablet_event);
last_x = libinput_event_tablet_tool_get_x(tablet_event); last_x = libinput_event_tablet_tool_get_x(tablet_event);
last_y = libinput_event_tablet_tool_get_y(tablet_event); last_y = libinput_event_tablet_tool_get_y(tablet_event);
@ -1886,7 +1869,6 @@ START_TEST(pad_buttons_ignored)
{ {
struct litest_device *dev = litest_current_device(); struct litest_device *dev = litest_current_device();
struct libinput *li = dev->libinput; struct libinput *li = dev->libinput;
struct libinput_event *event;
struct axis_replacement axes[] = { struct axis_replacement axes[] = {
{ ABS_DISTANCE, 10 }, { ABS_DISTANCE, 10 },
{ ABS_PRESSURE, 0 }, { ABS_PRESSURE, 0 },
@ -1904,15 +1886,12 @@ START_TEST(pad_buttons_ignored)
libinput_dispatch(li); libinput_dispatch(li);
} }
while ((event = libinput_get_event(li))) { litest_assert_empty_queue(li);
ck_assert_int_ne(libinput_event_get_type(event),
LIBINPUT_EVENT_TABLET_TOOL_BUTTON);
libinput_event_destroy(event);
libinput_dispatch(li);
}
/* same thing while in prox */ /* same thing while in prox */
litest_tablet_proximity_in(dev, 10, 10, axes); litest_tablet_proximity_in(dev, 10, 10, axes);
litest_drain_events(li);
for (button = BTN_0; button < BTN_MOUSE; button++) { for (button = BTN_0; button < BTN_MOUSE; button++) {
litest_event(dev, EV_KEY, button, 1); litest_event(dev, EV_KEY, button, 1);
litest_event(dev, EV_SYN, SYN_REPORT, 0); litest_event(dev, EV_SYN, SYN_REPORT, 0);
@ -1920,15 +1899,8 @@ START_TEST(pad_buttons_ignored)
litest_event(dev, EV_SYN, SYN_REPORT, 0); litest_event(dev, EV_SYN, SYN_REPORT, 0);
libinput_dispatch(li); libinput_dispatch(li);
} }
litest_tablet_proximity_out(dev);
libinput_dispatch(li); litest_assert_empty_queue(li);
while ((event = libinput_get_event(li))) {
ck_assert_int_ne(libinput_event_get_type(event),
LIBINPUT_EVENT_TABLET_TOOL_BUTTON);
libinput_event_destroy(event);
libinput_dispatch(li);
}
} }
END_TEST END_TEST