fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2026-06-10 00:58:31 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

tools: always open with O_CLOEXEC

Browse source 
Doesn't have any effect but it's easy enough and good practice to do.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1467>
This commit is contained in:
Peter Hutterer 2026-04-17 14:32:10 +10:00 • committed by Marge Bot
parent a5a9d2d8df
commit 0fa334600d
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/libinput-debug-gui.c
View file

@ -1335,7 +1335,7 @@ register_evdev_device(struct window *w, struct libinput_device *dev)
ud = libinput_device_get_udev_device(dev);
device_node = udev_device_get_devnode(ud);
fd = open(device_node, O_RDONLY | O_NONBLOCK);
fd = open(device_node, O_RDONLY | O_NONBLOCK | O_CLOEXEC);
if (fd == -1) {
msg("failed to open %s, evdev events unavailable\n", device_node);
goto out;

2
tools/libinput-debug-tablet-pad.c
View file

@ -258,7 +258,7 @@ handle_device_added(struct context *ctx, struct libinput_event *ev)
devnode = udev_device_get_devnode(udev_device);
if (devnode) {
int fd = open(devnode, O_RDONLY | O_NONBLOCK);
int fd = open(devnode, O_RDONLY | O_NONBLOCK | O_CLOEXEC);
if (fd == -1)
return;
if (libevdev_new_from_fd(fd, &ctx->evdev) != 0) {

2
tools/libinput-debug-tablet.c
View file

@ -276,7 +276,7 @@ handle_device_added(struct context *ctx, struct libinput_event *ev)
devnode = udev_device_get_devnode(udev_device);
if (devnode) {
int fd = open(devnode, O_RDONLY | O_NONBLOCK);
int fd = open(devnode, O_RDONLY | O_NONBLOCK | O_CLOEXEC);
assert(fd != -1);
assert(libevdev_new_from_fd(fd, &ctx->evdev) == 0);
ctx->fds[1].fd = fd;

8
tools/libinput-record.c
View file

@ -1695,7 +1695,7 @@ print_hid_report_descriptor(struct record_device *dev)
if (len <= 0)
return;
fd = open(syspath, O_RDONLY);
fd = open(syspath, O_RDONLY | O_CLOEXEC);
if (fd == -1)
return;
@ -1926,7 +1926,7 @@ select_device(void)
char path[PATH_MAX];
snprintf(path, sizeof(path), "/dev/input/%s", entry->d_name);
_cleanup_(xclose) int fd = open(path, O_RDONLY);
_cleanup_(xclose) int fd = open(path, O_RDONLY | O_CLOEXEC);
if (fd < 0) {
if (errno == EACCES)
has_eaccess = true;
@ -2395,7 +2395,7 @@ init_device(struct record_context *ctx, const char *path, bool grab)
list_init(&d->hidraw_devices);
_cleanup_(xclose) int fd = open(d->devnode, O_RDONLY | O_NONBLOCK);
_cleanup_(xclose) int fd = open(d->devnode, O_RDONLY | O_NONBLOCK | O_CLOEXEC);
if (fd < 0) {
fprintf(stderr, "Failed to open device %s (%m)\n", d->devnode);
return false;
@ -2514,7 +2514,7 @@ init_hidraw(struct record_context *ctx)
sizeof(hidraw_node),
"/dev/%s",
entry->d_name);
fd = open(hidraw_node, O_RDONLY | O_NONBLOCK);
fd = open(hidraw_node, O_RDONLY | O_NONBLOCK | O_CLOEXEC);
if (fd == -1)
continue;