fdo-mirrors/libinput
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libinput.git synced 2026-01-04 12:00:13 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

tools: fix grab argument passing for libinput debug-events

Browse source 
The &grab pointer we used to pass as userdata was the address of the function
argument which goes out of scope at the end of the function. This works fine
for devices immediately opened but when a device connects later, the address
may have been re-used since and it's content is undefined. If not NULL, we
end up grabbing the device.

Instead pass the grab option in which is guaranteed to live until the end of
main.

https://gitlab.freedesktop.org/libinput/libinput/issues/26

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
This commit is contained in:
Peter Hutterer 2018-06-13 13:38:09 +10:00
parent 50ca923c5f
commit 0a13223c39
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/libinput-debug-events.c
View file

@ -991,7 +991,7 @@ main(int argc, char **argv)
return 1;
}
li = tools_open_backend(backend, seat_or_device, verbose, grab);
li = tools_open_backend(backend, seat_or_device, verbose, &grab);
if (!li)
return 1;

2
tools/libinput-debug-gui.c
View file

@ -958,7 +958,7 @@ main(int argc, char **argv)
return 1;
}
li = tools_open_backend(backend, seat_or_device, verbose, grab);
li = tools_open_backend(backend, seat_or_device, verbose, &grab);
if (!li)
return 1;

10
tools/shared.c
View file

@ -251,7 +251,7 @@ static const struct libinput_interface interface = {
};
static struct libinput *
tools_open_udev(const char *seat, bool verbose, bool grab)
tools_open_udev(const char *seat, bool verbose, bool *grab)
{
struct libinput *li;
struct udev *udev = udev_new();
@ -261,7 +261,7 @@ tools_open_udev(const char *seat, bool verbose, bool grab)
return NULL;
}
li = libinput_udev_create_context(&interface, &grab, udev);
li = libinput_udev_create_context(&interface, grab, udev);
if (!li) {
fprintf(stderr, "Failed to initialize context from udev\n");
goto out;
@ -285,12 +285,12 @@ out:
}
static struct libinput *
tools_open_device(const char *path, bool verbose, bool grab)
tools_open_device(const char *path, bool verbose, bool *grab)
{
struct libinput_device *device;
struct libinput *li;
li = libinput_path_create_context(&interface, &grab);
li = libinput_path_create_context(&interface, grab);
if (!li) {
fprintf(stderr, "Failed to initialize context from %s\n", path);
return NULL;
@ -315,7 +315,7 @@ struct libinput *
tools_open_backend(enum tools_backend which,
const char *seat_or_device,
bool verbose,
bool grab)
bool *grab)
{
struct libinput *li;

2
tools/shared.h
View file

@ -104,7 +104,7 @@ int tools_parse_option(int option,
struct libinput* tools_open_backend(enum tools_backend which,
const char *seat_or_device,
bool verbose,
bool grab);
bool *grab);
void tools_device_apply_config(struct libinput_device *device,
struct tools_options *options);
int tools_exec_command(const char *prefix, int argc, char **argv);