2014-01-21 14:17:01 +10:00
|
|
|
/*
|
|
|
|
|
* Copyright © 2013 Red Hat, Inc.
|
|
|
|
|
*
|
|
|
|
|
* Permission to use, copy, modify, distribute, and sell this software and
|
|
|
|
|
* its documentation for any purpose is hereby granted without fee, provided
|
|
|
|
|
* that the above copyright notice appear in all copies and that both that
|
|
|
|
|
* copyright notice and this permission notice appear in supporting
|
|
|
|
|
* documentation, and that the name of the copyright holders not be used in
|
|
|
|
|
* advertising or publicity pertaining to distribution of the software
|
|
|
|
|
* without specific, written prior permission. The copyright holders make
|
|
|
|
|
* no representations about the suitability of this software for any
|
|
|
|
|
* purpose. It is provided "as is" without express or implied warranty.
|
|
|
|
|
*
|
|
|
|
|
* THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS
|
|
|
|
|
* SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND
|
|
|
|
|
* FITNESS, IN NO EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY
|
|
|
|
|
* SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER
|
|
|
|
|
* RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF
|
|
|
|
|
* CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN
|
|
|
|
|
* CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
|
2014-04-01 22:24:10 +02:00
|
|
|
#include <stdio.h>
|
2014-01-21 14:17:01 +10:00
|
|
|
#include <check.h>
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <fcntl.h>
|
|
|
|
|
#include <libinput.h>
|
2014-05-26 22:12:25 +02:00
|
|
|
#include <math.h>
|
2014-01-21 14:17:01 +10:00
|
|
|
#include <unistd.h>
|
2014-12-04 11:44:09 +08:00
|
|
|
#include <values.h>
|
2014-01-21 14:17:01 +10:00
|
|
|
|
|
|
|
|
#include "libinput-util.h"
|
|
|
|
|
#include "litest.h"
|
|
|
|
|
|
2014-12-04 11:44:09 +08:00
|
|
|
static struct libinput_event_pointer *
|
|
|
|
|
get_accelerated_motion_event(struct libinput *li)
|
|
|
|
|
{
|
|
|
|
|
struct libinput_event *event;
|
|
|
|
|
struct libinput_event_pointer *ptrev;
|
|
|
|
|
|
|
|
|
|
while (1) {
|
|
|
|
|
event = libinput_get_event(li);
|
|
|
|
|
ck_assert_notnull(event);
|
|
|
|
|
ck_assert_int_eq(libinput_event_get_type(event),
|
|
|
|
|
LIBINPUT_EVENT_POINTER_MOTION);
|
|
|
|
|
|
|
|
|
|
ptrev = libinput_event_get_pointer_event(event);
|
|
|
|
|
ck_assert_notnull(ptrev);
|
|
|
|
|
|
|
|
|
|
if (fabs(libinput_event_pointer_get_dx(ptrev)) < DBL_MIN &&
|
|
|
|
|
fabs(libinput_event_pointer_get_dy(ptrev)) < DBL_MIN) {
|
|
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return ptrev;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ck_abort_msg("No accelerated pointer motion event found");
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
static void
|
|
|
|
|
test_relative_event(struct litest_device *dev, int dx, int dy)
|
|
|
|
|
{
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
struct libinput_event_pointer *ptrev;
|
2014-05-26 22:12:25 +02:00
|
|
|
double ev_dx, ev_dy;
|
|
|
|
|
double expected_dir;
|
|
|
|
|
double expected_length;
|
|
|
|
|
double actual_dir;
|
|
|
|
|
double actual_length;
|
2014-01-21 14:17:01 +10:00
|
|
|
|
2014-05-26 22:12:25 +02:00
|
|
|
/* Send two deltas, as the first one may be eaten up by an
|
|
|
|
|
* acceleration filter. */
|
|
|
|
|
litest_event(dev, EV_REL, REL_X, dx);
|
|
|
|
|
litest_event(dev, EV_REL, REL_Y, dy);
|
|
|
|
|
litest_event(dev, EV_SYN, SYN_REPORT, 0);
|
2014-01-21 14:17:01 +10:00
|
|
|
litest_event(dev, EV_REL, REL_X, dx);
|
|
|
|
|
litest_event(dev, EV_REL, REL_Y, dy);
|
|
|
|
|
litest_event(dev, EV_SYN, SYN_REPORT, 0);
|
|
|
|
|
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
2014-12-04 11:44:09 +08:00
|
|
|
ptrev = get_accelerated_motion_event(li);
|
2014-05-26 22:12:25 +02:00
|
|
|
|
2014-07-08 08:52:40 +10:00
|
|
|
expected_length = sqrt(4 * dx*dx + 4 * dy*dy);
|
2014-05-26 22:12:25 +02:00
|
|
|
expected_dir = atan2(dx, dy);
|
|
|
|
|
|
2014-06-02 23:09:27 +02:00
|
|
|
ev_dx = libinput_event_pointer_get_dx(ptrev);
|
|
|
|
|
ev_dy = libinput_event_pointer_get_dy(ptrev);
|
2014-05-26 22:12:25 +02:00
|
|
|
actual_length = sqrt(ev_dx*ev_dx + ev_dy*ev_dy);
|
|
|
|
|
actual_dir = atan2(ev_dx, ev_dy);
|
|
|
|
|
|
|
|
|
|
/* Check the length of the motion vector (tolerate 1.0 indifference). */
|
2014-07-08 08:52:40 +10:00
|
|
|
ck_assert(fabs(expected_length) >= actual_length);
|
2014-05-26 22:12:25 +02:00
|
|
|
|
|
|
|
|
/* Check the direction of the motion vector (tolerate 2π/4 radians
|
|
|
|
|
* indifference). */
|
|
|
|
|
ck_assert(fabs(expected_dir - actual_dir) < M_PI_2);
|
2014-01-21 14:17:01 +10:00
|
|
|
|
2014-12-04 11:44:09 +08:00
|
|
|
libinput_event_destroy(libinput_event_pointer_get_base_event(ptrev));
|
2014-05-26 22:12:25 +02:00
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
2014-01-21 14:17:01 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_motion_relative)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
test_relative_event(dev, 1, 0);
|
|
|
|
|
test_relative_event(dev, 1, 1);
|
|
|
|
|
test_relative_event(dev, 1, -1);
|
|
|
|
|
test_relative_event(dev, 0, 1);
|
|
|
|
|
|
|
|
|
|
test_relative_event(dev, -1, 0);
|
|
|
|
|
test_relative_event(dev, -1, 1);
|
|
|
|
|
test_relative_event(dev, -1, -1);
|
|
|
|
|
test_relative_event(dev, 0, -1);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-10-29 11:58:09 +10:00
|
|
|
static void
|
|
|
|
|
test_absolute_event(struct litest_device *dev, double x, double y)
|
|
|
|
|
{
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
struct libinput_event *event;
|
|
|
|
|
struct libinput_event_pointer *ptrev;
|
|
|
|
|
double ex, ey;
|
|
|
|
|
|
|
|
|
|
litest_touch_down(dev, 0, x, y);
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
|
|
|
|
event = libinput_get_event(li);
|
|
|
|
|
ck_assert_int_eq(libinput_event_get_type(event),
|
|
|
|
|
LIBINPUT_EVENT_POINTER_MOTION_ABSOLUTE);
|
|
|
|
|
|
|
|
|
|
ptrev = libinput_event_get_pointer_event(event);
|
|
|
|
|
ck_assert(ptrev != NULL);
|
|
|
|
|
|
|
|
|
|
ex = libinput_event_pointer_get_absolute_x_transformed(ptrev, 100);
|
|
|
|
|
ey = libinput_event_pointer_get_absolute_y_transformed(ptrev, 100);
|
|
|
|
|
ck_assert_int_eq(ex + 0.5, x);
|
|
|
|
|
ck_assert_int_eq(ey + 0.5, y);
|
|
|
|
|
|
|
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_motion_absolute)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
test_absolute_event(dev, 0, 100);
|
|
|
|
|
test_absolute_event(dev, 100, 0);
|
|
|
|
|
test_absolute_event(dev, 50, 50);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-12-04 11:44:09 +08:00
|
|
|
static void
|
|
|
|
|
test_unaccel_event(struct litest_device *dev, int dx, int dy)
|
|
|
|
|
{
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
struct libinput_event *event;
|
|
|
|
|
struct libinput_event_pointer *ptrev;
|
|
|
|
|
double ev_dx, ev_dy;
|
|
|
|
|
|
|
|
|
|
litest_event(dev, EV_REL, REL_X, dx);
|
|
|
|
|
litest_event(dev, EV_REL, REL_Y, dy);
|
|
|
|
|
litest_event(dev, EV_SYN, SYN_REPORT, 0);
|
|
|
|
|
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
|
|
|
|
event = libinput_get_event(li);
|
|
|
|
|
ck_assert_notnull(event);
|
|
|
|
|
ck_assert_int_eq(libinput_event_get_type(event),
|
|
|
|
|
LIBINPUT_EVENT_POINTER_MOTION);
|
|
|
|
|
|
|
|
|
|
ptrev = libinput_event_get_pointer_event(event);
|
|
|
|
|
ck_assert(ptrev != NULL);
|
|
|
|
|
|
|
|
|
|
ev_dx = libinput_event_pointer_get_dx_unaccelerated(ptrev);
|
|
|
|
|
ev_dy = libinput_event_pointer_get_dy_unaccelerated(ptrev);
|
|
|
|
|
|
|
|
|
|
ck_assert_int_eq(dx, ev_dx);
|
|
|
|
|
ck_assert_int_eq(dy, ev_dy);
|
|
|
|
|
|
|
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_motion_unaccel)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
test_unaccel_event(dev, 10, 0);
|
|
|
|
|
test_unaccel_event(dev, 10, 10);
|
|
|
|
|
test_unaccel_event(dev, 10, -10);
|
|
|
|
|
test_unaccel_event(dev, 0, 10);
|
|
|
|
|
|
|
|
|
|
test_unaccel_event(dev, -10, 0);
|
|
|
|
|
test_unaccel_event(dev, -10, 10);
|
|
|
|
|
test_unaccel_event(dev, -10, -10);
|
|
|
|
|
test_unaccel_event(dev, 0, -10);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
static void
|
2014-07-03 11:00:54 +10:00
|
|
|
test_button_event(struct litest_device *dev, unsigned int button, int state)
|
2014-01-21 14:17:01 +10:00
|
|
|
{
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
|
|
|
|
|
litest_event(dev, EV_KEY, button, state);
|
|
|
|
|
litest_event(dev, EV_SYN, SYN_REPORT, 0);
|
|
|
|
|
|
2014-09-03 10:53:00 +10:00
|
|
|
litest_assert_button_event(li, button,
|
|
|
|
|
state ? LIBINPUT_BUTTON_STATE_PRESSED :
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
2014-01-21 14:17:01 +10:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_button)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
test_button_event(dev, BTN_LEFT, 1);
|
|
|
|
|
test_button_event(dev, BTN_LEFT, 0);
|
|
|
|
|
|
|
|
|
|
/* press it twice for good measure */
|
|
|
|
|
test_button_event(dev, BTN_LEFT, 1);
|
|
|
|
|
test_button_event(dev, BTN_LEFT, 0);
|
|
|
|
|
|
|
|
|
|
if (libevdev_has_event_code(dev->evdev, EV_KEY, BTN_RIGHT)) {
|
|
|
|
|
test_button_event(dev, BTN_RIGHT, 1);
|
|
|
|
|
test_button_event(dev, BTN_RIGHT, 0);
|
|
|
|
|
}
|
|
|
|
|
|
2014-09-16 16:22:36 +02:00
|
|
|
/* Skip middle button test on trackpoints (used for scrolling) */
|
|
|
|
|
if (!libevdev_has_property(dev->evdev, INPUT_PROP_POINTING_STICK) &&
|
|
|
|
|
libevdev_has_event_code(dev->evdev, EV_KEY, BTN_MIDDLE)) {
|
2014-01-21 14:17:01 +10:00
|
|
|
test_button_event(dev, BTN_MIDDLE, 1);
|
|
|
|
|
test_button_event(dev, BTN_MIDDLE, 0);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-07-27 16:02:46 +02:00
|
|
|
START_TEST(pointer_button_auto_release)
|
|
|
|
|
{
|
|
|
|
|
struct libinput *libinput;
|
|
|
|
|
struct litest_device *dev;
|
|
|
|
|
struct libinput_event *event;
|
|
|
|
|
enum libinput_event_type type;
|
|
|
|
|
struct libinput_event_pointer *pevent;
|
|
|
|
|
struct {
|
|
|
|
|
int code;
|
|
|
|
|
int released;
|
|
|
|
|
} buttons[] = {
|
|
|
|
|
{ .code = BTN_LEFT, },
|
|
|
|
|
{ .code = BTN_MIDDLE, },
|
|
|
|
|
{ .code = BTN_EXTRA, },
|
|
|
|
|
{ .code = BTN_SIDE, },
|
|
|
|
|
{ .code = BTN_BACK, },
|
|
|
|
|
{ .code = BTN_FORWARD, },
|
|
|
|
|
{ .code = BTN_4, },
|
|
|
|
|
};
|
|
|
|
|
int events[2 * (ARRAY_LENGTH(buttons) + 1)];
|
|
|
|
|
unsigned i;
|
|
|
|
|
int button;
|
|
|
|
|
int valid_code;
|
|
|
|
|
|
|
|
|
|
/* Enable all tested buttons on the device */
|
|
|
|
|
for (i = 0; i < 2 * ARRAY_LENGTH(buttons);) {
|
|
|
|
|
button = buttons[i / 2].code;
|
|
|
|
|
events[i++] = EV_KEY;
|
|
|
|
|
events[i++] = button;
|
|
|
|
|
}
|
|
|
|
|
events[i++] = -1;
|
|
|
|
|
events[i++] = -1;
|
|
|
|
|
|
|
|
|
|
libinput = litest_create_context();
|
|
|
|
|
dev = litest_add_device_with_overrides(libinput,
|
|
|
|
|
LITEST_MOUSE,
|
|
|
|
|
"Generic mouse",
|
|
|
|
|
NULL, NULL, events);
|
|
|
|
|
|
|
|
|
|
litest_drain_events(libinput);
|
|
|
|
|
|
|
|
|
|
/* Send pressed events, without releasing */
|
|
|
|
|
for (i = 0; i < ARRAY_LENGTH(buttons); ++i) {
|
|
|
|
|
test_button_event(dev, buttons[i].code, 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
litest_drain_events(libinput);
|
|
|
|
|
|
|
|
|
|
/* "Disconnect" device */
|
|
|
|
|
litest_delete_device(dev);
|
|
|
|
|
|
|
|
|
|
/* Mark all released buttons until device is removed */
|
|
|
|
|
while (1) {
|
|
|
|
|
event = libinput_get_event(libinput);
|
|
|
|
|
ck_assert_notnull(event);
|
|
|
|
|
type = libinput_event_get_type(event);
|
|
|
|
|
|
|
|
|
|
if (type == LIBINPUT_EVENT_DEVICE_REMOVED) {
|
|
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ck_assert_int_eq(type, LIBINPUT_EVENT_POINTER_BUTTON);
|
|
|
|
|
pevent = libinput_event_get_pointer_event(event);
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_button_state(pevent),
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
button = libinput_event_pointer_get_button(pevent);
|
|
|
|
|
|
|
|
|
|
valid_code = 0;
|
|
|
|
|
for (i = 0; i < ARRAY_LENGTH(buttons); ++i) {
|
|
|
|
|
if (buttons[i].code == button) {
|
|
|
|
|
ck_assert_int_eq(buttons[i].released, 0);
|
|
|
|
|
buttons[i].released = 1;
|
|
|
|
|
valid_code = 1;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
ck_assert_int_eq(valid_code, 1);
|
|
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Check that all pressed buttons has been released. */
|
|
|
|
|
for (i = 0; i < ARRAY_LENGTH(buttons); ++i) {
|
|
|
|
|
ck_assert_int_eq(buttons[i].released, 1);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
libinput_unref(libinput);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
static void
|
|
|
|
|
test_wheel_event(struct litest_device *dev, int which, int amount)
|
|
|
|
|
{
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
struct libinput_event *event;
|
|
|
|
|
struct libinput_event_pointer *ptrev;
|
2014-12-24 11:10:04 +10:00
|
|
|
enum libinput_pointer_axis axis;
|
2014-01-21 14:17:01 +10:00
|
|
|
|
|
|
|
|
/* the current evdev implementation scales the scroll wheel events
|
2015-01-09 17:03:45 +10:00
|
|
|
up by a factor 15 */
|
|
|
|
|
const int scroll_step = 15;
|
2014-01-21 14:17:01 +10:00
|
|
|
int expected = amount * scroll_step;
|
2015-01-13 15:15:02 +10:00
|
|
|
int discrete = amount;
|
2014-01-21 14:17:01 +10:00
|
|
|
|
2015-01-13 15:15:02 +10:00
|
|
|
if (libinput_device_config_scroll_get_natural_scroll_enabled(dev->libinput_device)) {
|
2014-11-18 12:03:48 +10:00
|
|
|
expected *= -1;
|
2015-01-13 15:15:02 +10:00
|
|
|
discrete *= -1;
|
|
|
|
|
}
|
2014-11-18 12:03:48 +10:00
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
/* mouse scroll wheels are 'upside down' */
|
|
|
|
|
if (which == REL_WHEEL)
|
|
|
|
|
amount *= -1;
|
|
|
|
|
litest_event(dev, EV_REL, which, amount);
|
|
|
|
|
litest_event(dev, EV_SYN, SYN_REPORT, 0);
|
|
|
|
|
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
|
|
|
|
event = libinput_get_event(li);
|
|
|
|
|
ck_assert(event != NULL);
|
|
|
|
|
ck_assert_int_eq(libinput_event_get_type(event),
|
|
|
|
|
LIBINPUT_EVENT_POINTER_AXIS);
|
|
|
|
|
|
|
|
|
|
ptrev = libinput_event_get_pointer_event(event);
|
|
|
|
|
ck_assert(ptrev != NULL);
|
2014-12-24 11:10:04 +10:00
|
|
|
|
|
|
|
|
axis = (which == REL_WHEEL) ?
|
2014-04-26 20:01:22 +10:00
|
|
|
LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL :
|
2014-12-24 11:10:04 +10:00
|
|
|
LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL;
|
|
|
|
|
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_axis_value(ptrev, axis),
|
|
|
|
|
expected);
|
Add pointer axis sources to the API
For a caller to implement/provide kinetic scrolling ("inertial scrolling",
"fling scrolling"), it needs to know how the scrolling motion was implemented,
and what to expect in the future. Add this information to the pointer axis
event.
The three scroll sources we have are:
* wheels: scrolling is in discreet steps, you don't know when it ends, the
wheel will just stop sending events
* fingers: scrolling is continuous coordinate space, we know when it stops and
we can tell the caller
* continuous: scrolling is in continuous coordinate space but we may or may not
know when it stops. if scroll lock is used, the device may never technically
get out of scroll mode even if it doesn't send events at any given moment
Use case: trackpoint/trackball scroll emulation on button press
The stop event is now codified in the API documentation, so callers can use
that for kinetic scrolling. libinput does not implement kinetic scrolling
itself.
Not covered by this patch:
* The wheel event is currently defined as "typical mouse wheel step", this is
different to Qt where the step value is 1/8 of a degree. Some better
definition here may help.
* It is unclear how an absolute device would map into relative motion if the
device itself is not controlling absolute motion.
* For diagonal scrolling, the vertical/horizontal terminator events would come
in separately. The caller would have to deal with that somehow.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Original patch, before the rebase onto today's master:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
2014-11-05 16:22:07 +10:00
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_axis_source(ptrev),
|
|
|
|
|
LIBINPUT_POINTER_AXIS_SOURCE_WHEEL);
|
2015-01-15 09:48:29 +10:00
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_axis_value_discrete(ptrev, axis),
|
2015-01-13 15:15:02 +10:00
|
|
|
discrete);
|
2014-01-21 14:17:01 +10:00
|
|
|
libinput_event_destroy(event);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_scroll_wheel)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, -1);
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, 1);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, -5);
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, 6);
|
|
|
|
|
|
|
|
|
|
if (libevdev_has_event_code(dev->evdev, EV_REL, REL_HWHEEL)) {
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, -1);
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, 1);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, -5);
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, 6);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-11-18 12:03:48 +10:00
|
|
|
START_TEST(pointer_scroll_natural_defaults)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
|
|
|
|
|
ck_assert_int_ge(libinput_device_config_scroll_has_natural_scroll(dev->libinput_device), 1);
|
|
|
|
|
ck_assert_int_eq(libinput_device_config_scroll_get_natural_scroll_enabled(dev->libinput_device), 0);
|
|
|
|
|
ck_assert_int_eq(libinput_device_config_scroll_get_default_natural_scroll_enabled(dev->libinput_device), 0);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_scroll_natural_enable_config)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
|
|
|
|
|
status = libinput_device_config_scroll_set_natural_scroll_enabled(dev->libinput_device, 1);
|
|
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
ck_assert_int_eq(libinput_device_config_scroll_get_natural_scroll_enabled(dev->libinput_device), 1);
|
|
|
|
|
|
|
|
|
|
status = libinput_device_config_scroll_set_natural_scroll_enabled(dev->libinput_device, 0);
|
|
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
ck_assert_int_eq(libinput_device_config_scroll_get_natural_scroll_enabled(dev->libinput_device), 0);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_scroll_natural_wheel)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *device = dev->libinput_device;
|
|
|
|
|
|
|
|
|
|
litest_drain_events(dev->libinput);
|
|
|
|
|
|
|
|
|
|
libinput_device_config_scroll_set_natural_scroll_enabled(device, 1);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, -1);
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, 1);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, -5);
|
|
|
|
|
test_wheel_event(dev, REL_WHEEL, 6);
|
|
|
|
|
|
|
|
|
|
if (libevdev_has_event_code(dev->evdev, EV_REL, REL_HWHEEL)) {
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, -1);
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, 1);
|
|
|
|
|
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, -5);
|
|
|
|
|
test_wheel_event(dev, REL_HWHEEL, 6);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-04-01 22:24:10 +02:00
|
|
|
START_TEST(pointer_seat_button_count)
|
|
|
|
|
{
|
|
|
|
|
const int num_devices = 4;
|
|
|
|
|
struct litest_device *devices[num_devices];
|
|
|
|
|
struct libinput *libinput;
|
|
|
|
|
struct libinput_event *ev;
|
|
|
|
|
struct libinput_event_pointer *tev;
|
|
|
|
|
int i;
|
|
|
|
|
int seat_button_count;
|
|
|
|
|
int expected_seat_button_count = 0;
|
|
|
|
|
char device_name[255];
|
|
|
|
|
|
|
|
|
|
libinput = litest_create_context();
|
|
|
|
|
for (i = 0; i < num_devices; ++i) {
|
2014-07-04 07:55:51 +10:00
|
|
|
sprintf(device_name, "litest Generic mouse (%d)", i);
|
2014-04-01 22:24:10 +02:00
|
|
|
devices[i] = litest_add_device_with_overrides(libinput,
|
|
|
|
|
LITEST_MOUSE,
|
|
|
|
|
device_name,
|
|
|
|
|
NULL, NULL, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < num_devices; ++i)
|
|
|
|
|
litest_button_click(devices[i], BTN_LEFT, true);
|
|
|
|
|
|
|
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
while ((ev = libinput_get_event(libinput))) {
|
|
|
|
|
if (libinput_event_get_type(ev) !=
|
|
|
|
|
LIBINPUT_EVENT_POINTER_BUTTON) {
|
2014-04-23 11:04:48 +10:00
|
|
|
libinput_event_destroy(ev);
|
2014-04-01 22:24:10 +02:00
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
tev = libinput_event_get_pointer_event(ev);
|
|
|
|
|
ck_assert_notnull(tev);
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_button(tev),
|
|
|
|
|
BTN_LEFT);
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_button_state(tev),
|
2014-06-03 20:08:02 -04:00
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
2014-04-01 22:24:10 +02:00
|
|
|
|
|
|
|
|
++expected_seat_button_count;
|
|
|
|
|
seat_button_count =
|
|
|
|
|
libinput_event_pointer_get_seat_button_count(tev);
|
|
|
|
|
ck_assert_int_eq(expected_seat_button_count, seat_button_count);
|
|
|
|
|
|
2014-04-23 11:04:48 +10:00
|
|
|
libinput_event_destroy(ev);
|
2014-04-01 22:24:10 +02:00
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ck_assert_int_eq(seat_button_count, num_devices);
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < num_devices; ++i)
|
|
|
|
|
litest_button_click(devices[i], BTN_LEFT, false);
|
|
|
|
|
|
|
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
while ((ev = libinput_get_event(libinput))) {
|
|
|
|
|
if (libinput_event_get_type(ev) !=
|
|
|
|
|
LIBINPUT_EVENT_POINTER_BUTTON) {
|
2014-04-23 11:04:48 +10:00
|
|
|
libinput_event_destroy(ev);
|
2014-04-01 22:24:10 +02:00
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
tev = libinput_event_get_pointer_event(ev);
|
|
|
|
|
ck_assert_notnull(tev);
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_button(tev),
|
|
|
|
|
BTN_LEFT);
|
|
|
|
|
ck_assert_int_eq(libinput_event_pointer_get_button_state(tev),
|
2014-06-03 20:08:02 -04:00
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
2014-04-01 22:24:10 +02:00
|
|
|
|
|
|
|
|
--expected_seat_button_count;
|
|
|
|
|
seat_button_count =
|
|
|
|
|
libinput_event_pointer_get_seat_button_count(tev);
|
|
|
|
|
ck_assert_int_eq(expected_seat_button_count, seat_button_count);
|
|
|
|
|
|
2014-04-23 11:04:48 +10:00
|
|
|
libinput_event_destroy(ev);
|
2014-04-01 22:24:10 +02:00
|
|
|
libinput_dispatch(libinput);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ck_assert_int_eq(seat_button_count, 0);
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < num_devices; ++i)
|
|
|
|
|
litest_delete_device(devices[i]);
|
2014-06-25 00:06:58 +02:00
|
|
|
libinput_unref(libinput);
|
2014-04-01 22:24:10 +02:00
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-08-26 11:41:19 +10:00
|
|
|
START_TEST(pointer_no_calibration)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *d = dev->libinput_device;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
int rc;
|
|
|
|
|
float calibration[6] = {0};
|
|
|
|
|
|
|
|
|
|
rc = libinput_device_config_calibration_has_matrix(d);
|
|
|
|
|
ck_assert_int_eq(rc, 0);
|
|
|
|
|
rc = libinput_device_config_calibration_get_matrix(d, calibration);
|
|
|
|
|
ck_assert_int_eq(rc, 0);
|
|
|
|
|
rc = libinput_device_config_calibration_get_default_matrix(d,
|
|
|
|
|
calibration);
|
|
|
|
|
ck_assert_int_eq(rc, 0);
|
|
|
|
|
|
|
|
|
|
status = libinput_device_config_calibration_set_matrix(d,
|
|
|
|
|
calibration);
|
|
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_UNSUPPORTED);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-09-23 12:46:02 +10:00
|
|
|
START_TEST(pointer_left_handed_defaults)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *d = dev->libinput_device;
|
|
|
|
|
int rc;
|
|
|
|
|
|
2015-01-06 21:20:22 -05:00
|
|
|
rc = libinput_device_config_left_handed_is_available(d);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_ne(rc, 0);
|
|
|
|
|
|
2015-01-06 21:20:22 -05:00
|
|
|
rc = libinput_device_config_left_handed_get(d);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_eq(rc, 0);
|
|
|
|
|
|
2015-01-06 21:20:22 -05:00
|
|
|
rc = libinput_device_config_left_handed_get_default(d);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_eq(rc, 0);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_left_handed)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *d = dev->libinput_device;
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
|
2015-01-06 21:20:22 -05:00
|
|
|
status = libinput_device_config_left_handed_set(d, 1);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
|
|
|
|
|
litest_drain_events(li);
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 1);
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 0);
|
|
|
|
|
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_RIGHT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_RIGHT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
|
|
|
|
|
litest_button_click(dev, BTN_RIGHT, 1);
|
|
|
|
|
litest_button_click(dev, BTN_RIGHT, 0);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
|
|
|
|
|
if (libevdev_has_event_code(dev->evdev,
|
|
|
|
|
EV_KEY,
|
|
|
|
|
BTN_MIDDLE)) {
|
|
|
|
|
litest_button_click(dev, BTN_MIDDLE, 1);
|
|
|
|
|
litest_button_click(dev, BTN_MIDDLE, 0);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_MIDDLE,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_MIDDLE,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_left_handed_during_click)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *d = dev->libinput_device;
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
|
|
|
|
|
litest_drain_events(li);
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 1);
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
|
|
|
|
/* Change while button is down, expect correct release event */
|
2015-01-06 21:20:22 -05:00
|
|
|
status = libinput_device_config_left_handed_set(d, 1);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 0);
|
|
|
|
|
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
|
|
|
|
START_TEST(pointer_left_handed_during_click_multiple_buttons)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *d = dev->libinput_device;
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
|
|
|
|
|
litest_drain_events(li);
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 1);
|
|
|
|
|
libinput_dispatch(li);
|
|
|
|
|
|
2015-01-06 21:20:22 -05:00
|
|
|
status = libinput_device_config_left_handed_set(d, 1);
|
2014-09-23 12:46:02 +10:00
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
|
|
|
|
|
/* No left-handed until all buttons were down */
|
|
|
|
|
litest_button_click(dev, BTN_RIGHT, 1);
|
|
|
|
|
litest_button_click(dev, BTN_RIGHT, 0);
|
|
|
|
|
litest_button_click(dev, BTN_LEFT, 0);
|
|
|
|
|
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_RIGHT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_PRESSED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_RIGHT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
litest_assert_button_event(li,
|
|
|
|
|
BTN_LEFT,
|
|
|
|
|
LIBINPUT_BUTTON_STATE_RELEASED);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-11-06 16:35:13 +01:00
|
|
|
START_TEST(pointer_scroll_button)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput *li = dev->libinput;
|
|
|
|
|
|
|
|
|
|
/* Make left button switch to scrolling mode */
|
2014-11-19 12:16:28 +10:00
|
|
|
libinput_device_config_scroll_set_method(dev->libinput_device,
|
2014-11-06 16:35:13 +01:00
|
|
|
LIBINPUT_CONFIG_SCROLL_ON_BUTTON_DOWN);
|
|
|
|
|
libinput_device_config_scroll_set_button(dev->libinput_device,
|
|
|
|
|
BTN_LEFT);
|
|
|
|
|
|
|
|
|
|
litest_drain_events(li);
|
|
|
|
|
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, 1, 6);
|
|
|
|
|
litest_assert_scroll(li, LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL, 6);
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, 1, -7);
|
|
|
|
|
litest_assert_scroll(li, LIBINPUT_POINTER_AXIS_SCROLL_VERTICAL, -7);
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, 8, 1);
|
|
|
|
|
litest_assert_scroll(li, LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL, 8);
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, -9, 1);
|
|
|
|
|
litest_assert_scroll(li, LIBINPUT_POINTER_AXIS_SCROLL_HORIZONTAL, -9);
|
|
|
|
|
|
|
|
|
|
/* scroll smaller than the threshold should not generate events */
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, 1, 1);
|
|
|
|
|
/* left press without movement should not generate events */
|
|
|
|
|
litest_button_scroll(dev, BTN_LEFT, 0, 0);
|
|
|
|
|
|
|
|
|
|
litest_assert_empty_queue(li);
|
|
|
|
|
|
|
|
|
|
/* Restore default scroll behavior */
|
2014-11-19 12:16:28 +10:00
|
|
|
libinput_device_config_scroll_set_method(dev->libinput_device,
|
|
|
|
|
libinput_device_config_scroll_get_default_method(
|
2014-11-06 16:35:13 +01:00
|
|
|
dev->libinput_device));
|
|
|
|
|
libinput_device_config_scroll_set_button(dev->libinput_device,
|
|
|
|
|
libinput_device_config_scroll_get_default_button(
|
|
|
|
|
dev->libinput_device));
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2015-02-03 09:35:19 +10:00
|
|
|
START_TEST(pointer_accel_defaults)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *device = dev->libinput_device;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
double speed;
|
|
|
|
|
|
|
|
|
|
ck_assert(libinput_device_config_accel_is_available(device));
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_default_speed(device) == 0.0);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == 0.0);
|
|
|
|
|
|
|
|
|
|
for (speed = -2.0; speed < -1.0; speed += 0.2) {
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
speed);
|
|
|
|
|
ck_assert_int_eq(status,
|
|
|
|
|
LIBINPUT_CONFIG_STATUS_INVALID);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == 0.0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (speed = -1.0; speed <= 1.0; speed += 0.2) {
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
speed);
|
|
|
|
|
ck_assert_int_eq(status,
|
|
|
|
|
LIBINPUT_CONFIG_STATUS_SUCCESS);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == speed);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (speed = 1.2; speed <= -2.0; speed += 0.2) {
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
speed);
|
|
|
|
|
ck_assert_int_eq(status,
|
|
|
|
|
LIBINPUT_CONFIG_STATUS_INVALID);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == 1.0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
Fix an abort if the device speed is NaN
When using libinput with xf86-input-libinput, the device speed is
represented as a float passed via X properties.
If a buggy client gives a broken value, the conversions that occur
can cause the value of speed to be NaN (not a number), aka infinity.
In C, any comparison with NaN always gives false, whatever the value.
So that test in libinput_device_config_accel_set_speed():
(speed < 1.0 || speed > 1.0)
will necessarily return FALSE, defeating the test of range.
However, since since any comparison with NaN is false, the
opposite assert() in accelerator_set_speed():
(speed >= 1.0 && speed <= 1.0)
will be false as well, thus triggering the abort() and the crash of
the entire X server along with it.
The solution is to use the same construct in both routines, so that
it fails gracefully in libinput_device_config_accel_set_speed().
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-02-05 14:33:31 +01:00
|
|
|
START_TEST(pointer_accel_invalid)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *device = dev->libinput_device;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
|
|
|
|
|
ck_assert(libinput_device_config_accel_is_available(device));
|
|
|
|
|
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
NAN);
|
|
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_INVALID);
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
INFINITY);
|
|
|
|
|
ck_assert_int_eq(status, LIBINPUT_CONFIG_STATUS_INVALID);
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2015-02-03 09:37:53 +10:00
|
|
|
START_TEST(pointer_accel_defaults_absolute)
|
|
|
|
|
{
|
|
|
|
|
struct litest_device *dev = litest_current_device();
|
|
|
|
|
struct libinput_device *device = dev->libinput_device;
|
|
|
|
|
enum libinput_config_status status;
|
|
|
|
|
double speed;
|
|
|
|
|
|
|
|
|
|
ck_assert(!libinput_device_config_accel_is_available(device));
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_default_speed(device) == 0.0);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == 0.0);
|
|
|
|
|
|
|
|
|
|
for (speed = -2.0; speed <= 2.0; speed += 0.2) {
|
|
|
|
|
status = libinput_device_config_accel_set_speed(device,
|
|
|
|
|
speed);
|
|
|
|
|
if (speed >= -1.0 && speed <= 1.0)
|
|
|
|
|
ck_assert_int_eq(status,
|
|
|
|
|
LIBINPUT_CONFIG_STATUS_UNSUPPORTED);
|
|
|
|
|
else
|
|
|
|
|
ck_assert_int_eq(status,
|
|
|
|
|
LIBINPUT_CONFIG_STATUS_INVALID);
|
|
|
|
|
ck_assert(libinput_device_config_accel_get_speed(device) == 0.0);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
END_TEST
|
|
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
int main (int argc, char **argv) {
|
|
|
|
|
|
2014-10-29 11:05:20 +10:00
|
|
|
litest_add("pointer:motion", pointer_motion_relative, LITEST_RELATIVE, LITEST_ANY);
|
2014-10-29 11:58:09 +10:00
|
|
|
litest_add("pointer:motion", pointer_motion_absolute, LITEST_ABSOLUTE, LITEST_ANY);
|
2014-12-04 11:44:09 +08:00
|
|
|
litest_add("pointer:motion", pointer_motion_unaccel, LITEST_RELATIVE, LITEST_ANY);
|
2014-02-17 11:14:29 +10:00
|
|
|
litest_add("pointer:button", pointer_button, LITEST_BUTTON, LITEST_CLICKPAD);
|
2014-07-27 16:02:46 +02:00
|
|
|
litest_add_no_device("pointer:button_auto_release", pointer_button_auto_release);
|
2014-01-21 14:17:01 +10:00
|
|
|
litest_add("pointer:scroll", pointer_scroll_wheel, LITEST_WHEEL, LITEST_ANY);
|
2014-11-06 16:35:13 +01:00
|
|
|
litest_add("pointer:scroll", pointer_scroll_button, LITEST_RELATIVE|LITEST_BUTTON, LITEST_ANY);
|
2014-11-18 12:03:48 +10:00
|
|
|
litest_add("pointer:scroll", pointer_scroll_natural_defaults, LITEST_WHEEL, LITEST_ANY);
|
|
|
|
|
litest_add("pointer:scroll", pointer_scroll_natural_enable_config, LITEST_WHEEL, LITEST_ANY);
|
|
|
|
|
litest_add("pointer:scroll", pointer_scroll_natural_wheel, LITEST_WHEEL, LITEST_ANY);
|
2014-04-01 22:24:10 +02:00
|
|
|
litest_add_no_device("pointer:seat button count", pointer_seat_button_count);
|
2014-01-21 14:17:01 +10:00
|
|
|
|
2014-10-29 10:59:58 +10:00
|
|
|
litest_add("pointer:calibration", pointer_no_calibration, LITEST_ANY, LITEST_TOUCH|LITEST_SINGLE_TOUCH|LITEST_ABSOLUTE);
|
2014-08-26 11:41:19 +10:00
|
|
|
|
2014-09-23 12:46:02 +10:00
|
|
|
/* tests touchpads too */
|
|
|
|
|
litest_add("pointer:left-handed", pointer_left_handed_defaults, LITEST_BUTTON, LITEST_ANY);
|
2014-10-29 11:05:20 +10:00
|
|
|
litest_add("pointer:left-handed", pointer_left_handed, LITEST_RELATIVE|LITEST_BUTTON, LITEST_ANY);
|
|
|
|
|
litest_add("pointer:left-handed", pointer_left_handed_during_click, LITEST_RELATIVE|LITEST_BUTTON, LITEST_ANY);
|
|
|
|
|
litest_add("pointer:left-handed", pointer_left_handed_during_click_multiple_buttons, LITEST_RELATIVE|LITEST_BUTTON, LITEST_ANY);
|
2014-09-23 12:46:02 +10:00
|
|
|
|
2015-02-03 09:35:19 +10:00
|
|
|
litest_add("pointer:accel", pointer_accel_defaults, LITEST_RELATIVE, LITEST_ANY);
|
Fix an abort if the device speed is NaN
When using libinput with xf86-input-libinput, the device speed is
represented as a float passed via X properties.
If a buggy client gives a broken value, the conversions that occur
can cause the value of speed to be NaN (not a number), aka infinity.
In C, any comparison with NaN always gives false, whatever the value.
So that test in libinput_device_config_accel_set_speed():
(speed < 1.0 || speed > 1.0)
will necessarily return FALSE, defeating the test of range.
However, since since any comparison with NaN is false, the
opposite assert() in accelerator_set_speed():
(speed >= 1.0 && speed <= 1.0)
will be false as well, thus triggering the abort() and the crash of
the entire X server along with it.
The solution is to use the same construct in both routines, so that
it fails gracefully in libinput_device_config_accel_set_speed().
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
2015-02-05 14:33:31 +01:00
|
|
|
litest_add("pointer:accel", pointer_accel_invalid, LITEST_RELATIVE, LITEST_ANY);
|
2015-02-03 09:37:53 +10:00
|
|
|
litest_add("pointer:accel", pointer_accel_defaults_absolute, LITEST_ABSOLUTE, LITEST_ANY);
|
2015-02-03 09:35:19 +10:00
|
|
|
|
2014-01-21 14:17:01 +10:00
|
|
|
return litest_run(argc, argv);
|
|
|
|
|
}
|