fdo-mirrors/libfprint
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libfprint/libfprint.git synced 2026-05-11 08:28:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

samsung7305: guard frame-list walk against scan-build false positive

Browse source 
scan-build flags ordered->next as a possible null deref because it
cannot correlate the GSList length with frames_captured. The
frames_captured >= MIN_FRAMES guard upstream of the head drop makes
the deref safe in practice, but adding an explicit ordered &&
ordered->next check silences the analyzer without changing behavior.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Justin Hall 2026-04-23 14:18:00 -04:00
parent 0067205059
commit 7912a0cb26
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libfprint/drivers/samsung7305.c
View file

@ -1158,7 +1158,7 @@ m_loop_state (FpiSsm *ssm, FpDevice *dev)
self->frames_captured);
}
if (self->frames_captured >= 2)
if (self->frames_captured >= 2 && ordered && ordered->next)
{
/* Fixed stride instead of motion estimation — see the note
* near ASSEMBLE_STRIDE. First frame's delta_y is forced to 0