fdo-mirrors/libevdev
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libevdev/libevdev.git synced 2025-12-24 10:00:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

memcpy instead of invidual bittoggle

Browse source 
The ioctls return the number of bytes copied into the destination, so just
copy them into the device state instead of individually flipping bits.

For easier review: rc is the return value of the EVIOCG* ioctl, which is
the number of bytes copied.

state variables must be initialized to 0 now, in case the kernel's FOO_MAX
is smaller than libevdev's FOO_MAX. If not initialized to 0, the bytes
between the two max values is undefined and we may end up generating bogus
events.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@gmail.com>
This commit is contained in:
Peter Hutterer 2013-08-29 15:52:54 +10:00
parent e372c4a6bd
commit 4417a6a1c1
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
libevdev/libevdev.c
View file

@ -306,7 +306,7 @@ sync_key_state(struct libevdev *dev)
{
int rc;
int i;
unsigned long keystate[NLONGS(KEY_CNT)];
unsigned long keystate[NLONGS(KEY_CNT)] = {0};
rc = ioctl(dev->fd, EVIOCGKEY(sizeof(keystate)), keystate);
if (rc < 0)
@ -320,9 +320,10 @@ sync_key_state(struct libevdev *dev)
struct input_event *ev = queue_push(dev);
init_event(dev, ev, EV_KEY, i, new ? 1 : 0);
}
set_bit_state(dev->key_values, i, new);
}
memcpy(dev->key_values, keystate, rc);
rc = 0;
out:
return rc ? -errno : 0;
@ -333,7 +334,7 @@ sync_sw_state(struct libevdev *dev)
{
int rc;
int i;
unsigned long swstate[NLONGS(SW_CNT)];
unsigned long swstate[NLONGS(SW_CNT)] = {0};
rc = ioctl(dev->fd, EVIOCGSW(sizeof(swstate)), swstate);
if (rc < 0)
@ -347,9 +348,10 @@ sync_sw_state(struct libevdev *dev)
struct input_event *ev = queue_push(dev);
init_event(dev, ev, EV_SW, i, new ? 1 : 0);
}
set_bit_state(dev->sw_values, i, new);
}
memcpy(dev->sw_values, swstate, rc);
rc = 0;
out:
return rc ? -errno : 0;
@ -360,7 +362,7 @@ sync_led_state(struct libevdev *dev)
{
int rc;
int i;
unsigned long ledstate[NLONGS(LED_CNT)];
unsigned long ledstate[NLONGS(LED_CNT)] = {0};
rc = ioctl(dev->fd, EVIOCGLED(sizeof(ledstate)), ledstate);
if (rc < 0)
@ -374,9 +376,10 @@ sync_led_state(struct libevdev *dev)
struct input_event *ev = queue_push(dev);
init_event(dev, ev, EV_LED, i, new ? 1 : 0);
}
set_bit_state(dev->led_values, i, new);
}
memcpy(dev->led_values, ledstate, rc);
rc = 0;
out:
return rc ? -errno : 0;