fdo-mirrors/libei
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/libinput/libei.git synced 2026-01-01 18:40:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

eis: only queue a seat bind event if the caps change

Browse source 
This triggered an internal bug message in test_ei_seat_bind_unbind_immediately.

If a client unbinds all capabilities this triggers an EIS_SEAT_BIND with
zero caps. peck would call eis_seat_remove() which calls eis_seat_drop().
That queued another EIS_EVENT_SEAT_BIND with zero capabilities, leading
peck to call eis_seat_remove() again on an already removed seat.
This commit is contained in:
Peter Hutterer 2023-11-08 10:51:14 +10:00
parent 44e7f2cbc4
commit d31b5a1ccf
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/libeis-seat.c
View file

@ -241,9 +241,12 @@ eis_seat_bind(struct eis_seat *seat, uint32_t caps)
}
caps &= seat->capabilities.c_mask;
seat->state = EIS_SEAT_STATE_BOUND;
eis_queue_seat_bind_event(seat, caps);
uint32_t old_caps = seat->capabilities.bound;
seat->capabilities.bound = caps;
if (old_caps != caps)
eis_queue_seat_bind_event(seat, caps);
}
void

2
src/libeis-seat.h
View file

@ -51,6 +51,8 @@ struct eis_seat {
struct {
uint32_t c_mask; /* this is the C API bitmask */
uint64_t proto_mask; /* the protocol mask */
uint32_t bound; /* C API bitmask */
} capabilities;
struct list devices;