From a646a4c19bde20d9364e0d5e8b382bd3bd96a370 Mon Sep 17 00:00:00 2001 From: Jason Gerecke Date: Wed, 24 Sep 2025 11:41:14 -0700 Subject: [PATCH] eierpecken: Have peck_disable_ei[s]_behavior actually disable things The peck_disable_eis_behavior and peck_disable_ei_behavior functions would incorectly *enable* behaviors when called with certain arguments that cover multiple behaviors (e.g. PECK_EIS_BEHAVIOR_ACCEPT_ALL). This commit modifies the logic to instead disable the behaviors. Part-of: --- test/eierpecken.c | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/test/eierpecken.c b/test/eierpecken.c index ea44e95..71949b6 100644 --- a/test/eierpecken.c +++ b/test/eierpecken.c @@ -743,19 +743,19 @@ peck_disable_eis_behavior(struct peck *peck, enum peck_eis_behavior behavior) flag_clear(peck->eis_behavior, behavior); break; case PECK_EIS_BEHAVIOR_ACCEPT_ALL: - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_DEFAULT_SEAT); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ACCEPT_CLIENT); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_BIND_SEAT); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_RESUME_DEVICE); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_CLOSE_DEVICE); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_START_EMULATING); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_STOP_EMULATING); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_DEFAULT_SEAT); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ACCEPT_CLIENT); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_BIND_SEAT); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_RESUME_DEVICE); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_CLOSE_DEVICE); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_START_EMULATING); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_HANDLE_STOP_EMULATING); break; case PECK_EIS_BEHAVIOR_ADD_DEVICES: - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_POINTER); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_POINTER_ABSOLUTE); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_KEYBOARD); - peck_enable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_TOUCH); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_POINTER); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_POINTER_ABSOLUTE); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_KEYBOARD); + peck_disable_eis_behavior(peck, PECK_EIS_BEHAVIOR_ADD_TOUCH); break; case PECK_EIS_BEHAVIOR_HANDLE_BIND_SEAT: case PECK_EIS_BEHAVIOR_HANDLE_CLOSE_DEVICE: @@ -829,18 +829,18 @@ peck_disable_ei_behavior(struct peck *peck, enum peck_ei_behavior behavior) flag_clear(peck->ei_behavior, behavior); break; case PECK_EI_BEHAVIOR_AUTODEVICES: - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_CONNECT); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_AUTOSEAT); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_RESUMED); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_CONNECT); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_AUTOSEAT); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_RESUMED); break; case PECK_EI_BEHAVIOR_HANDLE_ADDED: - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_POINTER); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_POINTER_ABSOLUTE); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_KEYBOARD); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_TOUCH); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_BUTTON); - peck_enable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_SCROLL); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_POINTER); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_POINTER_ABSOLUTE); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_KEYBOARD); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_TOUCH); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_BUTTON); + peck_disable_ei_behavior(peck, PECK_EI_BEHAVIOR_HANDLE_ADDED_SCROLL); break; case PECK_EI_BEHAVIOR_AUTOSTART: case PECK_EI_BEHAVIOR_HANDLE_ADDED_POINTER: