From 89e27dec59fc0d3998fb88136df11bb36211493a Mon Sep 17 00:00:00 2001 From: Jason Gerecke Date: Fri, 18 Jul 2025 13:52:45 -0700 Subject: [PATCH] Remove `enum="capability"` from stylus (bind_)tool_capabilities Placing the 'enum' attribute on the args to bind_tool_capabilities and tool_capabilities causes problems for the code autogenerated by reis. In particular, args with the enum attribute end up using a variable of the associated enumerated type rather than (for example) u32. This prevents us from OR-ing together flags since such combined values are not considered valid in the type system. Maybe the XML should have something similar to 'enum' but which explicitly has flag-like semantics... This would allow autogen code to still refer back to the enum, but also ensure that appropriate (boolean-combinable) types are used for storage. But such an addition is outside the direct scope of this patchset... --- proto/protocol.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proto/protocol.xml b/proto/protocol.xml index bf77176..9a3306d 100644 --- a/proto/protocol.xml +++ b/proto/protocol.xml @@ -1747,7 +1747,7 @@ It is a protocol violation to send requests or events for unbound capabilities. - + @@ -2037,7 +2037,7 @@ ei_stylus.bind_tool_capabilities request before the device will send events. - +