Bastien Nocera
190b8480fb
Add new TODO item
...
From browsing the web
2009-01-27 16:45:16 -03:00
Bastien Nocera
04fd09cfa8
dbus + fprintd error
...
On Mon, 2009-01-12 at 12:18 +0000, Konstantin V. Gavrilenko wrote:
> Hi Bastien,
>
> by default the fprintd installs the pam_fprintd into the /usr/lib64/security, whil egentoo searches them in /lib/security.
> So I simply simlinked it to the correct location /usr/lib64/security/pam_fprintd.so to /lib/security/pam_fprintd.so
> I've removed the symlink, and copied the file, but it does not change anything, the same error appears.
>
> As you asked, recompiled some of the packages with "-O1 -gddb" and "nostrip" options.
> #4 0x00007fa3344a3899 in dbus_connection_unref (connection=0x624e20) at dbus-connection.c:2686
> __FUNCTION__ = "dbus_connection_unref"
> #5 0x00007fa334915284 in pam_sm_authenticate (pamh=0x6105c0, flags=<value optimized out>, argc=<value optimized out>, argv=<value optimized out>) at pam_fprintd.c:375
> rhost = 0x0
> username = 0x610740 "root"
> i = <value optimized out>
> r = 0
Could you please test the attached patch?
Cheers
2009-01-24 17:10:05 -03:00
Bastien Nocera
9498800f20
More cleanups
...
Some objects were leaked when no devices were available. Plug those
leaks.
2008-12-20 11:46:32 +00:00
Bastien Nocera
b2b81d0df9
Update D-Bus config file
...
Following the recent changes in D-Bus, the configuration file
needs to be a bit more explicit.
2008-12-10 00:54:28 +00:00
Bastien Nocera
d93b272f06
Install interfaces files
...
Apparently helps developers who want to read the interfaces
by hand, rather than using the API docs. Mentioned by Matthias in
his fprintd package review:
https://bugzilla.redhat.com/show_bug.cgi?id=469955#c9
2008-12-10 00:54:27 +00:00
Bastien Nocera
6be837a5fb
Fix warnings during docs build
...
cd ./html && gtkdoc-mkhtml fprintd ../fprintd-docs.xml
../fprintd-docs.xml:79: element include: XInclude error : ../../COPYING
contains invalid char
../fprintd-docs.xml:79: element include: XInclude error : could not load
../../COPYING, and no fallback was found
Remove the Ctrl-L characters in the COPYING file.
2008-12-10 00:54:27 +00:00
Bastien Nocera
9874ac4b91
Add string helper for results and fingers
...
Add a simple header file which can be copied to other projects
to simplify i18n of results and strings.
2008-12-10 00:54:27 +00:00
Daniel Drake
43fe72a2aa
license is GPLv2
...
Not sure how v3 creeped in, oops! thanks to bastien for pointing this
out
2008-12-04 14:53:02 +00:00
Bastien Nocera
6a480f409d
Stop extra signals from being emitted
...
Some devices keep sending us signals when an enrollment or
verification finished. Ignore all those signals, we hate them.
2008-12-04 13:23:51 +00:00
Bastien Nocera
3941c3bff2
Add fprintd-delete program
...
Deletes all the fingerprints on all the registered devices.
2008-12-04 13:23:51 +00:00
Bastien Nocera
5ba723e3f2
Fix program description
...
In the source header
2008-12-04 13:23:51 +00:00
Bastien Nocera
4efa0d4878
Fix stupidness in the fprintd-enroll
...
This fixes fprintd-enroll not working on devices that require
more than one swipe.
2008-12-04 13:23:51 +00:00
Bastien Nocera
c1dc3f1394
Fix fprintd exiting after a device goes unused
...
Simple logic error that caused fprintd to exit when a device
was used then unused.
2008-12-04 13:23:50 +00:00
Bastien Nocera
c1ec85006e
Add README for the PAM module
...
With some more info about the options.
2008-12-04 13:23:50 +00:00
Bastien Nocera
af5b8a6e37
Don't error out when there's no fingerprints
...
Instead, print out some information about the device, and carry
on to the next one.
2008-12-04 13:23:50 +00:00
Bastien Nocera
6f69aef553
Remove some dead code in PAM
...
verify_result_str() isn't used anymore.
2008-12-04 13:23:50 +00:00
Bastien Nocera
69e987b335
Fix return value for GetDefaultDevice
...
Tell the front-end there's no devices available when there isn't
any, instead of erroring out.
2008-12-04 13:23:50 +00:00
Bastien Nocera
64e415aaac
Fix memleak on VerifyStart
...
Clean up the data pass to the async verification and identification
functions ourselves.
2008-11-24 17:20:46 +00:00
Bastien Nocera
7b06c4b7f3
Review possible errors and document them
...
Review all the possible errors and document them for each function.
2008-11-24 17:20:46 +00:00
Bastien Nocera
1abf51afa4
Don't crash the server if there's no devices
...
Big ninny just crashed because there's no fingerprint readers. Hoo,
hoo. My eyes are bleeding.
2008-11-24 17:20:46 +00:00
Bastien Nocera
9743d9d2a0
Register errors with D-Bus
...
So we get errors like:
net.reactivated.Fprint.Error.DiscoverPrints
instead of:
org.freedesktop.DBus.GLib.UnmappedError.FprintdErrorQuark.Code2
2008-11-24 17:20:46 +00:00
Bastien Nocera
6fc861a154
Use dbus_g_proxy_new_from_proxy
...
Removes the need to have the dbus connection around.
2008-11-24 17:20:45 +00:00
Bastien Nocera
b225947a56
Fix make distcheck
...
Fix missing documentation file when --enable-gtk-doc isn't passed
along to configure.
2008-11-24 17:19:08 +00:00
Bastien Nocera
b4ee4a5cdd
Add debug option for PAM
...
When the debug option is set in the PAM configuration, redirect
debug output to syslog (usually /var/log/secure).
2008-11-24 17:19:08 +00:00
Bastien Nocera
af42ec70f3
Fix possible warning when timeout is enabled
...
We'd get a warning when the first device starts being used, but
we don't use --no-timeout.
2008-11-22 13:01:16 +00:00
Bastien Nocera
2b71776124
Fix GetAll properties call
...
The error wasn't properly initialised, but wasn't used anyway, and
we were missing the interface argument.
2008-11-22 13:01:16 +00:00
Bastien Nocera
c9fdeb47aa
Use D-Bus properties instead of GetProperties
...
- Use D-Bus native properties instead of a GetProperties call.
- Fix a number of front-ends by registering the right signals and
marshallers following the "done" signal argument addition
- Fix VerifyStart call in the pam module
2008-11-22 13:00:48 +00:00
Bastien Nocera
f1f2ae35f8
Fix "--no-timeout" argument
...
Fix logic error in the manager code causing it to exit when no
devices are in use even when --no-timeout is passed.
2008-11-22 13:00:47 +00:00
Bastien Nocera
dfa539a1f8
Add documentation
...
Documentation FTW!
2008-11-21 18:15:51 +00:00
Bastien Nocera
120c9a1099
Some changes to our docbook XSLT script
...
Add <doc:title> for use in the top-level description, and
a description link type, to link to those sub-paragraphs.
2008-11-21 18:15:51 +00:00
Bastien Nocera
3cd0a7aeaf
First pass at adding API docs through gtk-doc
...
Required a bit of mangling.
2008-11-21 18:15:51 +00:00
Bastien Nocera
26aab5dc28
Add a done argument to result signals
...
For verify and enroll, add a done argument so that front-end
know easily when they should be closing the device.
2008-11-21 18:15:51 +00:00
Bastien Nocera
0636c77962
Enumerate all the fingers for swipe and press
...
We need to enumerate all the fingers for swipe and press actions,
otherwise we might break break translations.
2008-11-21 18:15:51 +00:00
Bastien Nocera
837627b1a7
Use scan type property for better messages
...
Better messages for the PAM plugin, by using whether the device
requires swiping or pressing the finger on the reader.
2008-11-21 18:15:51 +00:00
Bastien Nocera
874d8164b4
Add ScanType and NumberEnrollStages properties
...
Export the type of scan the device performs, and, when the device
is claimed, the number of enrollment stages.
2008-11-21 18:15:50 +00:00
Bastien Nocera
f7186c7ff0
Remove all uses of enums in the API
...
The clients aren't supposed to know the magic numbers for enums,
so use strings instead.
2008-11-21 18:15:50 +00:00
Bastien Nocera
f39e1475b4
Update TODO
...
More done, and more to do.
2008-11-21 18:15:44 +00:00
Bastien Nocera
5426b1a472
Use GetDefaultDevice
...
As we're not using the non-default device anyway.
2008-11-21 18:15:21 +00:00
Bastien Nocera
e207203b44
Add GetDefaultDevice
...
Gives you the first device listed in GetDevices.
2008-11-21 18:15:21 +00:00
Bastien Nocera
ac85e5927e
List all the fingerprints for all the users
...
When listing, list all the fingerprints for all the users mentioned on
the command-line for each connected device, rather than just the
default one.
2008-11-21 18:15:21 +00:00
Bastien Nocera
1e43720c15
Remove use of finger number in the API
...
Use well-defined strings instead of numbers to pass around
specific fingers in the public API.
2008-11-21 18:15:21 +00:00
Bastien Nocera
ea4114b976
Make GetProperties async
...
as the rest of our functions.
2008-11-21 18:15:21 +00:00
Bastien Nocera
924e08d2e8
Add device name property
...
Add GetProperties method, with a single "Name" properties into
the hashtable.
Use the device name property in the PAM module, and in the list test.
2008-11-21 18:15:21 +00:00
Bastien Nocera
69c131f723
Add gross hack to allow root to verify users
...
This is a gross hack for PAM sessions to work as expected. root
is allowed to verify any users. If you want to allow any other
actions for root, you'll need to go through normal PolicyKit
procedures.
This should fix fingerprint authentication not working in GDM, or
on the console.
2008-11-21 18:14:09 +00:00
Bastien Nocera
d874d5869c
Add another TODO item
...
We need to double-check the messages so that they're translated
for users in the UIs.
2008-11-21 18:14:09 +00:00
Bastien Nocera
31a8e2c61d
Fix distcheck
...
And add a TODO item
2008-11-21 18:14:09 +00:00
Bastien Nocera
fb4cbb910b
Prefix the test binaries
...
So that we avoid clashing with distribution binaries.
2008-11-21 18:14:09 +00:00
Bastien Nocera
8bae65d50e
Fix pam module running under gnome-screensaver
...
1) Set up our own D-Bus (private) connection
2) Set up our own main loop and main loop context
This means we finally work right within gnome-screensaver!
2008-11-18 17:07:10 +00:00
Bastien Nocera
f93d8cbce2
Clean up device when the client disconnects
...
Track clients connected to each device using EggDbusMonitor.
When there are no more clients connected to the device, release it.
When no devices are used anymore, set up a timeout to exit within
30 seconds.
2008-11-03 22:56:12 +00:00
Bastien Nocera
b0f2060628
Exit when no devices are in use
...
When no actions are happening on any of the devices, make the
daemon exit after 30 seconds.
2008-11-03 22:56:12 +00:00