From 043fcaafec655d9956cd73db2184637a25aa093b Mon Sep 17 00:00:00 2001 From: Benjamin Berg Date: Sat, 5 Dec 2020 11:36:41 +0100 Subject: [PATCH] pam_fprintd: Guard against NULL pointer returned by finger_str_to_msg Otherwise the PAM module will crash trying to send an info message about the selected print. --- pam/pam_fprintd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pam/pam_fprintd.c b/pam/pam_fprintd.c index 583e7c5..bd156ce 100644 --- a/pam/pam_fprintd.c +++ b/pam/pam_fprintd.c @@ -249,6 +249,10 @@ verify_finger_selected (sd_bus_message *m, } msg = finger_str_to_msg(finger_name, data->driver, data->is_swipe); + if (!msg) { + data->result = strdup ("Protocol error with fprintd!"); + return 0; + } if (debug) pam_syslog (data->pamh, LOG_DEBUG, "verify_finger_selected %s", msg); send_info_msg (data->pamh, msg);