mirror of
https://gitlab.freedesktop.org/dbus/dbus.git
synced 2026-05-31 08:58:23 +02:00
As a general design principle, strings that we aren't going to modify should usually be const. When compiling with -Wwrite-strings, quoted string constants are of type "const char *", causing compiler warnings when they are assigned to char * variables. Unfortunately, we need to add casts in a few places: * _dbus_list_append(), _dbus_test_oom_handling() and similar generic "user-data" APIs take a void *, not a const void *, so we have to cast * For historical reasons the execve() family of functions take a (char * const *), i.e. a constant pointer to an array of mutable strings, so again we have to cast * _dbus_spawn_async_with_babysitter similarly takes a char **, although we can make it a little more const-correct by making it take (char * const *) like execve() does This also incorporates a subsequent patch by Thomas Zimmermann to put various string constants in static storage, which is a little more efficient. Signed-off-by: Simon McVittie <smcv@debian.org> Reviewed-by: Thomas Zimmermann <tdz@users.sourceforge.net> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=97357
177 lines
5.5 KiB
C
177 lines
5.5 KiB
C
/**
|
|
* Test to make sure late thread initialization works
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include <dbus/dbus.h>
|
|
#include <dbus/dbus-sysdeps.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
#include <dbus/dbus-internals.h>
|
|
#include <dbus/dbus-connection-internal.h>
|
|
|
|
static void
|
|
_run_iteration (DBusConnection *conn)
|
|
{
|
|
DBusPendingCall *echo_pending;
|
|
DBusPendingCall *dbus_pending;
|
|
DBusMessage *method;
|
|
DBusMessage *reply;
|
|
const char *echo = "echo";
|
|
|
|
/* send the first message */
|
|
method = dbus_message_new_method_call ("org.freedesktop.DBus.TestSuiteEchoService",
|
|
"/org/freedesktop/TestSuite",
|
|
"org.freedesktop.TestSuite",
|
|
"Echo");
|
|
|
|
dbus_message_append_args (method, DBUS_TYPE_STRING, &echo, NULL);
|
|
dbus_connection_send_with_reply (conn, method, &echo_pending, -1);
|
|
dbus_message_unref (method);
|
|
|
|
/* send the second message */
|
|
method = dbus_message_new_method_call (DBUS_SERVICE_DBUS,
|
|
DBUS_PATH_DBUS,
|
|
"org.freedesktop.Introspectable",
|
|
"Introspect");
|
|
|
|
dbus_connection_send_with_reply (conn, method, &dbus_pending, -1);
|
|
dbus_message_unref (method);
|
|
|
|
/* block on the second message (should return immediately) */
|
|
dbus_pending_call_block (dbus_pending);
|
|
|
|
/* block on the first message */
|
|
/* if it does not return immediately chances
|
|
are we hit the block in poll bug */
|
|
dbus_pending_call_block (echo_pending);
|
|
|
|
/* check the reply only to make sure we
|
|
are not getting errors unrelated
|
|
to the block in poll bug */
|
|
reply = dbus_pending_call_steal_reply (echo_pending);
|
|
|
|
if (reply == NULL)
|
|
{
|
|
printf ("Failed: Reply is NULL ***\n");
|
|
exit (1);
|
|
}
|
|
|
|
if (dbus_message_get_type (reply) == DBUS_MESSAGE_TYPE_ERROR)
|
|
{
|
|
printf ("Failed: Reply is error: %s ***\n", dbus_message_get_error_name (reply));
|
|
exit (1);
|
|
}
|
|
|
|
dbus_message_unref (reply);
|
|
dbus_pending_call_unref (dbus_pending);
|
|
dbus_pending_call_unref (echo_pending);
|
|
|
|
}
|
|
static void
|
|
check_mutex_lock (DBusMutex *mutex1,
|
|
DBusMutex *mutex2,
|
|
dbus_bool_t is_same)
|
|
{
|
|
_dbus_assert (mutex1 != NULL);
|
|
_dbus_assert (mutex2 != NULL);
|
|
|
|
if (is_same)
|
|
{
|
|
_dbus_assert (mutex1 == mutex2);
|
|
}
|
|
else
|
|
{
|
|
_dbus_assert (mutex1 != mutex2);
|
|
}
|
|
}
|
|
|
|
static void
|
|
check_condvar_lock (DBusCondVar *condvar1,
|
|
DBusCondVar *condvar2,
|
|
dbus_bool_t is_same)
|
|
{
|
|
_dbus_assert (condvar1 != NULL);
|
|
_dbus_assert (condvar2 != NULL);
|
|
|
|
if (is_same)
|
|
{
|
|
_dbus_assert (condvar1 == condvar2);
|
|
}
|
|
else
|
|
{
|
|
_dbus_assert (condvar1 != condvar2);
|
|
}
|
|
}
|
|
|
|
/* This test outputs TAP syntax: http://testanything.org/ */
|
|
int
|
|
main (int argc, char *argv[])
|
|
{
|
|
DBusMessage *method;
|
|
DBusConnection *conn;
|
|
DBusError error;
|
|
DBusMutex *mutex1, *dispatch_mutex1, *io_path_mutex1;
|
|
DBusCondVar *dispatch_cond1, *io_path_cond1;
|
|
DBusMutex *mutex2, *dispatch_mutex2, *io_path_mutex2;
|
|
DBusCondVar *dispatch_cond2, *io_path_cond2;
|
|
int test_num = 0;
|
|
|
|
printf ("*** Testing late thread init\n");
|
|
|
|
dbus_error_init (&error);
|
|
|
|
conn = dbus_bus_get (DBUS_BUS_SESSION, &error);
|
|
|
|
_dbus_connection_test_get_locks (conn, &mutex1,
|
|
&dispatch_mutex1,
|
|
&io_path_mutex1,
|
|
&dispatch_cond1,
|
|
&io_path_cond1);
|
|
_run_iteration (conn);
|
|
_dbus_connection_test_get_locks (conn, &mutex2,
|
|
&dispatch_mutex2,
|
|
&io_path_mutex2,
|
|
&dispatch_cond2,
|
|
&io_path_cond2);
|
|
|
|
check_mutex_lock (mutex1, mutex2, TRUE);
|
|
check_mutex_lock (dispatch_mutex1, dispatch_mutex2, TRUE);
|
|
check_mutex_lock (io_path_mutex1, io_path_mutex2, TRUE);
|
|
check_condvar_lock (dispatch_cond1, dispatch_cond2, TRUE);
|
|
check_condvar_lock (io_path_cond1, io_path_cond2, TRUE);
|
|
printf ("ok %d\n", ++test_num);
|
|
|
|
dbus_threads_init_default ();
|
|
|
|
_dbus_connection_test_get_locks (conn, &mutex1,
|
|
&dispatch_mutex1,
|
|
&io_path_mutex1,
|
|
&dispatch_cond1,
|
|
&io_path_cond1);
|
|
|
|
_run_iteration (conn);
|
|
_dbus_connection_test_get_locks (conn, &mutex2,
|
|
&dispatch_mutex2,
|
|
&io_path_mutex2,
|
|
&dispatch_cond2,
|
|
&io_path_cond2);
|
|
|
|
check_mutex_lock (mutex1, mutex2, TRUE);
|
|
check_mutex_lock (dispatch_mutex1, dispatch_mutex2, TRUE);
|
|
check_mutex_lock (io_path_mutex1, io_path_mutex2, TRUE);
|
|
check_condvar_lock (dispatch_cond1, dispatch_cond2, TRUE);
|
|
check_condvar_lock (io_path_cond1, io_path_cond2, TRUE);
|
|
printf ("ok %d\n", ++test_num);
|
|
|
|
method = dbus_message_new_method_call ("org.freedesktop.TestSuiteEchoService",
|
|
"/org/freedesktop/TestSuite",
|
|
"org.freedesktop.TestSuite",
|
|
"Exit");
|
|
dbus_connection_send (conn, method, NULL);
|
|
dbus_message_unref (method);
|
|
|
|
printf ("Testing completed\n1..%d\n", test_num);
|
|
exit (0);
|
|
}
|