mirror of
https://gitlab.freedesktop.org/dbus/dbus.git
synced 2025-12-31 06:30:11 +01:00
bef88fd562
This is really three separate test-cases: one for traditional activation as a direct child process of the dbus-daemon, and two for traditional activation (successful and failing) via the setuid dbus-daemon-launch-helper on Unix. The ones where activation succeeds extremely slow, as a result of the instrumentation for simulating malloc() failures combined with a large number of memory operations, particularly when using AddressSanitizer. Splitting up "OOM" tests like these has a disproportionately good impact on the time they take, because the simulated malloc() failure instrumentation repeats the entire test making the first malloc() fail, then making the second malloc() fail, and so on. For allocation failures in the second half of the test, this means we repeat the first half of the test with no malloc() failures a very large number of times, which is not a good use of time, because we already tested it successfully. Even when not using the "OOM" instrumentation, splitting up these tests lets them run in parallel, which is also a major time saving. Needless to say, this speeds up testing considerably. On my modern but unexceptional x86 laptop, in a typical debug build with Meson, the old dispatch test took just over 21 minutes, which drops to about 40 seconds each for the new normal-activation and helper-activation tests (and for most of that time, they're running in parallel, so the wall-clock time taken for the whole test suite is somewhere around a minute). In a debug build with Meson, gcc and AddressSanitizer, the old dispatch test takes longer than my patience will allow, and the new separate tests take about 5-6 minutes each. Reduce their timeout accordingly, but not as far as the default for slow tests (5 minutes) to allow some headroom for AddressSanitizer or slower systems. The failed-helper-activation test is almost instantaneous, and no longer needs to be marked as slow. Signed-off-by: Simon McVittie <smcv@collabora.com> |
||
|---|---|---|
| .. | ||
| bus | ||
| data | ||
| integration | ||
| internals | ||
| name-test | ||
| .gitignore | ||
| CMakeLists.txt | ||
| containers.c | ||
| corrupt.c | ||
| dbus-daemon-eavesdrop.c | ||
| dbus-daemon.c | ||
| dbus-test-runner | ||
| disable-crash-handling.c | ||
| disable-crash-handling.h | ||
| fdpass.c | ||
| glib-tap-test.sh | ||
| header-fields.c | ||
| loopback.c | ||
| Makefile.am | ||
| manual-authz.c | ||
| manual-backtrace.c | ||
| manual-dir-iter.c | ||
| manual-paths.c | ||
| manual-tcp.c | ||
| marshal.c | ||
| meson.build | ||
| message.c | ||
| meta_template.test.in | ||
| mkdir-m700.py | ||
| monitor.c | ||
| relay.c | ||
| sd-activation.c | ||
| shell-test.c | ||
| spawn-test.c | ||
| syntax.c | ||
| tap-test.sh.in | ||
| test-apparmor-activation.sh | ||
| test-dbus-daemon-fork.sh | ||
| test-dbus-launch-eval.sh | ||
| test-dbus-launch-x11.sh | ||
| test-exit.c | ||
| test-names.c | ||
| test-platform-mutex.c | ||
| test-privserver.c | ||
| test-segfault.c | ||
| test-service.c | ||
| test-shell-service.c | ||
| test-sleep-forever.c | ||
| test-utils-glib.c | ||
| test-utils-glib.h | ||
| test-utils.c | ||
| test-utils.h | ||
| thread-blocking.c | ||
| uid-permissions.c | ||