mirror of
https://gitlab.freedesktop.org/dbus/dbus.git
synced 2026-05-18 12:58:06 +02:00
949436ffac
* glib/dbus-gproxy.c (dbus_g_proxy_emit_remote_signal): Don't spew warnings if we get malformed remote signals. * glib/dbus-gobject.c (propsig_iterate): New function. (lookup_object_info): New function, extracted from lookup_object_and_method. (introspect_properties, introspect_signals): Delete; these are merged into write_interface. (write_interface): Write out signals and properties here; dump the org.gtk.object stuff and use the interface given in the introspection data blob. Also fix up property XML. (lookup_values): New function. (introspect_interfaces): Gather a mapping from interface to a list of its methods, signals, and properties, then write out each interface. (lookup_object_and_method): Use lookup_object_info. (struct DBusGSignalClosure): Add interface. (dbus_g_signal_closure_new): Add interface. Don't dup signame; we can just use the constant data. (dbus_g_signal_closure_finalize): Don't free signal name. (signal_emitter_marshaller): Use interface from signal closure. (export_signals): Only export signals mentioned in introspection blob. (dbus_g_connection_register_g_object): Warn if we have no introspection data for an object. (funcsig_equal): Remove unused variable. (dbus_g_object_register_marshaller): Take varargs instead of list. (dbus_g_object_register_marshaller_array): New function, extracted from old dbus_g_object_register_marshaller. * glib/dbus-binding-tool-glib.c (struct DBusBindingToolCData): Add signals and property data. (write_quoted_string): New function, extracted from generate_glue. (generate_glue): Write signals and properties to introspection blob. * dbus/dbus-glib.h (struct DBusGObjectInfo): Include exported_signals and exported_properties. (dbus_g_object_register_marshaller): Update prototype. (dbus_g_object_register_marshaller_array): Prototype. * test/glib/test-dbus-glib.c: Extend testing to cover new signals. * test/glib/test-service-glib.c: Add new test signals and method to emit them. * test/glib/test-service-glib.xml: Add some test signals. * test/glib/Makefile.am (BUILT_SOURCES): Add my-object-marshal.c and my-object-marshal.h (test_service_glib_SOURCES, test_dbus_glib_SOURCES): Add my-object-marshal.c. (my-object-marshal.c, my-object-marshal.h): Implement. * test/glib/.cvsignore: Update. * doc/TODO: Remove two GLib TODO items fixed by this patch.
122 lines
4.8 KiB
Text
122 lines
4.8 KiB
Text
Important for 1.0
|
|
===
|
|
|
|
- Remove all deprecated functions
|
|
|
|
- Audit @todo and FIXME for security issues
|
|
|
|
- the "break loader" and valid/invalid message tests are all disabled;
|
|
they need to be fixed and re-enabled with the new message args stuff.
|
|
I think I want to drop the .message files thing and just have code
|
|
that generates messages, more like the tests for
|
|
dbus-marshal-recursive.c (this is mostly done now, just needs some
|
|
cleanup)
|
|
|
|
- need to define bus behavior if you send a message to
|
|
yourself; is it an error, or allowed? If allowed,
|
|
we need to have a test for it in the test suite.
|
|
|
|
- just before 1.0, try a HAVE_INT64=0 build and be sure it runs
|
|
|
|
- dbus-pending-call.c has some API and thread safety issues to review
|
|
|
|
- Add test harness for selinux allow/deny cf. this message
|
|
http://lists.freedesktop.org/archives/dbus/2005-April/002506.html
|
|
|
|
- Add a test case for handling the Ping message
|
|
|
|
Important for 1.0 GLib Bindings
|
|
===
|
|
|
|
- Annotations for "do not take ownership of this return value" on server
|
|
|
|
- Fix TYPE_OBJECT_PATH marshalling; see:
|
|
http://lists.freedesktop.org/archives/dbus/2005-June/002774.html
|
|
|
|
- Fix errors - need to get specific error back, not UnmappedError crap
|
|
|
|
- DBusGProxy doesn't emit "destroy" when it should
|
|
|
|
Might as Well for 1.0
|
|
===
|
|
|
|
- protocol version in each message is pretty silly
|
|
|
|
Can Be Post 1.0
|
|
===
|
|
|
|
- if the GUID is obtained only during authentication, not in the address,
|
|
we could still share the connection
|
|
|
|
- Allow a dbus_g_proxy_to_string()/g_object_to_string() that
|
|
would convert the proxy to an "IOR" and dbus_g_proxy_from_string()
|
|
that would decode; using these, dbus-glib users could avoid
|
|
DBusConnection entirely. Of course the same applies to other kinds
|
|
of binding. This would use dbus_connection_open()'s connection-sharing
|
|
feature to avoid massive proliferation of connections.
|
|
|
|
- DBusWatchList/TimeoutList duplicate a lot of code, as do
|
|
protected_change_watch/protected_change_timeout in dbus-connection.c
|
|
and dbus-server.c. This could all be mopped up, cut-and-paste
|
|
fixed, code size reduced.
|
|
|
|
- change .service files to allow Names=list in addition to Name=string
|
|
|
|
- The message bus internal code still says "service" for
|
|
"name", "base service" for "unique name", "activate" for
|
|
"start"; would be nice to clean up.
|
|
|
|
- Property list feature on message bus (list of properties associated
|
|
with a connection). May also include message matching rules
|
|
that involve the properties of the source or destination
|
|
connection.
|
|
|
|
- Disconnecting the remote end on invalid UTF-8 is probably not a good
|
|
idea. The definition of "valid" is slightly fuzzy. I think it might
|
|
be better to just silently "fix" the UTF-8, or perhaps return an error.
|
|
|
|
- build and install the Doxygen manual in Makefile when --enable-docs
|
|
|
|
- if you send the same message to multiple connections, the serial number
|
|
will only be right for one of them. Probably need to just write() the serial
|
|
number, rather than putting it in the DBusMessage, or something.
|
|
|
|
- perhaps the bus driver should have properties that reflect attributes
|
|
of the session, such as hostname, architecture, operating system,
|
|
etc. Could be useful for code that wants to special-case behavior
|
|
for a particular host or class of hosts, for example.
|
|
|
|
- currently the security policy stuff for messages to/from
|
|
the bus driver is kind of strange; basically it's hardcoded that
|
|
you can always talk to the driver, but the default config file
|
|
has rules for it anyway, or something. it's conceptually
|
|
screwy at the moment.
|
|
|
|
- when making a method call, if the call serial were globally unique,
|
|
we could forward the call serial along with any method calls made
|
|
as a result of the first method call, and allow reentrancy that was
|
|
strictly part of the call stack of said method call. But I don't
|
|
really see how to do this without making the user pass around the
|
|
call serial to all method calls all the time, or disallowing
|
|
async calls.
|
|
|
|
If done post 1.0 will probably be an optional/ugly-API type
|
|
of thing.
|
|
|
|
- I don't want to introduce DBusObject, but refcounting and object
|
|
data could still be factored out into an internal "base class"
|
|
perhaps.
|
|
|
|
- document the auth protocol as a set of states and transitions, and
|
|
then reimplement it in those terms
|
|
|
|
- recursive dispatch, see dbus_connection_dispatch()
|
|
|
|
- do we need per-display activation; if so I'd like to do this by setting a
|
|
"display ID" property on screen 0, with a GUID, and keying activation by
|
|
said GUID. Otherwise you get all kinds of unrobust
|
|
string/hostname-based mess. per-screen is then done by appending screen number
|
|
to the display. If displays have a deterministic ID like this, you can
|
|
do per-display by simply including GUID in the service name.
|
|
|
|
- optimization and profiling!
|