mirror of
https://gitlab.freedesktop.org/dbus/dbus.git
synced 2026-01-03 04:30:12 +01:00
46c072e113
* doc/dbus-specification.sgml: don't require header fields to be 4-byte aligned and specify that fields should be distinguished from padding by the fact that zero is not a valid field name. * doc/TODO: remove re-alignment item and add item to doc the OBJECT_PATH type. * dbus/dbus-message.c: (HeaderField): rename the original member to value_offset and introduce a name_offset member to keep track of where the field actually begins. (adjust_field_offsets): remove. (append_int_field), (append_uint_field), (append_string_field): don't align the start of the header field to a 4-byte boundary. (get_next_field): impl finding the next marhsalled field after a given field. (re_align_field_recurse): impl re-aligning a number of already marshalled fields. (delete_field): impl deleting a field of any type and re-aligning any following fields. (delete_int_or_uint_field), (delete_string_field): remove. (set_int_field), (set_uint_field): no need to re-check that we have the correct type for the field. (set_string_field): ditto and impl re-aligning any following fields. (decode_header_data): update to take into account that the fields aren't 4-byte aligned any more and the new way to distinguish padding from header fields. Also, don't exit when there is too much header padding. (process_test_subdir): print the directory. (_dbus_message_test): add test to make sure a following field is re-aligned correctly after field deletion. * dbus/dbus-string.[ch]: (_dbus_string_insert_bytes): rename from insert_byte and allow the insert of multiple bytes. (_dbus_string_test): test inserting multiple bytes. * dbus/dbus-marshal.c: (_dbus_marshal_set_string): add warning note to docs about having to re-align any marshalled values following the string. * dbus/dbus-message-builder.c: (append_string_field), (_dbus_message_data_load): don't align the header field. * dbus/dbus-auth.c: (process_test_subdir): print the directory. * test/break-loader.c: (randomly_add_one_byte): upd. for insert_byte change. * test/data/invalid-messages/bad-header-field-alignment.message: new test case. * test/data/valid-messages/unknown-header-field.message: shove a dict in the unknown field.
95 lines
4.2 KiB
Text
95 lines
4.2 KiB
Text
|
|
- Message matching rules (so broadcasts can be filtered) need sorting
|
|
out.
|
|
|
|
- How we will handle DCOP needs sorting out. Among other things, we
|
|
need to check that service and service-ownership semantics map to DCOP
|
|
reasonably well.
|
|
|
|
- Activation needs some careful additional thinking-through.
|
|
|
|
- Property list feature on message bus (list of properties associated
|
|
with a connection). May also include message matching rules
|
|
that involve the properties of the source or destination
|
|
connection.
|
|
|
|
- Automatic service activation, should probably be done through a message flag.
|
|
|
|
- Disconnecting the remote end on invalid UTF-8 is probably not a good
|
|
idea. The definitiion of "valid" is slightly fuzzy. I think it might
|
|
be better to just silently "fix" the UTF-8, or perhaps return an error.
|
|
|
|
Owen says we should only validate the UTF-8 on dbus_message_get_string()
|
|
(changing get_string to have an error return, and allowing a type error
|
|
as a possible return)
|
|
|
|
- The convenience functions in dbus-bus.h should perhaps have
|
|
the signatures that they would have if they were autogenerated
|
|
stubs. e.g. the acquire service function. We should also evaluate
|
|
which of these functions to include, in light of the fact that
|
|
GLib/Qt native stubs will probably also exist.
|
|
|
|
- The message handler interface needs rethinking, perhaps handlers should be able
|
|
to return an error that automatically gets turned into a message; most likely
|
|
some basic spec'ing out of the GLib/Qt level stubs/skels stuff will be
|
|
needed to understand the right approach.
|
|
|
|
- there are various bits of code to manage ref/unref of data slots, that should
|
|
be merged into a generic facility
|
|
|
|
- assorted _-prefixed symbols in libdbus aren't actually used by
|
|
libdbus, only by the message bus. These bloat up the library
|
|
size. Not sure how to fix, really.
|
|
|
|
- if you send a message to a service then block for reply, and the service exits/crashes
|
|
after the message bus has processed your message but before the service has replied,
|
|
it would be nice if the message bus sent you an error reply.
|
|
|
|
- write a DTD for the dbus-daemon-1 configuration file
|
|
|
|
- build and install the Doxygen manual in Makefile when --enable-docs
|
|
|
|
- if you send the same message to multiple connections, the serial number
|
|
will only be right for one of them. Probably need to just write() the serial
|
|
number, rather than putting it in the DBusMessage, or something.
|
|
|
|
- perhaps the bus driver should have properties that reflect attributes
|
|
of the session, such as hostname, architecture, operating system,
|
|
etc. Could be useful for code that wants to special-case behavior
|
|
for a particular host or class of hosts, for example.
|
|
|
|
- currently the security policy stuff for messages to/from
|
|
the bus driver is kind of strange; basically it's hardcoded that
|
|
you can always talk to the driver, but the default config file
|
|
has rules for it anyway, or something. it's conceptually
|
|
screwy at the moment.
|
|
|
|
- <limit> elements are not merged in from included configuration
|
|
files; they have to be in the toplevel file. when loading
|
|
a child file, we could just init its DBusLimits from the parent,
|
|
then after parsing copy its DBusLimits back to the parent
|
|
|
|
- when making a method call, if the call serial were globally unique,
|
|
we could forward the call serial along with any method calls made
|
|
as a result of the first method call, and allow reentrancy that was
|
|
strictly part of the call stack of said method call. But I don't
|
|
really see how to do this without making the user pass around the
|
|
call serial to all method calls all the time, or disallowing
|
|
async calls.
|
|
|
|
- the invalid messages in the test suite are all useless because
|
|
they are invalid for the wrong reasons due to protocol changes
|
|
|
|
- I don't want to introduce DBusObject, but refcounting and object
|
|
data could still be factored out into an internal "base class"
|
|
perhaps.
|
|
|
|
- modify the auth protocol to also support other initial-handshake
|
|
type of information
|
|
|
|
- document the auth protocol as a set of states and transitions, and
|
|
then reimplement it in those terms
|
|
|
|
- dbus_gproxy or dbus_g_proxy?
|
|
|
|
- The OBJECT_PATH type is not documented in the spec.
|