Commit graph

2109 commits

Author SHA1 Message Date
Havoc Pennington
bef4260ad5 Fix a problem where a nul byte was wrongly introduced into UUIDs, due to _dbus_string_copy_to_buffer weird behavior.
2007-10-31  Havoc Pennington  <hp@redhat.com>

	* bus/selinux.c (log_audit_callback): rewrite to use
	_dbus_string_copy_to_buffer_with_nul()

	* dbus/dbus-string.c (_dbus_string_copy_to_buffer): change to NOT
	nul-terminate the buffer; fail an assertion if there is not enough
	space in the target buffer. This fixes two bugs where
	copy_to_buffer was used to copy the binary bytes in a UUID, where
	nul termination did not make sense. Bug reported by David Castelow.
	(_dbus_string_copy_to_buffer_with_nul): new function that always
	nul-terminates the buffer, and fails an assertion if there is not
	enough space in the buffer.
2007-10-31 13:58:28 -04:00
Havoc Pennington
5340b8de0b audit_init() was not declared in header, causing warnings; fix this and namespace it
2007-10-23  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): use the new name here

	* bus/selinux.c (bus_selinux_audit_init): rename from audit_init()
	to avoid possible libc conflict, and declare it in .h file to
	avoid a warning
2007-10-23 14:48:52 -04:00
Havoc Pennington
a8e32b6874 add HAVE_SELINUX around call to audit_init() so things build without selinux
2007-10-19  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): put audit_init() in HAVE_SELINUX
2007-10-19 17:20:06 -04:00
Havoc Pennington
53f6713976 do not call audit_init() from bus/ directory from files in dbus/
2007-10-19  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): put the audit_init() in here
	instead, which I believe ends up being the same as where it was
	before, though I'm not sure I understand why it goes here.

	* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user):
	remove audit_init() from here, this file can't depend on code in
	bus/ directory
2007-10-19 15:05:27 -04:00
Simon McVittie
71a357de56 configure.in: *Actually* fix detection of i486 atomic ops.
My previous attempt at a fix would always enable them due to wrong quoting.
Patch from Colin Walters <walters@verbum.org>
2007-10-16 10:13:15 +01:00
Simon McVittie
23bcdd7394 Amend ChangeLog - DBUS_ERROR_INIT is now used within libdbus as well as provided 2007-10-11 17:29:40 +01:00
Simon McVittie
f55897af74 Use DBUS_ERROR_INIT instead of dbus_error_init wherever it's clearly equivalent 2007-10-11 17:26:30 +01:00
Simon McVittie
e54d56b7b2 Merge branch 'inline' 2007-10-11 17:24:18 +01:00
Simon McVittie
d229e579a3 Merge branch 'atomic'
Conflicts:

	ChangeLog
2007-10-11 17:24:16 +01:00
Simon McVittie
48ad73fd5b Add J5's recent changes to ChangeLog 2007-10-11 10:56:12 +01:00
Simon McVittie
ecc4a25ed2 Update ChangeLog 2007-10-11 10:38:01 +01:00
Simon McVittie
a18ebe81bd Rename DBUS_ERROR_INITIALIZER to DBUS_ERROR_INIT per Havoc's review 2007-10-11 10:35:35 +01:00
Simon McVittie
262c02a9fa Add DBUS_ERROR_INITIALIZER macro 2007-10-11 10:35:25 +01:00
Simon McVittie
902beb7c2c Enable Autoconf's AC_C_INLINE to avoid compilation failure with gcc -ansi.
If inline isn't recognised (e.g. on a strict C90 compiler, like gcc -ansi) this
defines it to __inline__, __inline or nothing, whichever works. This is safe,
because we never use inline except in combination with static.
2007-10-11 10:27:28 +01:00
Simon McVittie
559de12aac Update ChangeLog 2007-10-11 10:20:09 +01:00
Simon McVittie
b6cd08a897 .gitignore: ignore vi swapfiles 2007-10-11 10:18:05 +01:00
Simon McVittie
35b00e3ab2 dbus-launch: convert C++-style comment to C-style, add {} for clarity 2007-10-11 10:17:17 +01:00
Simon McVittie
cc321d4ab3 dbus/dbus-server-socket.c: remove unused variable if disabling assertions 2007-10-11 10:17:05 +01:00
Simon McVittie
2349aa6d71 dbus/dbus-marshal-validate.c: get rid of empty statements 2007-10-11 10:16:56 +01:00
Simon McVittie
5fcdebe595 As per Havoc's review, rename DBUS_GNUC_EXTENSION to _DBUS_GNUC_EXTENSION.
Also update ChangeLog.
2007-10-11 10:11:21 +01:00
Simon McVittie
fd08741f27 dbus/dbus-arch-deps.h.in: also use DBUS_GNUC_EXTENSION for DBUS_INT64_CONSTANT and UINT64 equivalent 2007-10-11 10:07:02 +01:00
Simon McVittie
a2eace3a8b Use DBUS_GNUC_EXTENSION to avoid -ansi -pedantic warnings about use of long long. (#717) 2007-10-11 10:06:54 +01:00
Simon McVittie
6b512e4ee7 Add macro DBUS_GNUC_EXTENSION (the same as GLib's G_GNUC_EXTENSION)
Part of a fix for bug 717.
2007-10-11 10:06:45 +01:00
Simon McVittie
176738f0f0 Fix detection of i486 atomic ops.
Previously, the attempts to determine support at compile-time on Darwin were
causing the i486 atomic ops to be used on *all* i386 or x86-64 GCC builds
(AH_VERBATIM can't be conditionalized like we were trying to).
2007-10-11 09:57:48 +01:00
Simon McVittie
077fb290c5 Merge branch 'master' of ssh://git.freedesktop.org/git/dbus/dbus 2007-10-10 17:39:41 +01:00
Simon McVittie
8cff9309bf Update ChangeLog 2007-10-10 17:39:12 +01:00
Simon McVittie
9f22c3e1e8 Bring .gitignore files up to date; add *.o, *~ etc. to top-level .gitignore
CVS ignores these automatically, so they weren't in the .cvsignore when Ryan
converted the repository.
2007-10-10 17:38:00 +01:00
Simon McVittie
dfaca06084 Fix indentation in _dbus_object_tree_register declaration as per Havoc's review 2007-10-10 17:33:57 +01:00
Simon McVittie
df47bd4081 _dbus_object_tree_register: don't duplicate check for NULL and use new DBUS_ERROR_OBJECT_PATH_IN_USE error, both as per Havoc's review 2007-10-10 17:33:40 +01:00
Simon McVittie
d7fbcb5e02 Add error o.fd.D.Error.ObjectPathInUse (DBUS_ERROR_OBJECT_PATH_IN_USE) 2007-10-10 17:33:31 +01:00
Simon McVittie
557da17406 Add dbus_connection_try_register_object_path and dbus_connection_try_register_fallback, to make object path registration less painful for bindings 2007-10-10 17:33:18 +01:00
John (J5) Palmieri
1ca4b10e30 Fix env exports for better portability (#9280) 2007-10-09 15:50:08 -04:00
John (J5) Palmieri
f4ebd3a876 Document syntax for container types in dbus-send man file (#9553)
* Patch from Jack Spaar <jspaar at users.sourceforge.net>
2007-10-09 15:27:53 -04:00
Simon McVittie
1a5ef4003d Improve description of allowed variant signatures (#10185)
Patch based on one from Kristoffer Lundén, amended as per Havoc's comment.
2007-10-09 14:23:28 +01:00
Simon McVittie
fafd784424 doc/dbus-specification.xml: Clarify description of DBUS_COOKIE_SHA1 (#10184).
Patch from Kristoffer Lundén.
2007-10-09 14:12:31 +01:00
Simon McVittie
3212c450bb Merge branch 'master' of ssh://git.freedesktop.org/git/dbus/dbus 2007-10-09 14:06:54 +01:00
Simon McVittie
bf7c65f521 doc/dbus-specification.xml: Specifically forbid empty structs (#7969) 2007-10-09 14:06:35 +01:00
John (J5) Palmieri
79aafc1931 fd.o bug #11678 Don't error out if compiler does not support vararg macros
* _dbus_verbose is the only function that does this so make it a noop if
  vararg macros are not supported
* https://bugs.freedesktop.org/show_bug.cgi?id=11678
2007-10-03 17:54:09 -04:00
John (J5) Palmieri
09aa69e015 fd.o bug #12429 Reverse check to setpcap and only init audit if we were root
* patch by Dan Walsh <dwalsh@redhat.com>
* https://bugs.freedesktop.org/show_bug.cgi?id=12429
* Reverse we_were_root check to setpcap if we were root.  Also only init
  audit if we were root.  So error dbus message will not show up when policy
  reload happens.  dbus -session will no longer try to send audit message,
  only system will.
2007-10-03 17:29:45 -04:00
John (J5) Palmieri
a295b2e66c fd.o bug #11872 improve linker test for --gc-sections
* patch by Tim Mooney <enchanter at users.sourceforge.net>
2007-10-03 17:08:44 -04:00
John (J5) Palmieri
adb0270edf fd.o bug #11872 fix clearenv for systems that do not have it
* patch from Brian Cameron <brian.cameron at sun.com>
2007-10-03 17:02:23 -04:00
John (J5) Palmieri
7d9d3fc031 fd.o bug #12547 remove superfluous if
* also convert tabs to spaces
2007-10-03 16:43:22 -04:00
John (J5) Palmieri
8a92100bbe Correctly implement -fPIC and -fPIE
* For security reasons we want possition independent code for libraries
  and possition independent executable for executables
* before we were just enabling -fPIC
* now we correctly enable -fPIC and -PIE for libdbus and the bus respectively
* propper LD_FLAGS are set for each also
2007-10-03 15:21:57 -04:00
Ryan Lortie
f6ec4a80ab Add argument path matching support. Bug #11066.
2007-09-20  Ryan Lortie  <desrt@desrt.ca>

        * dbus/signals.c (struct DBusMatchRule, bus_match_rule_new,
        bus_match_rule_set_arg, bus_match_rule_parse_arg_match,
        match_rule_matches): Add support for parsing and matching on
        arg0path='/some/path' type rules.

        * dbus/signals.h (bus_match_rule_set_arg): change to take const
        DBusString instead of const char * for the string to match against.

        * dbus/dbus-bus.c: add a quick note to dbus_bus_add_match
        documentation about the path matching.

        * doc/dbus-specification.xml: add a more detailed description of the
        changes here.
2007-09-20 13:04:38 -04:00
Ryan Lortie
8c6b0ab3f7 Add support for compacting DBusStrings to release wasted memory.
2007-09-19  Ryan Lortie  <desrt@desrt.ca>

        * dbus/dbus-string.[ch] (compact, _dbus_string_compact,
        _dbus_string_lock): new compact function to free up allocated memory
        that is no longer used.

        * dbus/dbus-message.c (load_message): call _dbus_string_compact on the
        message loader buffer.

        * dbus/dbus-transport-socket.c (do_reading, do_writing): call
        _dbus_string_compact on the incoming/outgoing "encoded" buffers.

        * dbus/dbus-string-util.c (_dbus_string_test): add a few tests for
        string compacting.
2007-09-20 00:13:35 -04:00
Ryan Lortie
44ed90c10d HACKING: add more explicit git branch/tag instructions 2007-09-13 12:42:32 -04:00
Ryan Lortie
d34905d811 migrate from cvs to git (cvs2svn -> git-svnimport).
2007-09-13  Ryan Lortie  <desrt@desrt.ca>

        migrate from cvs to git (cvs2svn -> git-svnimport).

        * HACKING: update release/branch/tag instructions
        * */.cvsignore: rename to .gitignore

        also, clean up tags and branch names to conform to HACKING
2007-09-13 11:13:40 -04:00
Havoc Pennington
d4e511a724 2007-08-17 William Jon McCann <mccann@jhu.edu>
* update-dbus-docs.sh: upload DTD to server
2007-08-17 18:51:41 +00:00
Havoc Pennington
163555c7ab 2007-08-17 Havoc Pennington <hp@redhat.com>
* tools/dbus-launch-x11.c (set_address_in_x11): fix from Michael
	Lorenz to use long not int with XChangeProperty format 32

	* dbus/dbus-sysdeps-util-unix.c
	(_dbus_write_pid_to_file_and_pipe): factor this out, and use the
	same code in _dbus_become_daemon (where the parent writes the pid
	file and to the pid pipe) and in bus_context_new (where the daemon
	writes its own pid file and to its own pid pipe)

	* bus/bus.c (bus_context_new): close the pid pipe after we print
	to it. Also, don't write the pid to the pipe twice when we fork,
	someone reported this bug a long time ago.
2007-08-17 16:43:57 +00:00
Havoc Pennington
d9f2438806 2007-08-03 Havoc Pennington <hp@redhat.com>
* configure.in: add major/minor/micro version number AC_SUBST

	* dbus/dbus-arch-deps.h.in (DBUS_MAJOR_VERSION,
	DBUS_MINOR_VERSION, DBUS_MICRO_VERSION, DBUS_VERSION_STRING,
	DBUS_VERSION): collection of macros to get version of library we
	are compiled against.

	* dbus/dbus-misc.c (dbus_get_version): new function, to get
	version of library we are linked against at runtime.
2007-08-03 19:05:29 +00:00