Commit graph

1525 commits

Author SHA1 Message Date
John (J5) Palmieri
eead418b24 take out trailing comma inside an enum so non gcc compilers don't error out
* tools/dbus-monitor.c: take out the trailing comma in the
  ProfileAttributeFlags enum as it isn't in our style guides and causes
  some compilers to error out
2008-04-16 10:49:25 -04:00
John (J5) Palmieri
b4cbb84fe0 getting ready for 1.2 stable branch
* ChangeLog.pre-1-2: rename ChangeLog
* NEWS.pre-1-2: rename NEWS
* Makefile.am: list the pre files in EXTRA_DIST; the pre-1-0 files had not
  been added yet so do that too
2008-04-04 15:37:50 -04:00
John (J5) Palmieri
ef96f66e3b Released 1.2.1 2008-04-04 15:24:46 -04:00
John (J5) Palmieri
d7446ac003 Revert "fix dbus-send so it can correctly send dictionaries"
This reverts commit a689ef29f1.

Conflicts:

	ChangeLog

* Turns out I reversed a patch that was alread committed but the bug had not
  been closed.  Since the patch was applied before I also reverted the
  mention of Jérémie in the AUTHORS list mainly for license book keeping
  sanity.
2008-04-04 14:58:07 -04:00
John (J5) Palmieri
ca87b90981 fix memleak due to autolaunch and recursive calls to _dbus_open_transport
* Patch from Sumit <sumitskj_20@yahoo.com>, comments added

* dbus/dbus-transport.c(_dbus_transport_open): fix mem leak
2008-04-03 16:08:40 -04:00
John (J5) Palmieri
b5818e619f modify dbus_connection_send documentation
* dbus/dbus-connection.c (dbus_connection_send): add documentation
  to describe when to call dbus_connection_flush and
  dbus_connection_unref after a call to dbus_connection_send is made
  Initial wording by Stanislav Brabec <sbrabec at suse.cz>
  (fd.o bug#13558)
2008-04-03 13:15:45 -04:00
Jérémie Dimino
a689ef29f1 fix dbus-send so it can correctly send dictionaries
* tools/dbus-send.c (append_dict): Send in signature when opening up
  a dict entry container

* AUTHORS: Add Jérémie to AUTHORS file since it was a slightly above
  trivial fix
2008-04-03 11:32:09 -04:00
Kimmo Hämäläinen
7c4b345802 fix expiration of pending replies
* bus/expirelist.c
  (do_expiration_with_current_time): calculate correct min wait time
  and next interval
  (bus_expire_list_add, bus_expire_list_add_link): if the timeout is
  disabled when we add an item to the expire list, enable the timeout
  (do_expiration_with_current_time): only set timeout if there are
  items to expire
2008-04-03 11:12:27 -04:00
John (J5) Palmieri
960fef844b Merge branch 'master' of git+ssh://johnp@git.freedesktop.org/git/dbus/dbus
Conflicts:

	ChangeLog
2008-04-03 11:11:19 -04:00
Frederic Crozat
68f69d3818 Fixes for the inotify configuration file monitor backend.
2008-04-01  Timo Hoenig  <thoenig@suse.de>

Patch from Frederic Crozat <fcrozat@mandriva.com>

* bus/dir-watch-inotify.c (bus_watch_directory): Only monitor
  IN_CLOSE_WRITE, IN_DELETE, IN_MOVE_TO and IN_MOVE_FROM events. This
  way, only atomic changes to configuration file are monitored.
* bus/dir-watch-inotify.c (_handle_inotify_watch): Fix typo in
  _dbus_verbose function call
* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): Use
  _dbus_strerror instead of perror
2008-04-01 18:09:46 +02:00
Colin Walters
0bfc5e8d23 Check for X11 events before selecting (FDO bug #15293) 2008-03-31 18:20:07 -04:00
Colin Walters
193ebb7083 Make sure we call XFlush() on all code paths (FDO bug #15293) 2008-03-31 18:16:00 -04:00
Havoc Pennington
4058579dae Do not provide a signature to dbus_message_iter_open_container() when opening a dict entry.
2008-03-27  Havoc Pennington  <hp@redhat.com>

	* tools/dbus-send.c (append_dict): Do not provide a signature to
	dbus_message_iter_open_container() when opening a dict entry.
2008-03-27 16:52:40 -04:00
Colin Walters
52ea0f2cbb Set default exit_on_disconnect after registration
2008-03-26  Colin Walters  <walters@verbum.org>
	Patch from Scott James Remnant <scott@netsplit.com>

	* dbus/dbus-bus.c: Set default exit_on_disconnect after registration with
	the bus, not before.  This ensures that programs which wish to set
	exit_on_disconnect to FALSE will not be terminated if the bus exits
	during registration.  (FDO Bug #15112)
2008-03-26 10:28:40 -04:00
Havoc Pennington
a37404111b Make BusExpireList an opaque data type
2007-11-08  Havoc Pennington  <hp@redhat.com>

	* bus/connection.c, bus/expirelist.c: Make the BusExpireList
	struct opaque, adding accessors for manipulating the list. In this
	commit there should be no change in functionality or behavior. The
	purpose of this change is to improve encapsulation prior to fixing
	some bugs Kimmo Hämäläinen found where the timeout is not properly
	updated, since we need to e.g. take some action whenever adding
	and removing stuff from the expire list.
2008-03-04 14:21:42 -05:00
John (J5) Palmieri
d25151483f fix broken poll on Mac OSX - build patch by Benjamin Reed
* configure.in: check for OSX's deadlocking poll
* dbus/dbus-sysdeps-unix.c (_dbus_poll): if we have a broken poll
  don't use poll
2008-03-04 13:21:05 -05:00
John (J5) Palmieri
bd561f9a19 check if the linker supports a flag instead of just checking for GNU ld
* configure.in: move AM_PROG_LIBTOOL to the top
  (ld_supports_flag): new function for checking if the linker supports
  a given flag
2008-03-04 13:09:07 -05:00
John (J5) Palmieri
d511324fff add a changelog for Benjamin Reed's git patch (OS X build fixes)
* configure.in: Platform build fixes for Mac OS X
  the Darwin linker does not understand the -z option; wrap it in
  a check for $with_gnu_ld.
  environ is only available at runtime, so you need to make a
  reference to _NSGetEnviron instead for symbols to resolve properly.
2008-03-04 13:07:38 -05:00
John (J5) Palmieri
9f48c74cb6 configure.in: add $THREAD_LIBS to DBUS_LAUNCHER_LIBS so we link correctly 2008-03-04 10:12:57 -05:00
John (J5) Palmieri
46b48ac654 tools/dbus-launch.c: wrap X'ism in #ifdef so we can compile without X 2008-03-04 10:03:14 -05:00
John (J5) Palmieri
3250072c6e define _AI_ADDRCONFIG if not defined so that we can compile with an older glibc 2008-02-28 13:18:03 -05:00
John (J5) Palmieri
c0f7ba8d23 Released 1.1.20 2008-02-26 13:37:48 -05:00
John (J5) Palmieri
6db561dce2 CVE-2008-0595 dbus security policy circumvention
* CVE-2008-0595 - security policy of the type <allow send_interface=
  "some.interface.WithMethods"/> work as an implicit allow for
  messages sent without an interface bypassing the default deny rules
  and potentially allowing restricted methods exported on the bus to be
  executed by unauthorized users.  This patch fixes the issue.
* bus/policy.c (bus_client_policy_check_can_send,
  bus_client_policy_check_can_receive): skip messages without an
  interface when evaluating an allow rule, and thus pass it to the
  default deny rules
2008-02-26 13:30:47 -05:00
John (J5) Palmieri
381c8548b2 correctly unref connections without guids during shutdown
* dbus/dbus-connection.c (close_connection_on_shutdown): new method
  split out from shared_connections_shutdown
  (shared_connections_shutdown): shutdown all shared connections
  without guids
  (_dbus_connection_ref_unlocked): handle OOM when prepending no guid
  connections to the shared_connections_no_guid list
* Patch by  Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>
2008-02-26 10:35:56 -05:00
John (J5) Palmieri
be8750940b fix build against the latest gcc/glibc
* dbus/dbus-sysdeps-unix.c: define _GNU_SOURCE
* bus/selinux.c: include limits.h
* Patch by Matthias Clasen <mclasen at redhat.com>
2008-02-21 13:42:06 -05:00
John (J5) Palmieri
7d409700c3 fixes dbus-launch so the bus goes away when X does (Red Hat Bug #430412)
* tools/dbus-launch.c (main): set xdisplay = NULL
* Patch by Matthias Clasen <mclasen at redhat.com>
+
2008-02-21 12:02:58 -05:00
John (J5) Palmieri
b1b4017980 Release 1.1.4(1.2.0RC2) 2008-01-17 15:20:25 -05:00
John (J5) Palmieri
e1821fc35a fix inotify support
2008-01-17  Timo Hoenig  <thoenig@suse.de>
	* fix inotify support
	* bus/dir-watch-inotify.c (_handle_inotify_watch): fix reading of the
	inotify events. Also, use ssize_t not size_t for 'ret'.
	* bus/dir-watch-inotify.c (bus_watch_directory): watch not only for
	IN_MODIFY but also for IN_CREATE and IN_DELETE
	* bus/dir-watch-inotify.c (bus_drop_all_directory_watches): drop the
	inotify watches more elegantly by closing inotify:_fd, set inotify_fd to
	-1 after dropping the watches
2008-01-17 14:57:47 -05:00
John (J5) Palmieri
9311dea540 post-release version bump 2008-01-15 19:54:46 -05:00
John (J5) Palmieri
e42caf6a34 Released 1.1.3 (1.2.0RC1) 2008-01-15 19:52:40 -05:00
John (J5) Palmieri
fae808d6fe fix HACKING to say git instead of cvs 2008-01-15 18:35:41 -05:00
John (J5) Palmieri
e113a70b56 wrap all_reader_classes[] in #ifndef DBUS_DISABLE_ASSERT (FDO Bug #9030)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Sébastien Couret <10function at gmail dot com>

	* dbus/dbus-marshal-recursive.c (all_reader_classes[]): wrap in
	#ifndef DBUS_DISABLE_ASSERT since it is only used in asserts which
	are noop
2008-01-15 18:10:50 -05:00
John (J5) Palmieri
7ef60319c7 handle SASL EXTERNAL's inital empty responce (FDO Bug #9945)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Magnus Henoch <henoch plus bfdo at dtek dot chalmers dot se>

	* dbus/dbus-auth.c (handle_server_data_external_mech): handle SASL
	EXTERNAL's inital empty responce (FDO Bug #9945)
2008-01-15 17:21:52 -05:00
John (J5) Palmieri
71c2677086 add lsb headers to init script (FDO Bug #11491)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* bus/messagebus.in: add lsb headers (FDO Bug #11491)
2008-01-15 16:58:36 -05:00
John (J5) Palmieri
6cfcabbc00 check write return value so we don't hang (FDO Bug #11665)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Peter O'Gorman <pogma at thewrittenword dot com>

	* dbus/dbus-spawn.c (babysit_signal_handler): check write return value
	so we don't hang (FDO Bug #11665)
2008-01-15 16:51:30 -05:00
John (J5) Palmieri
c0910a0bda support for AIX poll implementation (FDO Bug #11666)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Peter O'Gorman <pogma at thewrittenword dot com>

	* dbus/dbus-sysdeps.h: support for AIX poll implementation (FDO Bug
	#11666)
2008-01-15 16:43:46 -05:00
John (J5) Palmieri
94bc113117 make shell script more portable (FDO Bug #11667)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* tests/name-test/run-test.sh: make more portable (FDO Bug #11667)
2008-01-15 16:23:54 -05:00
John (J5) Palmieri
738743002d don't check for < 0 on an unsigned variable (FDO Bug #12924)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-connection.c (_dbus_connection_get_next_client_serial):
	don't check for < 0 on an unsigned variable (FDO Bug #12924)
2008-01-15 15:57:34 -05:00
John (J5) Palmieri
4cc2bfa10e check failed allocation (FDO Bug #12920)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* bus/bus.c (setup_server): check failed allocation (FDO Bug #12920)
2008-01-15 15:49:35 -05:00
John (J5) Palmieri
7ba3dc8bf9 the API contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): the API
	contract says sitter_p can be NULL, so let's check it (FDO Bug #12919)
2008-01-15 15:45:20 -05:00
John (J5) Palmieri
c8a9cf8103 use correct ssize_t type instead of size_t (FDO Bug #12862)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-spawn.c (read_ints, read_pid): use correct ssize_t type
	instead of size_t (FDO Bug #12862)
2008-01-15 15:40:31 -05:00
John (J5) Palmieri
97872bf72f make sure to call va_end if we hit an OOM error inside va_start (FDO Bug #12846)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-errors.c (dbus_set_error): make sure to call va_end if we
	hit an OOM error inside va_start (FDO Bug #12846)
2008-01-15 15:30:19 -05:00
John (J5) Palmieri
1b64602017 fix possible crash if pending_return is NULL (FDO Bug #12673)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-connection.c (dbus_connection_send_with_reply):
	fix possible crash if pending_return is NULL (FDO Bug #12673)
2008-01-15 15:23:57 -05:00
John (J5) Palmieri
f44e259110 never auto-select libxml
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* portions of patch submitted by Tim Mooney
	<enchanter at users dot sourceforge dot net>

	* configure.in: never auto-select libxml (FDO Bug #12479)
2008-01-15 15:16:23 -05:00
John (J5) Palmieri
85d7a8e4d7 add OOM handling in various places
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patches by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-sysdeps-unix (_dbus_get_autolaunch_address): handle OOM
	(FDO Bug #12945)

	* dbus/dbus-uuidgen.c (return_uuid): handle OOM (FDO Bug #12928)

	* dbus/dbus-misc.c (dbus_get_local_machine_id): handle OOM, fix return
	value to return NULL not FALSE (FDO Bug #12946)
2008-01-15 14:43:19 -05:00
John (J5) Palmieri
9db435926f rewrite selinux error handling to not abort due to a NULL read
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* bus/bus.c (bus_context_check_security_policy): rewrite selinux error
	handling to not abort due to a NULL read and to set the error only if
	it is not already set (Based off of FDO Bug #12430)
2008-01-15 14:20:43 -05:00
John (J5) Palmieri
c18415e2c6 add OOM handling
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-internals.c (_dbus_read_uuid_file_without_creating,
	_dbus_create_uuid_file_exclusively): add OOM handling (FDO Bug #12952)
2008-01-15 13:53:54 -05:00
John (J5) Palmieri
a6a22beeae add error handling when polling (FDO Bug #12954)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-spawn.c (babysit, babysitter_iteration): add error
	handling when polling (FDO Bug #12954)
2008-01-15 13:46:50 -05:00
John (J5) Palmieri
f72bb380a6 remove dead code
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* bus/config-parser.c (locate_attributes): remove dead code which
	always evaluated to TRUE

	* dbus/dbus-shell.c (_dbus_shell_quote): remove unused code
2008-01-15 13:32:47 -05:00
John (J5) Palmieri
fec58d8d78 plug a possible BusClientPolicy leak (FDO Bug #13242)
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* bus/connection.c (bus_connection_complete): plug a possible
	BusClientPolicy leak (FDO Bug #13242)
2008-01-14 19:04:41 -05:00