Commit graph

1974 commits

Author SHA1 Message Date
John (J5) Palmieri
1b64602017 fix possible crash if pending_return is NULL (FDO Bug #12673)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-connection.c (dbus_connection_send_with_reply):
	fix possible crash if pending_return is NULL (FDO Bug #12673)
2008-01-15 15:23:57 -05:00
John (J5) Palmieri
f44e259110 never auto-select libxml
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* portions of patch submitted by Tim Mooney
	<enchanter at users dot sourceforge dot net>

	* configure.in: never auto-select libxml (FDO Bug #12479)
2008-01-15 15:16:23 -05:00
John (J5) Palmieri
85d7a8e4d7 add OOM handling in various places
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patches by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-sysdeps-unix (_dbus_get_autolaunch_address): handle OOM
	(FDO Bug #12945)

	* dbus/dbus-uuidgen.c (return_uuid): handle OOM (FDO Bug #12928)

	* dbus/dbus-misc.c (dbus_get_local_machine_id): handle OOM, fix return
	value to return NULL not FALSE (FDO Bug #12946)
2008-01-15 14:43:19 -05:00
John (J5) Palmieri
9db435926f rewrite selinux error handling to not abort due to a NULL read
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* bus/bus.c (bus_context_check_security_policy): rewrite selinux error
	handling to not abort due to a NULL read and to set the error only if
	it is not already set (Based off of FDO Bug #12430)
2008-01-15 14:20:43 -05:00
John (J5) Palmieri
c18415e2c6 add OOM handling
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-internals.c (_dbus_read_uuid_file_without_creating,
	_dbus_create_uuid_file_exclusively): add OOM handling (FDO Bug #12952)
2008-01-15 13:53:54 -05:00
John (J5) Palmieri
a6a22beeae add error handling when polling (FDO Bug #12954)
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-spawn.c (babysit, babysitter_iteration): add error
	handling when polling (FDO Bug #12954)
2008-01-15 13:46:50 -05:00
John (J5) Palmieri
f72bb380a6 remove dead code
2008-01-15  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* bus/config-parser.c (locate_attributes): remove dead code which
	always evaluated to TRUE

	* dbus/dbus-shell.c (_dbus_shell_quote): remove unused code
2008-01-15 13:32:47 -05:00
John (J5) Palmieri
fec58d8d78 plug a possible BusClientPolicy leak (FDO Bug #13242)
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* bus/connection.c (bus_connection_complete): plug a possible
	BusClientPolicy leak (FDO Bug #13242)
2008-01-14 19:04:41 -05:00
John (J5) Palmieri
831a0d71c4 add inotify support (FDO Bz#13268)
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Frederic Crozat <fcrozat at mandriva dot com> (FDO Bz#
	13268)

	* add inotify support

	* bus/Makefile.am: add inotify module to the build

	* bus/dir-watch-inotify.c: inotify module based off the dnotify and
	kqueue modules

	* configure.in: add checks and switch for inotify
	also add a printout at the end of configure if inotify and kqueue
	support is being built in (dnotify already had this)
2008-01-14 19:00:36 -05:00
John (J5) Palmieri
cbf5d0b6fa watch for file creates in dnotify
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Frederic Crozat <fcrozat at mandriva dot com>

	* bus/dir-watch-dnotify.c (bus_watch_directory): watch for file
	creates also
2008-01-14 18:17:53 -05:00
John (J5) Palmieri
c8e29a910b return message loader buffer in case of OOM (FDO Bug#12666)
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com>

	* dbus/dbus-transport-socket.c(do_reading): return message
	loader buffer in case of OOM (FDO Bug#12666)
2008-01-14 18:09:14 -05:00
John (J5) Palmieri
93e8a272d7 add warning to output when libxml is selected
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* configure.in: add warning to output when libxml is selected since
	we don't have a libxml maintainer and expat works perfectly fine
	for what we need an xml parser for
2008-01-14 15:53:13 -05:00
John (J5) Palmieri
ede4e45146 add _dbus_geteuid to fix EXTERNAL authentication in setuid applications
2008-01-14  John (J5) Palmieri  <johnp@redhat.com>

	* Patch by Andrea Luzzardi  <scox at sig11 dot org>: creates a
	_dbus_geteuid function to fix EXTERNAL authentication in setuid
	applications

	*  dbus/dbus-sysdeps-unix.c (_dbus_geteuid): used to get the effective
	uid of the running program
	(_dbus_credentials_add_from_current_process): use geteuid instead of
	getuid
	(_dbus_append_user_from_current_process): use geteuid instead of
	getuid

	* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user): use
	geteuid instead of getuid
	(_dbus_unix_user_is_at_console): use geteuid instead of getuid

	* dbus/dbus-sysdeps-win.c (_dbus_geteuid): add a windows equivilant
	that returns DBUS_UID_UNSET
2008-01-14 15:07:48 -05:00
Havoc Pennington
047ec880e9 fix some curly braces that were on the wrong line
2007-12-18  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-connection.c (_dbus_connection_block_pending_call):
	fix location of curly braces
2007-12-18 15:20:17 -05:00
Sjoerd Simons
ed47b4502b Allow a normal session bus to be reused by applications using autolaunching
2007-11-23  Sjoerd Simons  <sjoerd@luon.net>

   * tools/dbus-launch.c: let both a normal dbus-launch and an
   autolaunched bus save their parameters in X11 if possible. This makes
   the autolaunch and non-autolaunch behaviour more similar. With the
   exception that on a normal launch there will always be a new session
   bus and not being able to save parameters is not fatal. This also
   enables to launch programs directly with autolaunch (not very usefull
   though).
2007-11-23 11:31:05 +01:00
Havoc Pennington
bef4260ad5 Fix a problem where a nul byte was wrongly introduced into UUIDs, due to _dbus_string_copy_to_buffer weird behavior.
2007-10-31  Havoc Pennington  <hp@redhat.com>

	* bus/selinux.c (log_audit_callback): rewrite to use
	_dbus_string_copy_to_buffer_with_nul()

	* dbus/dbus-string.c (_dbus_string_copy_to_buffer): change to NOT
	nul-terminate the buffer; fail an assertion if there is not enough
	space in the target buffer. This fixes two bugs where
	copy_to_buffer was used to copy the binary bytes in a UUID, where
	nul termination did not make sense. Bug reported by David Castelow.
	(_dbus_string_copy_to_buffer_with_nul): new function that always
	nul-terminates the buffer, and fails an assertion if there is not
	enough space in the buffer.
2007-10-31 13:58:28 -04:00
Havoc Pennington
5340b8de0b audit_init() was not declared in header, causing warnings; fix this and namespace it
2007-10-23  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): use the new name here

	* bus/selinux.c (bus_selinux_audit_init): rename from audit_init()
	to avoid possible libc conflict, and declare it in .h file to
	avoid a warning
2007-10-23 14:48:52 -04:00
Havoc Pennington
a8e32b6874 add HAVE_SELINUX around call to audit_init() so things build without selinux
2007-10-19  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): put audit_init() in HAVE_SELINUX
2007-10-19 17:20:06 -04:00
Havoc Pennington
53f6713976 do not call audit_init() from bus/ directory from files in dbus/
2007-10-19  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): put the audit_init() in here
	instead, which I believe ends up being the same as where it was
	before, though I'm not sure I understand why it goes here.

	* dbus/dbus-sysdeps-util-unix.c (_dbus_change_to_daemon_user):
	remove audit_init() from here, this file can't depend on code in
	bus/ directory
2007-10-19 15:05:27 -04:00
Simon McVittie
71a357de56 configure.in: *Actually* fix detection of i486 atomic ops.
My previous attempt at a fix would always enable them due to wrong quoting.
Patch from Colin Walters <walters@verbum.org>
2007-10-16 10:13:15 +01:00
Simon McVittie
23bcdd7394 Amend ChangeLog - DBUS_ERROR_INIT is now used within libdbus as well as provided 2007-10-11 17:29:40 +01:00
Simon McVittie
f55897af74 Use DBUS_ERROR_INIT instead of dbus_error_init wherever it's clearly equivalent 2007-10-11 17:26:30 +01:00
Simon McVittie
e54d56b7b2 Merge branch 'inline' 2007-10-11 17:24:18 +01:00
Simon McVittie
d229e579a3 Merge branch 'atomic'
Conflicts:

	ChangeLog
2007-10-11 17:24:16 +01:00
Simon McVittie
48ad73fd5b Add J5's recent changes to ChangeLog 2007-10-11 10:56:12 +01:00
Simon McVittie
ecc4a25ed2 Update ChangeLog 2007-10-11 10:38:01 +01:00
Simon McVittie
a18ebe81bd Rename DBUS_ERROR_INITIALIZER to DBUS_ERROR_INIT per Havoc's review 2007-10-11 10:35:35 +01:00
Simon McVittie
262c02a9fa Add DBUS_ERROR_INITIALIZER macro 2007-10-11 10:35:25 +01:00
Simon McVittie
902beb7c2c Enable Autoconf's AC_C_INLINE to avoid compilation failure with gcc -ansi.
If inline isn't recognised (e.g. on a strict C90 compiler, like gcc -ansi) this
defines it to __inline__, __inline or nothing, whichever works. This is safe,
because we never use inline except in combination with static.
2007-10-11 10:27:28 +01:00
Simon McVittie
559de12aac Update ChangeLog 2007-10-11 10:20:09 +01:00
Simon McVittie
b6cd08a897 .gitignore: ignore vi swapfiles 2007-10-11 10:18:05 +01:00
Simon McVittie
35b00e3ab2 dbus-launch: convert C++-style comment to C-style, add {} for clarity 2007-10-11 10:17:17 +01:00
Simon McVittie
cc321d4ab3 dbus/dbus-server-socket.c: remove unused variable if disabling assertions 2007-10-11 10:17:05 +01:00
Simon McVittie
2349aa6d71 dbus/dbus-marshal-validate.c: get rid of empty statements 2007-10-11 10:16:56 +01:00
Simon McVittie
5fcdebe595 As per Havoc's review, rename DBUS_GNUC_EXTENSION to _DBUS_GNUC_EXTENSION.
Also update ChangeLog.
2007-10-11 10:11:21 +01:00
Simon McVittie
fd08741f27 dbus/dbus-arch-deps.h.in: also use DBUS_GNUC_EXTENSION for DBUS_INT64_CONSTANT and UINT64 equivalent 2007-10-11 10:07:02 +01:00
Simon McVittie
a2eace3a8b Use DBUS_GNUC_EXTENSION to avoid -ansi -pedantic warnings about use of long long. (#717) 2007-10-11 10:06:54 +01:00
Simon McVittie
6b512e4ee7 Add macro DBUS_GNUC_EXTENSION (the same as GLib's G_GNUC_EXTENSION)
Part of a fix for bug 717.
2007-10-11 10:06:45 +01:00
Simon McVittie
176738f0f0 Fix detection of i486 atomic ops.
Previously, the attempts to determine support at compile-time on Darwin were
causing the i486 atomic ops to be used on *all* i386 or x86-64 GCC builds
(AH_VERBATIM can't be conditionalized like we were trying to).
2007-10-11 09:57:48 +01:00
Simon McVittie
077fb290c5 Merge branch 'master' of ssh://git.freedesktop.org/git/dbus/dbus 2007-10-10 17:39:41 +01:00
Simon McVittie
8cff9309bf Update ChangeLog 2007-10-10 17:39:12 +01:00
Simon McVittie
9f22c3e1e8 Bring .gitignore files up to date; add *.o, *~ etc. to top-level .gitignore
CVS ignores these automatically, so they weren't in the .cvsignore when Ryan
converted the repository.
2007-10-10 17:38:00 +01:00
Simon McVittie
dfaca06084 Fix indentation in _dbus_object_tree_register declaration as per Havoc's review 2007-10-10 17:33:57 +01:00
Simon McVittie
df47bd4081 _dbus_object_tree_register: don't duplicate check for NULL and use new DBUS_ERROR_OBJECT_PATH_IN_USE error, both as per Havoc's review 2007-10-10 17:33:40 +01:00
Simon McVittie
d7fbcb5e02 Add error o.fd.D.Error.ObjectPathInUse (DBUS_ERROR_OBJECT_PATH_IN_USE) 2007-10-10 17:33:31 +01:00
Simon McVittie
557da17406 Add dbus_connection_try_register_object_path and dbus_connection_try_register_fallback, to make object path registration less painful for bindings 2007-10-10 17:33:18 +01:00
John (J5) Palmieri
1ca4b10e30 Fix env exports for better portability (#9280) 2007-10-09 15:50:08 -04:00
John (J5) Palmieri
f4ebd3a876 Document syntax for container types in dbus-send man file (#9553)
* Patch from Jack Spaar <jspaar at users.sourceforge.net>
2007-10-09 15:27:53 -04:00
Simon McVittie
1a5ef4003d Improve description of allowed variant signatures (#10185)
Patch based on one from Kristoffer Lundén, amended as per Havoc's comment.
2007-10-09 14:23:28 +01:00
Simon McVittie
fafd784424 doc/dbus-specification.xml: Clarify description of DBUS_COOKIE_SHA1 (#10184).
Patch from Kristoffer Lundén.
2007-10-09 14:12:31 +01:00