fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2025-12-27 04:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

test/loopback: Don't leak address strings

Browse source 
dbus_server_get_address() returns a copy. It isn't clear why.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=101567
This commit is contained in:
Simon McVittie 2017-06-28 18:49:18 +01:00
parent b951c5006c
commit fe19134bb6
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
test/loopback.c
View file

@ -160,10 +160,12 @@ static void
test_connect (Fixture *f,
gconstpointer addr G_GNUC_UNUSED)
{
char *address;
g_assert (f->server_conn == NULL);
f->client_conn = dbus_connection_open_private (
dbus_server_get_address (f->server), &f->e);
address = dbus_server_get_address (f->server);
g_test_message ("listening at %s", address);
f->client_conn = dbus_connection_open_private (address, &f->e);
assert_no_error (&f->e);
g_assert (f->client_conn != NULL);
test_connection_setup (f->ctx, f->client_conn);
@ -173,6 +175,8 @@ test_connect (Fixture *f,
test_progress ('.');
test_main_context_iterate (f->ctx, TRUE);
}
dbus_free (address);
}
static void
@ -180,7 +184,7 @@ test_bad_guid (Fixture *f,
gconstpointer addr G_GNUC_UNUSED)
{
DBusMessage *incoming;
gchar *address = g_strdup (dbus_server_get_address (f->server));
char *address = dbus_server_get_address (f->server);
gchar *guid;
g_test_bug ("39720");
@ -232,7 +236,7 @@ test_bad_guid (Fixture *f,
dbus_message_unref (incoming);
g_free (address);
dbus_free (address);
}
static void