fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2026-04-28 10:00:40 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'issue270' into 'master'

Browse source 
bus: Clarify names of methods that query owned names

Closes #270

See merge request dbus/dbus!114

Reviewed-by: @pwithnall
This commit is contained in:
Simon McVittie 2019-05-31 10:55:56 +00:00
commit fc28ea9959
5 changed files with 17 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bus/connection.c
View file

@ -1460,8 +1460,8 @@ bus_connection_get_n_match_rules (DBusConnection *connection)
* regardless of the type of ownership
*/
dbus_bool_t
bus_connection_is_name_owner_by_prefix (DBusConnection *connection,
const char *name_prefix)
bus_connection_is_queued_owner_by_prefix (DBusConnection *connection,
const char *name_prefix)
{
BusConnectionData *d;
DBusList *link;

4
bus/connection.h
View file

@ -83,8 +83,8 @@ void bus_connection_request_headers (DBusConnection *connection,
BusExtraHeaders headers);
/* called by policy.c */
dbus_bool_t bus_connection_is_name_owner_by_prefix (DBusConnection *connection,
const char *name_prefix);
dbus_bool_t bus_connection_is_queued_owner_by_prefix (DBusConnection *connection,
const char *name_prefix);
/* called by signals.c */
dbus_bool_t bus_connection_add_match_rule (DBusConnection *connection,

16
bus/policy.c
View file

@ -1055,9 +1055,9 @@ bus_client_policy_check_can_send (BusClientPolicy *policy,
continue;
}
if (!bus_service_has_owner (service, receiver))
if (!bus_service_owner_in_queue (service, receiver))
{
_dbus_verbose (" (policy) skipping rule because dest %s isn't owned by receiver\n",
_dbus_verbose (" (policy) skipping rule because receiver isn't primary or queued owner of name %s\n",
rule->d.send.destination);
continue;
}
@ -1084,17 +1084,17 @@ bus_client_policy_check_can_send (BusClientPolicy *policy,
rule->d.send.destination,
'.'))
{
_dbus_verbose (" (policy) skipping rule because message dest doesn't start with %s\n",
_dbus_verbose (" (policy) skipping rule because message dest doesn't have prefix %s\n",
rule->d.send.destination);
continue;
}
}
else
{
if (!bus_connection_is_name_owner_by_prefix (receiver,
rule->d.send.destination))
if (!bus_connection_is_queued_owner_by_prefix (receiver,
rule->d.send.destination))
{
_dbus_verbose (" (policy) skipping rule because no dest with prefix %s is owned by receiver\n",
_dbus_verbose (" (policy) skipping rule because recipient isn't primary or queued owner of any name below %s\n",
rule->d.send.destination);
continue;
}
@ -1307,9 +1307,9 @@ bus_client_policy_check_can_receive (BusClientPolicy *policy,
continue;
}
if (!bus_service_has_owner (service, sender))
if (!bus_service_owner_in_queue (service, sender))
{
_dbus_verbose (" (policy) skipping rule because origin %s isn't owned by sender\n",
_dbus_verbose (" (policy) skipping rule because sender isn't primary or queued owner of %s\n",
rule->d.receive.origin);
continue;
}

8
bus/services.c
View file

@ -670,7 +670,7 @@ bus_registry_release_service (BusRegistry *registry,
{
*result = DBUS_RELEASE_NAME_REPLY_NON_EXISTENT;
}
else if (!bus_service_has_owner (service, connection))
else if (!bus_service_owner_in_queue (service, connection))
{
*result = DBUS_RELEASE_NAME_REPLY_NOT_OWNER;
}
@ -680,7 +680,7 @@ bus_registry_release_service (BusRegistry *registry,
transaction, error))
goto out;
_dbus_assert (!bus_service_has_owner (service, connection));
_dbus_assert (!bus_service_owner_in_queue (service, connection));
*result = DBUS_RELEASE_NAME_REPLY_RELEASED;
}
@ -1274,8 +1274,8 @@ bus_service_get_allow_replacement (BusService *service)
}
dbus_bool_t
bus_service_has_owner (BusService *service,
DBusConnection *connection)
bus_service_owner_in_queue (BusService *service,
DBusConnection *connection)
{
DBusList *link;

2
bus/services.h
View file

@ -81,7 +81,7 @@ dbus_bool_t bus_service_remove_owner (BusService *service,
DBusConnection *connection,
BusTransaction *transaction,
DBusError *error);
dbus_bool_t bus_service_has_owner (BusService *service,
dbus_bool_t bus_service_owner_in_queue (BusService *service,
DBusConnection *connection);
BusOwner* bus_service_get_primary_owner (BusService *service);
dbus_bool_t bus_service_get_allow_replacement (BusService *service);