fdo-mirrors/dbus
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/dbus/dbus.git synced 2025-12-31 13:30:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Disallow unexpected replies

Browse source 
Allowing to send replies when NO_REPLY_EXPECTED is set is useless in
practice: Clients need to be careful not to send these replies, because
bus policy could deny these messages. The spec even mentions that this
issue exists.

To make this more clear and misbehaving clients less likely, disallow
sending unexpected replies entirely.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=75749
Reviewed-by: Philip Withnall <philip.withnall@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
This commit is contained in:
Lars Uebernickel 2015-11-02 15:47:39 +01:00 • committed by Simon McVittie
parent 9f36e212da
commit fc255f66f1
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
doc/dbus-specification.xml
View file

@ -1383,12 +1383,7 @@
<para>
This message does not expect method return replies or
error replies, even if it is of a type that can
have a reply; the reply can be omitted as an
optimization. It is compliant with this specification
to return the reply despite this flag, although doing
so on a bus with a non-trivial security policy
(such as the well-known system bus) may result in
access denial messages being logged for the reply.
have a reply; the reply should be omitted.
</para>
<para>
Note that METHOD_CALL is the only message type currently
@ -1864,12 +1859,9 @@
header field.
</para>
<para>
If a <literal>METHOD_CALL</literal> message has the flag <literal>NO_REPLY_EXPECTED</literal>,
then as an optimization the application receiving the method
call may choose to omit the reply message (regardless of
whether the reply would have been <literal>METHOD_RETURN</literal> or <literal>ERROR</literal>).
However, it is also acceptable to ignore the <literal>NO_REPLY_EXPECTED</literal>
flag and reply anyway.
If a <literal>METHOD_CALL</literal> message has the flag <literal>NO_REPLY_EXPECTED</literal>,
then the application receiving the method should not send the reply message (regardless of
whether the reply would have been <literal>METHOD_RETURN</literal> or <literal>ERROR</literal>).
</para>
<para>
Unless a message has the flag <literal>NO_AUTO_START</literal>, if the